Integrated: 8288979: Improve CLDRConverter run time

2022-06-23 Thread Daniel Jeliński
On Wed, 22 Jun 2022 14:24:05 GMT, Daniel Jeliński wrote: > This PR improves the performance of deduplication done by > ResourceBundleGenerator. > > The original implementation compared every pair of values, requiring O(n^2) > time. The new implementation uses a HashMap to find duplicates, trad

Re: RFR: 8288979: Improve CLDRConverter run time [v3]

2022-06-23 Thread Naoto Sato
On Thu, 23 Jun 2022 08:53:37 GMT, Daniel Jeliński wrote: >> This PR improves the performance of deduplication done by >> ResourceBundleGenerator. >> >> The original implementation compared every pair of values, requiring O(n^2) >> time. The new implementation uses a HashMap to find duplicates,

Integrated: JDK-8288740: Change incorrect documentation for sjavac flag

2022-06-23 Thread Julian Waters
On Mon, 20 Jun 2022 13:01:40 GMT, Julian Waters wrote: > The documentation for build performance currently points to the non-existent > --enable-sjavac flag to enable sjavac, the correct one is actually > --enable-javac-server (Finally seem to have gotten pandoc working, hopefully > the html i

Re: RFR: 8288979: Improve CLDRConverter run time [v3]

2022-06-23 Thread Roger Riggs
On Thu, 23 Jun 2022 08:53:37 GMT, Daniel Jeliński wrote: >> This PR improves the performance of deduplication done by >> ResourceBundleGenerator. >> >> The original implementation compared every pair of values, requiring O(n^2) >> time. The new implementation uses a HashMap to find duplicates,

Re: RFR: 8288979: Improve CLDRConverter run time [v3]

2022-06-23 Thread Daniel Jeliński
On Thu, 23 Jun 2022 08:56:08 GMT, Daniel Jeliński wrote: >> BTW, this can utilize the new `HashMap.newHashMap()`, although I don't think >> resizing would be occurring in this case. > >> once this fix makes it to the repository, the build will be reproducible > > Yes, we always produce the same

Re: RFR: 8288979: Improve CLDRConverter run time [v3]

2022-06-23 Thread Daniel Jeliński
On Wed, 22 Jun 2022 21:45:25 GMT, Naoto Sato wrote: >> IIUC, once this fix makes it to the repository, the build will be >> reproducible. Making it to be sorted is a welcome enhancement (I compare the >> generated bundles manually from time to time), but it may be costly so it >> could defy th

Re: RFR: 8288979: Improve CLDRConverter run time [v3]

2022-06-23 Thread Daniel Jeliński
> This PR improves the performance of deduplication done by > ResourceBundleGenerator. > > The original implementation compared every pair of values, requiring O(n^2) > time. The new implementation uses a HashMap to find duplicates, trading off > some extra memory consumption for O(n) computati