Re: RFR: 8289646: configure script failed on WSL [v3]

2022-07-07 Thread Yasumasa Suenaga
On Thu, 7 Jul 2022 10:18:15 GMT, Magnus Ihse Bursie wrote: > I don't get it, you are saying that in mainline you get no warning but with > your patch you get a warning, and yet you claim behavior is the same? > > On one hand, it seems like the latter behavior is indeed more correct, if you > p

Re: RFR: 8289646: configure script failed on WSL [v3]

2022-07-07 Thread Magnus Ihse Bursie
On Tue, 5 Jul 2022 03:07:10 GMT, Yasumasa Suenaga wrote: >> configure failed as following when I run it on WSL 1. >> >> >> checking for version string... 20-internal-adhoc.yasuenag.jdk >> configure: Found potential Boot JDK using configure arguments >> configure: The command for java_to_test, w

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v13]

2022-07-07 Thread Christian Hagedorn
> When printing the native stack trace on Linux (mostly done for hs_err files), > it only prints the method with its parameters and a relative offset in the > method: > > Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x7f6e01838110, free > space=1020k > Native frames: (J=compiled Jav

Re: RFR: 8289646: configure script failed on WSL [v3]

2022-07-07 Thread Yasumasa Suenaga
On Wed, 6 Jul 2022 17:47:21 GMT, Magnus Ihse Bursie wrote: > I'm worried that with the patch you are proposing, we will unconditinonally > add `.exe` to any path that is not existing, which will make the next test > fail (since then the path with the addition of `.exe` will most likely not > e

Re: RFR: 8289834: Add SBCS and DBCS Only EBCDIC charsets

2022-07-07 Thread Alan Bateman
On Wed, 6 Jul 2022 16:18:08 GMT, Ichiroh Takiguchi wrote: > Discussions are available on : > [JDK-8289834](https://bugs.openjdk.org/browse/JDK-8289834): Add SBCS and DBCS > Only EBCDIC charsets Yes, I think this need discussion on whether the JDK really needs to keep including and adding more

Re: RFR: 8289646: configure script failed on WSL [v3]

2022-07-07 Thread Magnus Ihse Bursie
On Tue, 5 Jul 2022 03:07:10 GMT, Yasumasa Suenaga wrote: >> configure failed as following when I run it on WSL 1. >> >> >> checking for version string... 20-internal-adhoc.yasuenag.jdk >> configure: Found potential Boot JDK using configure arguments >> configure: The command for java_to_test, w

Re: RFR: 8289646: configure script failed on WSL [v3]

2022-07-07 Thread Magnus Ihse Bursie
On Tue, 5 Jul 2022 03:07:10 GMT, Yasumasa Suenaga wrote: >> configure failed as following when I run it on WSL 1. >> >> >> checking for version string... 20-internal-adhoc.yasuenag.jdk >> configure: Found potential Boot JDK using configure arguments >> configure: The command for java_to_test, w

RFR: 8289834: Add SBCS and DBCS Only EBCDIC charsets

2022-07-07 Thread Ichiroh Takiguchi
OpenJDK supports "Japanese EBCDIC - Katakana" and "Korean EBCDIC" SBCS and DBCS Only charsets. |Charset|Mix|SBCS|DBCS| | -- | -- | -- | -- | | Japanese EBCDIC - Katakana | Cp930 | Cp290 | Cp300 | | Korean | Cp933 | Cp833 | Cp834 | But OpenJDK does not supports some of "Japanese EBCDIC - English"

RE: Warning about git from 'make test' on Windows

2022-07-07 Thread Langer, Christoph
Hi Magnus, thanks for opening the bug and I hope you'll get to fix it eventually. It's not urgent to me, though. I might add that I fixed the error message for me by installing the Cygwin package for Git. By doing that, it is correctly picked up and no issues with the path to it. Best regards

Re: RFR: 8289834: Add SBCS and DBCS Only EBCDIC charsets

2022-07-07 Thread Ichiroh Takiguchi
On Wed, 6 Jul 2022 14:05:39 GMT, Ichiroh Takiguchi wrote: > OpenJDK supports "Japanese EBCDIC - Katakana" and "Korean EBCDIC" SBCS and > DBCS Only charsets. > |Charset|Mix|SBCS|DBCS| > | -- | -- | -- | -- | > | Japanese EBCDIC - Katakana | Cp930 | Cp290 | Cp300 | > | Korean | Cp933 | Cp833 | Cp