Re: [EXTERNAL] Re: GitHub workflows using setup-java action instead of hardcoded URLs

2022-07-12 Thread David Holmes
On 12/07/2022 7:35 pm, George Adams wrote: Hu Alan, By using the setup-java action with release set to a major version (e.g 18) it will always pull the latest GA build of OpenJDK for that version. E.g 18 currently sets up jdk-18.0.1+10 in the GitHub actions environment. The point is that by

Re: Minimal JVM

2022-07-12 Thread Thomas Stüfe
Hi Julian, the minimal build filters out a whole bunch of optional JVM subsystems in the configure stage, see https://github.com/openjdk/jdk/blob/04c47da118b2870d1c7525348a2ffdf9cd1cc0a4/make/autoconf/jvm-features.m4#L422-L425 That typically manifests via flags like -DINCLUDE_CDS=0, see

Minimal JVM

2022-07-12 Thread Julian Waters
Sorry if this sounds like a bit of a silly question, but what's the difference between a Minimal VM (Enabled by --enable-jvm-feature-minimal), and, say, the regular Server VM the build system generates by default? All it seems to do is define MINIMAL_JVM (Which doesn't seem to be used anywhere?),

Minimal JVM

2022-07-12 Thread Julian Waters
Sorry if this sounds like a bit of a silly question, but what's the difference between a Minimal VM (Enabled by --enable-jvm-feature-minimal), and, say, the regular Server VM the build system generates by default? All it seems to do is define MINIMAL_JVM (Which doesn't seem to be used anywhere?),

Re: [EXTERNAL] Re: GitHub workflows using setup-java action instead of hardcoded URLs

2022-07-12 Thread George Adams
Yes sorry, perhaps I didn’t make that very clear -George From: Alan Bateman Date: Tuesday, 12 July 2022 at 11:04 To: George Adams , build-dev@openjdk.org Subject: Re: [EXTERNAL] Re: GitHub workflows using setup-java action instead of hardcoded URLs On 12/07/2022 10:35, George Adams wrote:

Re: [EXTERNAL] Re: GitHub workflows using setup-java action instead of hardcoded URLs

2022-07-12 Thread George Adams
Hu Alan, By using the setup-java action with release set to a major version (e.g 18) it will always pull the latest GA build of OpenJDK for that version. E.g 18 currently sets up jdk-18.0.1+10 in the GitHub actions environment. The point is that by switching to using a setup-java action it

Re: [EXTERNAL] Re: GitHub workflows using setup-java action instead of hardcoded URLs

2022-07-12 Thread Alan Bateman
On 12/07/2022 10:23, George Adams wrote: H David, The key difference is that we wouldn’t nee to keep updating the full version number/checksum. We could ofcourse use the oracle-actions/setup-java and do something like this:   - name: 'Set up

Re: [EXTERNAL] Re: GitHub workflows using setup-java action instead of hardcoded URLs

2022-07-12 Thread George Adams
H David, The key difference is that we wouldn’t nee to keep updating the full version number/checksum. We could ofcourse use the oracle-actions/setup-java and do something like this: - name: 'Set up latest Oracle JDK 18' uses: