Re: RFR: 8291360: Create entry points to expose low-level class file information

2022-07-29 Thread Roger Riggs
On Fri, 29 Jul 2022 21:05:19 GMT, Roger Riggs wrote: >> Please review this change to fix JDK-8291360. This fix adds entry points >> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. >> The new entry points return the current class's class file version and its >> ra

Re: RFR: 8291360: Create entry points to expose low-level class file information

2022-07-29 Thread Roger Riggs
On Fri, 29 Jul 2022 18:02:46 GMT, Harold Seigel wrote: > Please review this change to fix JDK-8291360. This fix adds entry points > getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. > The new entry points return the current class's class file version and its > raw

Re: RFR: 8291360: Create entry points to expose low-level class file information

2022-07-29 Thread Harold Seigel
On Fri, 29 Jul 2022 18:12:22 GMT, Joe Darcy wrote: >> Please review this change to fix JDK-8291360. This fix adds entry points >> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. >> The new entry points return the current class's class file version and its >> raw

Re: RFR: 8291360: Create entry points to expose low-level class file information

2022-07-29 Thread Joe Darcy
On Fri, 29 Jul 2022 18:02:46 GMT, Harold Seigel wrote: > Please review this change to fix JDK-8291360. This fix adds entry points > getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. > The new entry points return the current class's class file version and its > raw

RFR: 8291360: Create entry points to expose low-level class file information

2022-07-29 Thread Harold Seigel
Please review this change to fix JDK-8291360. This fix adds entry points getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. The new entry points return the current class's class file version and its raw access flags. The fix was tested by running Mach5 tiers 1-2 on L

Re: RFR: 8290466: Default to --with-source-date=current to avoid unmodified Hotspot recompilation

2022-07-29 Thread Aleksey Shipilev
On Fri, 29 Jul 2022 09:14:30 GMT, Magnus Ihse Bursie wrote: > Sorry for the slow response, I'm on vacation. Ah. I seen a few replies from you assumed you are back. > ``` > [how to set SOURCE_DATE_EPOCH ('updated', 'current', 'version' a > timestamp or an ISO-8601 date) @<:@current/value

Re: RFR: 8290466: Default to --with-source-date=current to avoid unmodified Hotspot recompilation [v2]

2022-07-29 Thread Aleksey Shipilev
> See the bug for symptoms and rationale. > > In short, after [JDK-8288396](https://bugs.openjdk.org/browse/JDK-8288396) > moved the timestamp to `CFLAGS_VM_VERSION` macro, which changes with every > build, we get Hotspot recompilation every time, even when Hotspot is not > modified. > > I bel

Re: RFR: 8290466: Default to --with-source-date=current to avoid unmodified Hotspot recompilation

2022-07-29 Thread Magnus Ihse Bursie
On Tue, 26 Jul 2022 12:28:41 GMT, Aleksey Shipilev wrote: > See the bug for symptoms and rationale. > > In short, after [JDK-8288396](https://bugs.openjdk.org/browse/JDK-8288396) > moved the timestamp to `CFLAGS_VM_VERSION` macro, which changes with every > build, we get Hotspot recompilation

Re: RFR: 8290466: Default to --with-source-date=current to avoid unmodified Hotspot recompilation

2022-07-29 Thread Aleksey Shipilev
On Tue, 26 Jul 2022 12:28:41 GMT, Aleksey Shipilev wrote: > See the bug for symptoms and rationale. > > In short, after [JDK-8288396](https://bugs.openjdk.org/browse/JDK-8288396) > moved the timestamp to `CFLAGS_VM_VERSION` macro, which changes with every > build, we get Hotspot recompilation