Re: RFR: 8291360: Create entry points to expose low-level class file information [v3]

2022-08-02 Thread Roger Riggs
On Tue, 2 Aug 2022 14:12:44 GMT, Harold Seigel wrote: >> Please review this change to fix JDK-8291360. This fix adds entry points >> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. >> The new entry points return the current class's class file version and its >> r

Re: RFR: 8291360: Create entry points to expose low-level class file information [v3]

2022-08-02 Thread Harold Seigel
On Tue, 2 Aug 2022 06:36:54 GMT, David Holmes wrote: >> No particular reason for choosing 59 other than it's different and less than >> 64. Test case Version64_65535 has a non-zero minor version. > > I think we should be testing for other real classfile versions that may be > encountered, such

Re: RFR: 8291360: Create entry points to expose low-level class file information [v2]

2022-08-02 Thread Harold Seigel
On Tue, 2 Aug 2022 06:24:10 GMT, David Holmes wrote: >> Harold Seigel has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improved tests, added mulit-dimensional array tests, simplified new >> java.lang.Class API's > > src/java.base/share/c

Re: RFR: 8291360: Create entry points to expose low-level class file information [v3]

2022-08-02 Thread Harold Seigel
> Please review this change to fix JDK-8291360. This fix adds entry points > getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. > The new entry points return the current class's class file version and its > raw access flags. > > The fix was tested by running Mach5 ti

Re: RFR: 8291360: Create entry points to expose low-level class file information [v2]

2022-08-02 Thread Harold Seigel
On Tue, 2 Aug 2022 06:51:46 GMT, David Holmes wrote: >> Changed to display as major:minor version. > > Seems odd to display as major:minor when it is stored as minor:major I think it seems more natural to display the major version first, but I can change it if you prefer. - PR: ht

Re: RFR: 8291360: Create entry points to expose low-level class file information [v2]

2022-08-02 Thread David Holmes
On Tue, 2 Aug 2022 06:38:11 GMT, David Holmes wrote: >> Harold Seigel has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improved tests, added mulit-dimensional array tests, simplified new >> java.lang.Class API's > > test/hotspot/jtreg/ru