Re: RFR: 8291916: Unexpected output on Arabic Windows command prompt

2022-08-04 Thread Alan Bateman
On Fri, 5 Aug 2022 02:15:21 GMT, Ichiroh Takiguchi wrote: > To support Windows command prompt's codepage, following charsets should be > moved from jdk.charsets module to java.base module. > > - IBM860 > - IBM861 > - IBM863 > - IBM864 > - IBM865 > - IBM869 IBM860 is Portuguese, IBM861 is Icel

Re: RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests [v12]

2022-08-04 Thread David Holmes
On Thu, 4 Aug 2022 22:59:34 GMT, Sergey Bylokhov wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove bundle artifacts > > .github/workflows/main.yml line 85: > >> 83: input='${{ secrets.JDK_

RFR: 8291916: Unexpected output on Arabic Windows command prompt

2022-08-04 Thread Ichiroh Takiguchi
To support Windows command prompt's codepage, following charsets should be moved from jdk.charsets module to java.base module. - IBM860 - IBM861 - IBM863 - IBM864 - IBM865 - IBM869 - Commit messages: - 8291916: Unexpected output on Arabic Windows command prompt Changes: https://gi

Re: RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests [v12]

2022-08-04 Thread Sergey Bylokhov
On Mon, 13 Jun 2022 06:45:49 GMT, Magnus Ihse Bursie wrote: >> With project Skara, the ability to run a set of sanity build and test jobs >> on selected platforms was added. This functionality was driven by >> `.github/workflows/submit.yml`. This file unfortunately lacks any real >> structure,

Integrated: 8291360: Create entry points to expose low-level class file information

2022-08-04 Thread Harold Seigel
On Fri, 29 Jul 2022 18:02:46 GMT, Harold Seigel wrote: > Please review this change to fix JDK-8291360. This fix adds entry points > getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. > The new entry points return the current class's class file version and its > raw

Re: RFR: 8291360: Create entry points to expose low-level class file information [v4]

2022-08-04 Thread Harold Seigel
On Thu, 4 Aug 2022 12:51:33 GMT, Harold Seigel wrote: >> Please review this change to fix JDK-8291360. This fix adds entry points >> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. >> The new entry points return the current class's class file version and its >> r

Re: RFR: 8291360: Create entry points to expose low-level class file information [v4]

2022-08-04 Thread David Holmes
On Thu, 4 Aug 2022 12:47:13 GMT, Harold Seigel wrote: >> I think it should match the underlying representation else it may cause >> someone trying to debug a failure to look at the wrong part of the flags >> value, not realizing the printed value has the opposite format of the actual >> raw va

Re: RFR: 8291360: Create entry points to expose low-level class file information [v4]

2022-08-04 Thread David Holmes
On Thu, 4 Aug 2022 12:51:33 GMT, Harold Seigel wrote: >> Please review this change to fix JDK-8291360. This fix adds entry points >> getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. >> The new entry points return the current class's class file version and its >> r

Re: RFR: 8291360: Create entry points to expose low-level class file information [v4]

2022-08-04 Thread Harold Seigel
On Thu, 4 Aug 2022 12:28:51 GMT, David Holmes wrote: >> I think it seems more natural to display the major version first, but I can >> change it if you prefer. > > I think it should match the underlying representation else it may cause > someone trying to debug a failure to look at the wrong pa

Re: RFR: 8291360: Create entry points to expose low-level class file information [v4]

2022-08-04 Thread Harold Seigel
> Please review this change to fix JDK-8291360. This fix adds entry points > getClassFileVersion() and getClassAccessFlagsRaw() to class java.lang.Class. > The new entry points return the current class's class file version and its > raw access flags. > > The fix was tested by running Mach5 ti

Re: RFR: 8291360: Create entry points to expose low-level class file information [v3]

2022-08-04 Thread Coleen Phillimore
On Thu, 4 Aug 2022 12:28:51 GMT, David Holmes wrote: >> I think it seems more natural to display the major version first, but I can >> change it if you prefer. > > I think it should match the underlying representation else it may cause > someone trying to debug a failure to look at the wrong pa

Re: RFR: 8291360: Create entry points to expose low-level class file information [v3]

2022-08-04 Thread David Holmes
On Tue, 2 Aug 2022 12:45:49 GMT, Harold Seigel wrote: >> Seems odd to display as major:minor when it is stored as minor:major > > I think it seems more natural to display the major version first, but I can > change it if you prefer. I think it should match the underlying representation else it

Integrated: 8291762: Backout JDK-8291757 from jdk/jdk

2022-08-04 Thread David Holmes
On Thu, 4 Aug 2022 07:19:47 GMT, David Holmes wrote: > Restore the "ea" on the version string > > Thanks This pull request has now been integrated. Changeset: 0bc804d6 Author:David Holmes URL: https://git.openjdk.org/jdk/commit/0bc804d6ef66426f93f4bef4641a377a4400827d Stats: 1

Re: RFR: 8291762: Backout JDK-8291757 from jdk/jdk

2022-08-04 Thread David Holmes
On Thu, 4 Aug 2022 07:34:12 GMT, Alan Bateman wrote: >> Restore the "ea" on the version string >> >> Thanks > > Marked as reviewed by alanb (Reviewer). Thanks @AlanBateman ! - PR: https://git.openjdk.org/jdk/pull/9739

Re: RFR: 8291762: Backout JDK-8291757 from jdk/jdk

2022-08-04 Thread Alan Bateman
On Thu, 4 Aug 2022 07:19:47 GMT, David Holmes wrote: > Restore the "ea" on the version string > > Thanks Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9739

RFR: 8291762: Backout JDK-8291757 from jdk/jdk

2022-08-04 Thread David Holmes
Restore the "ea" on the version string Thanks - Commit messages: - 8291762: Backout JDK-8291757 from jdk/jdk Changes: https://git.openjdk.org/jdk/pull/9739/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9739&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291762 S

Integrated: Merge jdk19

2022-08-04 Thread David Holmes
On Thu, 4 Aug 2022 07:03:25 GMT, David Holmes wrote: > Forward port JDK 19 -> JDK 20 This pull request has now been integrated. Changeset: 34939731 Author:David Holmes URL: https://git.openjdk.org/jdk/commit/349397318687fdb7be8f50f02b536e49bffdd92f Stats: 1 line in 1 file change

RFR: Merge jdk19

2022-08-04 Thread David Holmes
Forward port JDK 19 -> JDK 20 - Commit messages: - Merge remote-tracking branch 'jdk19/master' into Merge_jdk19 - 8291757: Remove EA from JDK 19 version string starting with Initial RC promotion B35 on August 11, 2022 The webrevs contain the adjustments done while merging with reg