Re: RFR: 8291454: Missing check for JLI C runtime library in CoreLibraries.gmk

2022-08-07 Thread Julian Waters
On Thu, 28 Jul 2022 02:20:26 GMT, Julian Waters wrote: > CoreLibraries.gmk is missing a check for MSVCR_DLL. This results in a > defined, but empty macro in libjli if it is not defined in the build system, > which is incorrect Merged with latest, currently awaiting further review and/or sponso

Re: RFR: 8291454: Missing check for JLI C runtime library in CoreLibraries.gmk [v2]

2022-08-07 Thread Julian Waters
> CoreLibraries.gmk is missing a check for MSVCR_DLL. This results in a > defined, but empty macro in libjli if it is not defined in the build system, > which is incorrect Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev exclud

Re: RFR: 8291916: Unexpected output on Arabic Windows command prompt

2022-08-07 Thread Ichiroh Takiguchi
On Fri, 5 Aug 2022 16:44:37 GMT, Naoto Sato wrote: >> To support Windows command prompt's codepage, following charsets should be >> moved from jdk.charsets module to java.base module. >> >> - IBM860 >> - IBM861 >> - IBM863 >> - IBM864 >> - IBM865 >> - IBM869 > > Hi @takiguc, > I am not quite su