Re: RFR: 8292275: javac does not emit SYNTHETIC and MANDATED flags for parameters by default

2022-08-12 Thread Joe Darcy
On Fri, 12 Aug 2022 22:36:37 GMT, Joe Darcy wrote: >> With this change, javac emits the MethodParameters attribute in cases where >> the JLS requires the information about synthetic and mandated parameters to >> be stored (see issue). >> Parameter names are *not* emitted unless the `-parameter`

Re: RFR: 8292275: javac does not emit SYNTHETIC and MANDATED flags for parameters by default

2022-08-12 Thread Joe Darcy
On Fri, 12 Aug 2022 19:54:59 GMT, Hannes Greule wrote: > With this change, javac emits the MethodParameters attribute in cases where > the JLS requires the information about synthetic and mandated parameters to > be stored (see issue). > Parameter names are *not* emitted unless the `-parameter`

RFR: 8292275: javac does not emit SYNTHETIC and MANDATED flags for parameters by default

2022-08-12 Thread Hannes Greule
With this change, javac emits the MethodParameters attribute in cases where the JLS requires the information about synthetic and mandated parameters to be stored (see issue). Parameter names are *not* emitted unless the `-parameter` flag is set. The relevant changes are in `ClassWriter`, where w

Re: RFR: 8292226: Prepare make for better Link Time Optimization support [v5]

2022-08-12 Thread Julian Waters
> The support for Link Time Optimization in the JDK's make system could do with > some cleaning up, at the moment it simply assumes the compiler is gcc and > sets the flags as such. Instead of introducing changes in bulk, as a first > step, it would be good to simply supply the appropriate flags

Re: RFR: 8292226: Prepare make for better Link Time Optimization support [v4]

2022-08-12 Thread Julian Waters
> The support for Link Time Optimization in the JDK's make system could do with > some cleaning up, at the moment it simply assumes the compiler is gcc and > sets the flags as such. Instead of introducing changes in bulk, as a first > step, it would be good to simply supply the appropriate flags

Re: RFR: 8292226: Prepare make for better Link Time Optimization support [v3]

2022-08-12 Thread Julian Waters
> The support for Link Time Optimization in the JDK's make system could do with > some cleaning up, at the moment it simply assumes the compiler is gcc and > sets the flags as such. Instead of introducing changes in bulk, as a first > step, it would be good to simply supply the appropriate flags