Re: RFR: 8293116: Incremental JDK build could be sped up [v3]

2022-09-07 Thread Erik Joelsson
On Wed, 7 Sep 2022 13:57:45 GMT, Jan Lahoda wrote: >> ... and also that we *must* include the vardeps file, since any change there >> should trigger a complete rebuild. >> >> The logic here seems correct, but apparently somewhat hard to fully >> understand correctly. Maybe a few lines of comme

Integrated: JDK-8289798: Update to use jtreg 7

2022-09-07 Thread Christian Stein
On Wed, 6 Jul 2022 08:24:21 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion`

Re: RFR: 8293116: Incremental JDK build could be sped up [v3]

2022-09-07 Thread Jan Lahoda
On Tue, 6 Sep 2022 14:33:10 GMT, Magnus Ihse Bursie wrote: >>> The `Depend` plugin will do a full build if a non-Java file is present in >>> the list, which I hope should lead to a more reliable recompilation for >>> some complex changes among the sources. >> >> Ah, I had missed that and that'

Re: RFR: 8293116: Incremental JDK build could be sped up [v4]

2022-09-07 Thread Jan Lahoda
> Currently, when doing a small change inside a module that does not affect the > API of the module, the build system will skip rebuild of the dependent > modules. If there's a change that affects the module's API, the dependent > modules are recompiled. So far, this seems to work reasonably. >