Re: RFR: 8294076: Improve ant detection in idea.sh

2022-09-20 Thread Erik Joelsson
On Tue, 20 Sep 2022 21:45:05 GMT, Magnus Ihse Bursie wrote: > The ant detection in bin/idea.sh is very rudimentary. It fails at a modern > aarch64 macOS installation. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.org/jdk/pull/10364

RFR: 8294076: Improve ant detection in idea.sh

2022-09-20 Thread Magnus Ihse Bursie
The ant detection in bin/idea.sh is very rudimentary. It fails at a modern aarch64 macOS installation. - Commit messages: - 8294076: Improve ant detection in idea.sh Changes: https://git.openjdk.org/jdk/pull/10364/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10364&range=

Re: RFR: 8293532: Use lighter jmod compression levels in build config [v3]

2022-09-20 Thread Magnus Ihse Bursie
On Tue, 20 Sep 2022 18:57:45 GMT, Aleksey Shipilev wrote: >> As follow-up to [JDK-8293499](https://bugs.openjdk.org/browse/JDK-8293499), >> JDK build can stick to lighter jmod compression levels to gain build >> performance. >> >> >> # - Baseline >> $ time CONF=linux-x86_64-server-release

Re: RFR: 8293532: Use lighter jmod compression levels in build config [v2]

2022-09-20 Thread Aleksey Shipilev
On Tue, 20 Sep 2022 15:00:48 GMT, Aleksey Shipilev wrote: >> As follow-up to [JDK-8293499](https://bugs.openjdk.org/browse/JDK-8293499), >> JDK build can stick to lighter jmod compression levels to gain build >> performance. >> >> >> # - Baseline >> $ time CONF=linux-x86_64-server-release

Re: RFR: 8293532: Use lighter jmod compression levels in build config [v2]

2022-09-20 Thread Aleksey Shipilev
On Tue, 20 Sep 2022 17:29:21 GMT, Magnus Ihse Bursie wrote: >> Aleksey Shipilev has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Typos >> - GHA should use the zip-1 level across all builds >> - Move detection and defaults to configu

Re: RFR: 8293532: Use lighter jmod compression levels in build config [v3]

2022-09-20 Thread Aleksey Shipilev
On Mon, 19 Sep 2022 12:48:21 GMT, Erik Joelsson wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Should be "literal" > > make/autoconf/jdk-options.m4 line 481: > >> 479: AC_DEFUN_ONCE([JDKOPT_SETUP_JMOD_OPTIONS

Re: RFR: 8293532: Use lighter jmod compression levels in build config [v3]

2022-09-20 Thread Aleksey Shipilev
> As follow-up to [JDK-8293499](https://bugs.openjdk.org/browse/JDK-8293499), > JDK build can stick to lighter jmod compression levels to gain build > performance. > > > # - Baseline > $ time CONF=linux-x86_64-server-release make clean-images images > real 0m10.762s > user 1m5.157s > sys

Re: RFR: 8293532: Use lighter jmod compression levels in build config [v2]

2022-09-20 Thread Magnus Ihse Bursie
On Tue, 20 Sep 2022 15:00:48 GMT, Aleksey Shipilev wrote: >> As follow-up to [JDK-8293499](https://bugs.openjdk.org/browse/JDK-8293499), >> JDK build can stick to lighter jmod compression levels to gain build >> performance. >> >> >> # - Baseline >> $ time CONF=linux-x86_64-server-release

Integrated: 8294006: Avoid hardcoding object file suffixes in make

2022-09-20 Thread Julian Waters
On Mon, 19 Sep 2022 12:55:47 GMT, Julian Waters wrote: > Replaces hardcoding of object file suffixes in make, to ensure they are > always reliably set from a single place in autoconf. This pull request has now been integrated. Changeset: cb5771dc Author:Julian Waters Committer: Magnus Ihs

Re: RFR: 8293116: Incremental JDK build could be sped up [v6]

2022-09-20 Thread Magnus Ihse Bursie
On Tue, 20 Sep 2022 09:50:00 GMT, Jan Lahoda wrote: >> Currently, when doing a small change inside a module that does not affect >> the API of the module, the build system will skip rebuild of the dependent >> modules. If there's a change that affects the module's API, the dependent >> modules

Re: RFR: 8293532: Use lighter jmod compression levels in build config [v2]

2022-09-20 Thread Aleksey Shipilev
> As follow-up to [JDK-8293499](https://bugs.openjdk.org/browse/JDK-8293499), > JDK build can stick to lighter jmod compression levels to gain build > performance. > > > # - Baseline > $ time CONF=linux-x86_64-server-release make clean-images images > real 0m10.762s > user 1m5.157s > sys

Re: RFR: 8293532: Use lighter jmod compression levels in build config

2022-09-20 Thread Magnus Ihse Bursie
On Thu, 8 Sep 2022 08:08:54 GMT, Aleksey Shipilev wrote: > As follow-up to [JDK-8293499](https://bugs.openjdk.org/browse/JDK-8293499), > JDK build can stick to lighter jmod compression levels to gain build > performance. > > > # - Baseline > $ time CONF=linux-x86_64-server-release make cl

Re: RFR: 8293532: Use lighter jmod compression levels in build config

2022-09-20 Thread Alan Bateman
On Thu, 8 Sep 2022 08:08:54 GMT, Aleksey Shipilev wrote: > As follow-up to [JDK-8293499](https://bugs.openjdk.org/browse/JDK-8293499), > JDK build can stick to lighter jmod compression levels to gain build > performance. > > > # - Baseline > $ time CONF=linux-x86_64-server-release make cl

Re: RFR: 8293116: Incremental JDK build could be sped up [v6]

2022-09-20 Thread Jan Lahoda
> Currently, when doing a small change inside a module that does not affect the > API of the module, the build system will skip rebuild of the dependent > modules. If there's a change that affects the module's API, the dependent > modules are recompiled. So far, this seems to work reasonably. >