Re: RFR: 8295792: Clean up old async close code

2022-10-21 Thread Alan Bateman
On Fri, 21 Oct 2022 14:28:02 GMT, Daniel Jeliński wrote: > Please review this PR that removes the remains of old fdTable-based socket > close synchronization. > > Verified that tier1-3 tests continue to pass on Linux, MacOS and Windows. Did > not verify AIX. > > Also removed one slow test for

Re: RFR: 8284840: Update CLDR to Version 42.0

2022-10-21 Thread Steven R . Loomis
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote: > This is to update the CLDR data from version 41 to version 42. The vast > majority of the changes are basically replacing the CLDR data, along with > tools/testcase alignments to those upstream changes: > > https://unicode-org.atlassian.net

Re: RFR: 8284840: Update CLDR to Version 42.0

2022-10-21 Thread Joe Wang
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote: > This is to update the CLDR data from version 41 to version 42. The vast > majority of the changes are basically replacing the CLDR data, along with > tools/testcase alignments to those upstream changes: > > https://unicode-org.atlassian.net

Re: RFR: 8284840: Update CLDR to Version 42.0

2022-10-21 Thread Naoto Sato
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote: > This is to update the CLDR data from version 41 to version 42. The vast > majority of the changes are basically replacing the CLDR data, along with > tools/testcase alignments to those upstream changes: > > https://unicode-org.atlassian.net

Re: RFR: 8284840: Update CLDR to Version 42.0

2022-10-21 Thread Naoto Sato
On Fri, 21 Oct 2022 19:16:57 GMT, Joe Wang wrote: > Are the first two items (CLDR-14032, CLDR-14831) considered a behavior change > (e.g. the format string will be different) that could use a CSR or the > release notes to document it? I see the later points to the CLDR release > notes, but may

Re: RFR: 8284840: Update CLDR to Version 42.0

2022-10-21 Thread Joe Wang
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote: > This is to update the CLDR data from version 41 to version 42. The vast > majority of the changes are basically replacing the CLDR data, along with > tools/testcase alignments to those upstream changes: > > https://unicode-org.atlassian.net

Re: RFR: 8295554: Move the "sizecalc.h" to the correct location

2022-10-21 Thread Sergey Bylokhov
On Fri, 21 Oct 2022 10:18:26 GMT, Magnus Ihse Bursie wrote: > Can you please refrain from integrating this while I investigate while this > was originally moved? sure. - PR: https://git.openjdk.org/jdk/pull/10757

Re: RFR: 8284840: Update CLDR to Version 42.0

2022-10-21 Thread Iris Clark
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote: > This is to update the CLDR data from version 41 to version 42. The vast > majority of the changes are basically replacing the CLDR data, along with > tools/testcase alignments to those upstream changes: > > https://unicode-org.atlassian.net

Re: RFR: 8284840: Update CLDR to Version 42.0

2022-10-21 Thread Erik Joelsson
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote: > This is to update the CLDR data from version 41 to version 42. The vast > majority of the changes are basically replacing the CLDR data, along with > tools/testcase alignments to those upstream changes: > > https://unicode-org.atlassian.net

Re: RFR: 8295792: Clean up old async close code

2022-10-21 Thread Alan Bateman
On Fri, 21 Oct 2022 17:08:07 GMT, Daniel Jeliński wrote: >> src/java.base/unix/native/libnet/net_util_md.c line 703: >> >>> 701: >>> 702: errno = 0; >>> 703: read_rv = poll(&pfd, 1, nanoTimeout / NET_NSEC_PER_MSEC); >> >> I suspect this one will need to handle EINTR like the or

Re: RFR: 8295792: Clean up old async close code

2022-10-21 Thread Daniel Jeliński
On Fri, 21 Oct 2022 16:04:24 GMT, Alan Bateman wrote: >> Please review this PR that removes the remains of old fdTable-based socket >> close synchronization. >> >> Verified that tier1-3 tests continue to pass on Linux, MacOS and Windows. >> Did not verify AIX. >> >> Also removed one slow test

RFR: 8284840: Update CLDR to Version 42.0

2022-10-21 Thread Naoto Sato
This is to update the CLDR data from version 41 to version 42. The vast majority of the changes are basically replacing the CLDR data, along with tools/testcase alignments to those upstream changes: https://unicode-org.atlassian.net/browse/CLDR-14032 (" at " is no longer used for standard date/

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Andy Goryachev
On Fri, 21 Oct 2022 16:04:14 GMT, Naoto Sato wrote: > replace those dangling white spaces with explicit Unicode escapes this is a *very good* idea. - PR: https://git.openjdk.org/jdk/pull/10792

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Naoto Sato
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295792: Clean up old async close code

2022-10-21 Thread Alan Bateman
On Fri, 21 Oct 2022 14:28:02 GMT, Daniel Jeliński wrote: > Please review this PR that removes the remains of old fdTable-based socket > close synchronization. > > Verified that tier1-3 tests continue to pass on Linux, MacOS and Windows. Did > not verify AIX. > > Also removed one slow test for

RFR: 8295792: Clean up old async close code

2022-10-21 Thread Daniel Jeliński
Please review this PR that removes the remains of old fdTable-based socket close synchronization. Verified that tier1-3 tests continue to pass on Linux, MacOS and Windows. Did not verify AIX. Also removed one slow test for an issue in fdtable implementation; as far as I could tell, it is no lo

RFR: 8295795: hsdis does not build with binutils 2.39+

2022-10-21 Thread Aleksey Shipilev
Fails like this: $ sh ./configure --with-boot-jdk=jdk19u-ea --with-hsdis=binutils --with-binutils-src=binutils-2.39 $ make clean build-hsdis === Output from failing command(s) repeated here === * For target support_hsdis_hsdis-binutils.o: - Commit messages: - Fix Changes: https:

Re: RFR: 8295795: hsdis does not build with binutils 2.39+

2022-10-21 Thread Aleksey Shipilev
On Fri, 21 Oct 2022 15:26:59 GMT, Aleksey Shipilev wrote: > Fails like this: > > > $ sh ./configure --with-boot-jdk=jdk19u-ea --with-hsdis=binutils > --with-binutils-src=binutils-2.39 > $ make clean build-hsdis > > === Output from failing command(s) repeated here === > * For target support_hs

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Erik Joelsson
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295554: Move the "sizecalc.h" to the correct location

2022-10-21 Thread Magnus Ihse Bursie
On Wed, 19 Oct 2022 08:15:54 GMT, Sergey Bylokhov wrote: > The "sizecalc.h" file is moved out from java.desktop/share/native/include, > the files in that folder appear in the jdk bundle after installation like the > "jawt.h". Can you please refrain from integrating this while I investigate whi

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Magnus Ihse Bursie
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-21 Thread Andrew Haley
On Thu, 20 Oct 2022 20:26:47 GMT, Vladimir Ivanov wrote: > That sounds like a very interesting idea. > > It would be very helpful to get an understanding how much overhead `STMXCSR` > plus a branch adds in JNI stub to decide whether it's worth optimizing for. It's not just Intel's implementati

Integrated: 8295714: GHA ::set-output is deprecated and will be removed

2022-10-21 Thread Magnus Ihse Bursie
On Thu, 20 Oct 2022 10:00:14 GMT, Magnus Ihse Bursie wrote: > We need to transition to use the new `$GITHUB_OUTPUT` method instead. > > This needs to be fixed since it is currently spamming the summary with > warnings, and will stop working soon. This pull request has now been integrated. Ch

Re: RFR: 8295714: GHA ::set-output is deprecated and will be removed [v3]

2022-10-21 Thread Magnus Ihse Bursie
> We need to transition to use the new `$GITHUB_OUTPUT` method instead. > > This needs to be fixed since it is currently spamming the summary with > warnings, and will stop working soon. Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last rev

Re: RFR: 8295714: GHA ::set-output is deprecated and will be removed [v2]

2022-10-21 Thread Aleksey Shipilev
On Fri, 21 Oct 2022 07:39:49 GMT, Magnus Ihse Bursie wrote: >> We need to transition to use the new `$GITHUB_OUTPUT` method instead. >> >> This needs to be fixed since it is currently spamming the summary with >> warnings, and will stop working soon. > > Magnus Ihse Bursie has updated the pull

Re: RFR: 8295714: GHA ::set-output is deprecated and will be removed [v2]

2022-10-21 Thread Magnus Ihse Bursie
On Fri, 21 Oct 2022 07:39:49 GMT, Magnus Ihse Bursie wrote: >> We need to transition to use the new `$GITHUB_OUTPUT` method instead. >> >> This needs to be fixed since it is currently spamming the summary with >> warnings, and will stop working soon. > > Magnus Ihse Bursie has updated the pull

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v2]

2022-10-21 Thread Magnus Ihse Bursie
> Properties files is essentially source code. It should have the same > whitespace checks as all other source code, so we don't get spurious trailing > whitespace changes. > > With the new Skara jcheck, it is possible to increase the coverage of the > whitespace checks (in the old mercurial ve

Re: RFR: 8295714: GHA ::set-output is deprecated and will be removed

2022-10-21 Thread Aleksey Shipilev
On Fri, 21 Oct 2022 07:35:09 GMT, Magnus Ihse Bursie wrote: > My fixes were green, but all of the annoying log spam was not gone. After > some digging, it turned out that GitHub's own `download-artifact@v3` was not > clean, so I've upgraded it to `download-artifact@v3.0.1` which was released >

Re: RFR: 8287754: Update jib GNU make dependency on Windows to latest cygwin build

2022-10-21 Thread Daniel Jeliński
On Thu, 20 Oct 2022 21:49:41 GMT, Erik Joelsson wrote: > For Oracle internal builds we control the version of GNU Make (currently > fixed at 4.0). In Cygwin this is causing problems as the now rather dated GNU > Make binary we use isn't compatible with Cygwin.dll version 3.3 or later. To > wor

Re: RFR: 8295714: GHA ::set-output is deprecated and will be removed

2022-10-21 Thread Magnus Ihse Bursie
On Thu, 20 Oct 2022 10:00:14 GMT, Magnus Ihse Bursie wrote: > We need to transition to use the new `$GITHUB_OUTPUT` method instead. > > This needs to be fixed since it is currently spamming the summary with > warnings, and will stop working soon. My fixes were green, but all of the annoying l

Re: RFR: 8295714: GHA ::set-output is deprecated and will be removed [v2]

2022-10-21 Thread Magnus Ihse Bursie
> We need to transition to use the new `$GITHUB_OUTPUT` method instead. > > This needs to be fixed since it is currently spamming the summary with > warnings, and will stop working soon. Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last rev