On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Thu, 20 Oct 2022 21:49:41 GMT, Erik Joelsson wrote:
> For Oracle internal builds we control the version of GNU Make (currently
> fixed at 4.0). In Cygwin this is causing problems as the now rather dated GNU
> Make binary we use isn't compatible with Cygwin.dll version 3.3 or later. To
>
On Wed, 19 Oct 2022 08:15:54 GMT, Sergey Bylokhov wrote:
> The "sizecalc.h" file is moved out from java.desktop/share/native/include,
> the files in that folder appear in the jdk bundle after installation like the
> "jawt.h".
Thank you for waiting while we sorted out the details. This looks
On Thu, 20 Oct 2022 10:19:38 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in the security native libraries.
>
> Any warnings that
On Wed, 19 Oct 2022 13:57:59 GMT, Ludvig Janiuk wrote:
> Old one made little sense for a new reader
Good point; I didn't notice. We try to keep the line length of markdown files
below 79, if possible, so that they can be properly viewed on a 80-wide
viewport.
Many editors have a "reflow
> It would be possible to mark classes with `@sealedGraph` to indicate that the
> sealed hierarchy should be rendered graphically in the JavaDocs. Classes not
> marked would be unaffected, creating an opt-in approach.
>
>
On Mon, 24 Oct 2022 20:11:51 GMT, Magnus Ihse Bursie wrote:
>> make/jdk/src/classes/build/tools/taglet/SealedGraph.java line 49:
>>
>>> 47: public final class SealedGraph implements Taglet {
>>> 48: private static final String sealedGraphDotPath =
>>> 49:
On Mon, 24 Oct 2022 10:15:53 GMT, Alexey Ivanov wrote:
>> The "sizecalc.h" file is moved out from java.desktop/share/native/include,
>> the files in that folder appear in the jdk bundle after installation like
>> the "jawt.h".
>
> Marked as reviewed by aivanov (Reviewer).
@aivanov-jdk has
On Mon, 24 Oct 2022 19:39:21 GMT, Jonathan Gibbons wrote:
> I think it would be better to try and remove incidental trailing whitespace
> first, before encoding any remaining whitespace. Hiding the trailing
> whitespace as a Unicode escape seems like a bad idea, equivalent to sweeping
> the
On Mon, 24 Oct 2022 20:01:26 GMT, Magnus Ihse Bursie wrote:
> [JDK-8294466](https://bugs.openjdk.org/browse/JDK-8294466) trimmed down the
> set of disabled warnings. Unfortunately it turned out that running slowdebug
> on linux on Oracle's CI triggered yet another warning in libsplashscreen.
On Wed, 19 Oct 2022 13:57:59 GMT, Ludvig Janiuk wrote:
> Old one made little sense for a new reader
Could you tidy up the formatting of the markdown version? The line lengths are
rather uneven.
-
PR: https://git.openjdk.org/jdk/pull/10763
On Mon, 24 Oct 2022 20:06:58 GMT, Jonathan Gibbons wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix styleheet
>
> make/jdk/src/classes/build/tools/taglet/SealedGraph.java line 86:
>
>> 84:
>> 85:
> It would be possible to mark classes with `@sealedGraph` to indicate that the
> sealed hierarchy should be rendered graphically in the JavaDocs. Classes not
> marked would be unaffected, creating an opt-in approach.
>
>
On Mon, 24 Oct 2022 20:01:26 GMT, Magnus Ihse Bursie wrote:
> [JDK-8294466](https://bugs.openjdk.org/browse/JDK-8294466) trimmed down the
> set of disabled warnings. Unfortunately it turned out that running slowdebug
> on linux on Oracle's CI triggered yet another warning in libsplashscreen.
On Mon, 24 Oct 2022 20:01:26 GMT, Magnus Ihse Bursie wrote:
> [JDK-8294466](https://bugs.openjdk.org/browse/JDK-8294466) trimmed down the
> set of disabled warnings. Unfortunately it turned out that running slowdebug
> on linux on Oracle's CI triggered yet another warning in libsplashscreen.
On Mon, 24 Oct 2022 20:08:02 GMT, Andy Goryachev wrote:
> Good idea! I wonder if this should be done as a unit test. go through all the
> bundles and check leading/trailing whitespace.
Right. Definitely not a job for `jcheck`, but it should be considered somewhere
in the l10n process.
On Mon, 24 Oct 2022 20:05:51 GMT, Jonathan Gibbons wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix styleheet
>
> make/jdk/src/classes/build/tools/taglet/SealedGraph.java line 49:
>
>> 47: public final
On Wed, 19 Oct 2022 08:15:54 GMT, Sergey Bylokhov wrote:
> The "sizecalc.h" file is moved out from java.desktop/share/native/include,
> the files in that folder appear in the jdk bundle after installation like the
> "jawt.h".
I suggest to disable that test, if it builds during the jdk build
On Mon, 24 Oct 2022 19:58:31 GMT, Naoto Sato wrote:
> I think what we can do is check the original English properties values that
> the engineers provided, and if there is no trailing spaces there, we can
> safely remove trailing spaces in localized bundles.
Good idea! I wonder if this should
[JDK-8294466](https://bugs.openjdk.org/browse/JDK-8294466) trimmed down the set
of disabled warnings. Unfortunately it turned out that running slowdebug on
linux on Oracle's CI triggered yet another warning in libsplashscreen.
-
Commit messages:
- 8295847: slow debug build error
On Thu, 20 Oct 2022 21:49:41 GMT, Erik Joelsson wrote:
> For Oracle internal builds we control the version of GNU Make (currently
> fixed at 4.0). In Cygwin this is causing problems as the now rather dated GNU
> Make binary we use isn't compatible with Cygwin.dll version 3.3 or later. To
>
On Wed, 19 Oct 2022 13:57:59 GMT, Ludvig Janiuk wrote:
> Old one made little sense for a new reader
Looks good. Thank you!
-
Marked as reviewed by ihse (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10763
On Thu, 20 Oct 2022 11:13:18 GMT, Magnus Ihse Bursie wrote:
>> It would be possible to mark classes with `@sealedGraph` to indicate that
>> the sealed hierarchy should be rendered graphically in the JavaDocs. Classes
>> not marked would be unaffected, creating an opt-in approach.
>>
>>
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Thu, 20 Oct 2022 11:13:18 GMT, Magnus Ihse Bursie wrote:
>> It would be possible to mark classes with `@sealedGraph` to indicate that
>> the sealed hierarchy should be rendered graphically in the JavaDocs. Classes
>> not marked would be unaffected, creating an opt-in approach.
>>
>>
On Thu, 20 Oct 2022 11:13:18 GMT, Magnus Ihse Bursie wrote:
>> It would be possible to mark classes with `@sealedGraph` to indicate that
>> the sealed hierarchy should be rendered graphically in the JavaDocs. Classes
>> not marked would be unaffected, creating an opt-in approach.
>>
>>
On Mon, 24 Oct 2022 19:23:04 GMT, Andy Goryachev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Revert "Remove check for .properties from jcheck"
>>
>>This reverts commit
On Mon, 24 Oct 2022 19:34:56 GMT, Magnus Ihse Bursie wrote:
> For the files which have trailing "whitespace" (now as unicode sequences), I
> will file follow-up bugs on the respective components to verify if this is
> indeed correct, or a bug that should be fixed.
probably not needed - if
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Mon, 24 Oct 2022 19:20:24 GMT, Andy Goryachev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Remove check for .properties from jcheck
>> - Restore trailing whitespace for property values
>
> 368 files
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the coverage of the
> whitespace checks (in the old mercurial
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote:
> This is to update the CLDR data from version 41 to version 42. The vast
> majority of the changes are basically replacing the CLDR data, along with
> tools/testcase alignments to those upstream changes:
>
>
On Fri, 21 Oct 2022 14:28:02 GMT, Daniel Jeliński wrote:
> Please review this PR that removes the remains of old fdTable-based socket
> close synchronization.
>
> Verified that tier1-3 tests continue to pass on Linux, MacOS and Windows. Did
> not verify AIX.
>
> Also removed one slow test
On Wed, 19 Oct 2022 08:15:54 GMT, Sergey Bylokhov wrote:
> The "sizecalc.h" file is moved out from java.desktop/share/native/include,
> the files in that folder appear in the jdk bundle after installation like the
> "jawt.h".
Marked as reviewed by aivanov (Reviewer).
-
PR:
On Thu, 20 Oct 2022 10:24:28 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in the accessibility native code.
>
> Any warnings that
On Sun, 23 Oct 2022 00:37:55 GMT, Phil Race wrote:
> > > Can you please refrain from integrating this while I investigate while
> > > this was originally moved?
> >
> >
> > sure.
>
> It was moved because it was designed for use by AWT and SOMEHOW during all
> the reshuffle for the modular
On Thu, 20 Oct 2022 10:36:08 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in java.desktop native libraries.
>
> Any warnings that
On Sun, 23 Oct 2022 01:22:33 GMT, Phil Race wrote:
> Superficially, it looks like the closed test has a direct pointer to where to
> get this which would need to be re-adjusted
The test has direct link to the include yet i had to add this line so jtreg
could find it in the build phase. The
On Wed, 19 Oct 2022 08:15:54 GMT, Sergey Bylokhov wrote:
> The "sizecalc.h" file is moved out from java.desktop/share/native/include,
> the files in that folder appear in the jdk bundle after installation like the
> "jawt.h".
Marked as reviewed by kizune (Reviewer).
-
PR:
43 matches
Mail list logo
