On Mon, 14 Nov 2022 15:45:50 GMT, Julian Waters wrote:
> I know Skara, I'm deliberately holding off from integrating this for now...
Why is that?
-
PR: https://git.openjdk.org/jdk/pull/10634
On Tue, 15 Nov 2022 00:49:59 GMT, Julian Waters wrote:
>> make/hotspot/lib/CompileJvm.gmk line 67:
>>
>>> 65: # Hotspot cannot handle an empty build number
>>> 66: VERSION_BUILD := 0
>>> 67: endif
>>
>> I think the proposed "solution" is *much* worse than this.
>
> Reverted to use the
On Mon, 14 Nov 2022 08:02:49 GMT, David Holmes wrote:
>> Yep, it was renamed since the file is also named VISCPP, and I felt that
>> matching the names was a good style change
>
> I think it is the file that has the "bad" name in this case. :( But okay.
I also think the macro name should be
On Mon, 14 Nov 2022 16:12:48 GMT, Julian Waters wrote:
>> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and
>> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++
>> code across the JDK can be replaced and simplified with cleaner language
>> features
Hi all,
Could anyone review this cleanup to remove dead symbol
"sysThreadAvailableStackWithSlack"? See
https://bugs.openjdk.org/browse/JDK-8296970 for more details.
-Man
-
Commit messages:
- 8296970: Remove sysThreadAvailableStackWithSlack from hotspot-symbols
Changes:
On Mon, 14 Nov 2022 13:08:56 GMT, Kim Barrett wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert to using simpler solution similar to the original 8274980
>
> make/hotspot/lib/CompileJvm.gmk line 67:
>
>>
On Mon, 14 Nov 2022 09:25:11 GMT, Stefan Karlsson wrote:
> One of the more prevalent issues is that files in src/hotspot/share/include
> are not properly sorted. There has been some discussion that that was done on
> purpose, but it just adds another exception to the include rules that don't
On Mon, 14 Nov 2022 09:25:11 GMT, Stefan Karlsson wrote:
> One of the more prevalent issues is that files in src/hotspot/share/include
> are not properly sorted. There has been some discussion that that was done on
> purpose, but it just adds another exception to the include rules that don't
> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and
> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++
> code across the JDK can be replaced and simplified with cleaner language
> features that were previously not available due to required
On Mon, 10 Oct 2022 15:29:16 GMT, Julian Waters wrote:
>> Several parts of the make system in the JDK has large parts of cluttered if
>> branches dedicated to setting flags for the specific compiler used in the
>> build. This could be more neatly accomplished by instead adding more target
>>
On Mon, 14 Nov 2022 01:42:40 GMT, Julian Waters wrote:
>> make/autoconf/flags-cflags.m4 line 632:
>>
>>> 630: if test "x$TOOLCHAIN_TYPE" = xgcc || test "x$TOOLCHAIN_TYPE" =
>>> xclang; then
>>> 631: STATIC_LIBS_CFLAGS="$STATIC_LIBS_CFLAGS -ffunction-sections
>>> -fdata-sections \
>>>
On Mon, 14 Nov 2022 04:14:24 GMT, Julian Waters wrote:
>> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and
>> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++
>> code across the JDK can be replaced and simplified with cleaner language
>> features
On Mon, 14 Nov 2022 09:25:11 GMT, Stefan Karlsson wrote:
> One of the more prevalent issues is that files in src/hotspot/share/include
> are not properly sorted. There has been some discussion that that was done on
> purpose, but it just adds another exception to the include rules that don't
On Mon, 14 Nov 2022 08:01:27 GMT, David Holmes wrote:
>> I'm not sure I follow, I didn't remove anything here?
>
> Sorry my eyes must be playing tricks on me. ??
>
> Why did you need to add this here?
It's to avoid redefining the linkage as static in os_windows.cpp (where it's
implemented)
On Mon, 14 Nov 2022 09:25:11 GMT, Stefan Karlsson wrote:
> One of the more prevalent issues is that files in src/hotspot/share/include
> are not properly sorted. There has been some discussion that that was done on
> purpose, but it just adds another exception to the include rules that don't
On Mon, 14 Nov 2022 08:08:40 GMT, David Holmes wrote:
>> The ATTRIBUTE_PRINTF macros are still there, just moved in front of the
>> methods
>
> Wow I'm really having eyesight problems today! Sorry about that.
Haha, no worries
-
PR: https://git.openjdk.org/jdk/pull/11081
On Fri, 11 Nov 2022 21:21:43 GMT, Kim Barrett wrote:
>> The sorted blocks of includes have deteriorated to the point that I felt
>> compelled to clean up some of the issues.
>>
>> One of the more prevalent issues is that files in src/hotspot/share/include
>> are not properly sorted. There has
On Mon, 14 Nov 2022 08:28:04 GMT, Thomas Stuefe wrote:
> unfortunately, your patch will make backporting more difficult. We cannot
> downport it to older releases compiled with older compilers. But since it
> touches a lot of files it will sit smack in the middle of patch sequences,
>
One of the more prevalent issues is that files in src/hotspot/share/include are
not properly sorted. There has been some discussion that that was done on
purpose, but it just adds another exception to the include rules that don't
have any practical purposes, IMHO. It also goes against our
On Fri, 11 Nov 2022 14:26:20 GMT, Stefan Karlsson wrote:
> The sorted blocks of includes have deteriorated to the point that I felt
> compelled to clean up some of the issues.
>
> One of the more prevalent issues is that files in src/hotspot/share/include
> are not properly sorted. There has
On Mon, 14 Nov 2022 04:14:24 GMT, Julian Waters wrote:
>> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and
>> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++
>> code across the JDK can be replaced and simplified with cleaner language
>> features
On Mon, 14 Nov 2022 01:39:17 GMT, Julian Waters wrote:
>> src/hotspot/share/utilities/debug.hpp line 172:
>>
>>> 170: int status, const char* detail);
>>> 171: ATTRIBUTE_PRINTF(4, 5)
>>> 172: void report_fatal(VMErrorType error_type, const char* file, int line,
>>>
On Mon, 14 Nov 2022 01:17:38 GMT, Julian Waters wrote:
>> src/hotspot/os/windows/os_windows.hpp line 35:
>>
>>> 33: class Thread;
>>> 34:
>>> 35: static unsigned __stdcall thread_native_entry(Thread*);
>>
>> Why was this removed? This is needed to correctly specify the call sequence
>> for
On Fri, 11 Nov 2022 14:26:20 GMT, Stefan Karlsson wrote:
> The sorted blocks of includes have deteriorated to the point that I felt
> compelled to clean up some of the issues.
>
> One of the more prevalent issues is that files in src/hotspot/share/include
> are not properly sorted. There has
24 matches
Mail list logo
