Re: RFR: 8295884: Implement IDE support for Eclipse [v21]

2022-11-23 Thread Julian Waters
> Eclipse is a popular and very well-known IDE in the world of Java > development, utilized widely in many contexts, by beginners and experienced > teams alike. Although a relatively lightweight IDE, it features surprisingly > powerful indexing and code analysis capabilities, as well as useful t

Re: RFR: 8295146: Clean up native code with newer C/C++ language features [v3]

2022-11-23 Thread Kim Barrett
On Wed, 23 Nov 2022 05:22:10 GMT, Kim Barrett wrote: >> It's to avoid redefining the linkage as static in os_windows.cpp (where it's >> implemented) after an extern declaration (inside the class), which is >> forbidden by C++11: >> >>> The linkages implied by successive declarations for a give

Integrated: JDK-8297000 [jib] Add more friendly warning for proxy issues

2022-11-23 Thread Ludvig Janiuk
On Tue, 15 Nov 2022 09:55:38 GMT, Ludvig Janiuk wrote: > When jib tries to download itself behind a proxy, sometimes it can get a > different file than it expected. This can result in cryptic errors that are > hard to troubleshoot. Let's handle this a little more gracefully by detecting > it i

Re: RFR: 8295884: Implement IDE support for Eclipse [v20]

2022-11-23 Thread Julian Waters
> Eclipse is a popular and very well-known IDE in the world of Java > development, utilized widely in many contexts, by beginners and experienced > teams alike. Although a relatively lightweight IDE, it features surprisingly > powerful indexing and code analysis capabilities, as well as useful t

Re: RFR: 8295884: Implement IDE support for Eclipse [v19]

2022-11-23 Thread Julian Waters
> Eclipse is a popular and very well-known IDE in the world of Java > development, utilized widely in many contexts, by beginners and experienced > teams alike. Although a relatively lightweight IDE, it features surprisingly > powerful indexing and code analysis capabilities, as well as useful t

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v6]

2022-11-23 Thread Julian Waters
> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available > when both 8282948 and 8282700 were written. They can now be moved to using > the cleaner logic that UTIL_ARG_WITH grants. > > There are many more options that still use AC_ARG_WITH in jdk-version.m4. > They are out

Re: RFR: JDK-8297000 [jib] Add more friendly warning for proxy issues [v3]

2022-11-23 Thread Erik Joelsson
On Wed, 23 Nov 2022 12:13:32 GMT, Ludvig Janiuk wrote: >> When jib tries to download itself behind a proxy, sometimes it can get a >> different file than it expected. This can result in cryptic errors that are >> hard to troubleshoot. Let's handle this a little more gracefully by >> detecting

Re: RFR: JDK-8297000 [jib] Add more friendly warning for proxy issues [v3]

2022-11-23 Thread Magnus Ihse Bursie
On Wed, 23 Nov 2022 12:13:32 GMT, Ludvig Janiuk wrote: >> When jib tries to download itself behind a proxy, sometimes it can get a >> different file than it expected. This can result in cryptic errors that are >> hard to troubleshoot. Let's handle this a little more gracefully by >> detecting

Re: RFR: JDK-8297000 [jib] Add more friendly warning for proxy issues [v3]

2022-11-23 Thread Ludvig Janiuk
On Wed, 16 Nov 2022 19:59:35 GMT, Magnus Ihse Bursie wrote: >> bin/jib.sh line 137: >> >>> 135: FILEOUTPUT=`file ${installed_jib_script}.gz` >>> 136: # ${X:${#Y}} gives X without the first ${#Y} characters, and ${#Y} >>> is length of Y. >>> 137: FILEOUTPUT=${FILEOUTPUT:${#PREFIX}} >

Re: RFR: JDK-8297000 [jib] Add more friendly warning for proxy issues [v3]

2022-11-23 Thread Ludvig Janiuk
> When jib tries to download itself behind a proxy, sometimes it can get a > different file than it expected. This can result in cryptic errors that are > hard to troubleshoot. Let's handle this a little more gracefully by detecting > it in the bootstrapper and printing an error. Ludvig Janiuk

Re: RFR: JDK-8297000 [jib] Add more friendly warning for proxy issues [v2]

2022-11-23 Thread Ludvig Janiuk
> When jib tries to download itself behind a proxy, sometimes it can get a > different file than it expected. This can result in cryptic errors that are > hard to troubleshoot. Let's handle this a little more gracefully by detecting > it in the bootstrapper and printing an error. Ludvig Janiuk

RFR: 8252584: HotSpot Style Guide should permit alignas

2022-11-23 Thread Julian Waters
Add alignas to the permitted features set. Though the corresponding entry mentions this should not be done for classes, there's no actual difference in practice with all our supported compilers, because their nonstandard syntax also has the same limitations and issues with dynamic allocation as

Re: RFR: 8297444: Refactor the javacserver build tool [v2]

2022-11-23 Thread Christian Stein
On Tue, 22 Nov 2022 23:40:30 GMT, Magnus Ihse Bursie wrote: >> Now that the javacserver no longer has any ambitions outside being a >> buildtool customized for the JDK build process, a lot of abstractions and >> generalizations can be removed. >> >> This will allow the actual behavior to be mo