Re: RFR: 8297606: [AIX] Broken build after JDK-8295475 [v3]

2022-12-05 Thread David Holmes
Directly cc'ing build-dev. Once this became a build-only fix the build team should have been included just so they are aware of the change. Cheers, David On 6/12/2022 12:52 am, Tyler Steele wrote: On Fri, 2 Dec 2022 17:43:46 GMT, Tyler Steele wrote: Recent changes (https://github.com/openjd

Re: RFR: JDK-8298035: Provide better descriptions for JIT compiler JFR events

2022-12-05 Thread Erik Gahlin
On Mon, 5 Dec 2022 09:11:15 GMT, Matthias Baesken wrote: > Most Compiler related JFR events lack descriptions, see > https://sap.github.io/SapMachine/jfrevents/20.html#jvm-compiler > > We should add some helpful description texts for these JFR events. When it comes to descriptions, we have trie

Re: RFR: 8297963: Partially fix string expansion issues in UTIL_DEFUN_NAMED and related macros [v7]

2022-12-05 Thread Magnus Ihse Bursie
On Mon, 5 Dec 2022 09:40:37 GMT, Julian Waters wrote: >> The UTIL macros have several problematic flaws that may not seem apparent >> initially, the worst of which include parsing commas as actual argument >> separators to the underlying m4 macros, and completely, but very subtly >> wrecking s

Re: RFR: 8297963: Partially fix string expansion issues in UTIL_DEFUN_NAMED and related macros [v3]

2022-12-05 Thread Magnus Ihse Bursie
On Sat, 3 Dec 2022 11:32:36 GMT, Julian Waters wrote: > Out of curiosity, was the quoting of ARG_PREFIX and other ARG_ macros when > passing them as arguments to other macros implemented with UTIL_DEFUN_NAMED > an unwanted workaround to stop them from expanding before this change? Most likely.

Re: RFR: JDK-8296149: Start of release updates for JDK 21 [v3]

2022-12-05 Thread Jan Lahoda
On Sat, 3 Dec 2022 23:10:48 GMT, Joe Darcy wrote: >> Usual start-of-release updates. Symbol updates in initial version reflect >> JDK 20 build 21. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated change

Re: RFR: JDK-8296360: Track native memory used by zlib via NMT

2022-12-05 Thread Alan Bateman
On Fri, 4 Nov 2022 14:35:00 GMT, Thomas Stuefe wrote: > This patch adds NMT tracking to the zlib. > > *Please note: we currently discuss whether NMT can be expanded across the JDK > in this ML discussion [1]. This PR depends on the outcome of that discussion > and won't proceed unless greenlig

RFR: JDK-8296360: Track native memory used by zlib via NMT

2022-12-05 Thread Thomas Stuefe
This patch adds NMT tracking to the zlib. *Please note: we currently discuss whether NMT can be expanded across the JDK in this ML discussion [1]. This PR depends on the outcome of that discussion and won't proceed unless greenlighted. But since [1] is stalled, I post the PR for RFR to get some

Re: RFR: 8297963: Partially fix string expansion issues in UTIL_DEFUN_NAMED and related macros [v7]

2022-12-05 Thread Julian Waters
> The UTIL macros have several problematic flaws that may not seem apparent > initially, the worst of which include parsing commas as actual argument > separators to the underlying m4 macros, and completely, but very subtly > wrecking shell constructs. I've done my best here to fix some of these

RFR: JDK-8298035: Provide better descriptions for JIT compiler JFR events

2022-12-05 Thread Matthias Baesken
Most Compiler related JFR events lack descriptions, see https://sap.github.io/SapMachine/jfrevents/20.html#jvm-compiler We should add some helpful description texts for these JFR events. - Commit messages: - JDK-8298035 Changes: https://git.openjdk.org/jdk/pull/11506/files Webrev: