Re: RFR: JDK-8298908: Instrument Metaspace for ASan [v2]

2023-01-03 Thread David Holmes
On Sat, 17 Dec 2022 06:48:13 GMT, Justin King wrote: >> This change instruments Metaspace for ASan. Metaspace allocates memory using >> `mmap`/`munmap` which ASan is not aware of. Fortunately ASan supports >> applications [manually poisoning/unpoisoning >>

Re: RFR: 8294403: [REDO] make test should report only on executed tests

2023-01-03 Thread Jaikiran Pai
On Tue, 3 Jan 2023 09:39:59 GMT, Aleksey Shipilev wrote: > This should help to speed up tests significantly. Currently, if we run "make > test" with a subset of tests, JTReg would still read the entirety of test > root to report on tests that were not run. Even with current suite of tests >

Re: RFR: 8294403: [REDO] make test should report only on executed tests

2023-01-03 Thread David Holmes
On Tue, 3 Jan 2023 09:39:59 GMT, Aleksey Shipilev wrote: > This should help to speed up tests significantly. Currently, if we run "make > test" with a subset of tests, JTReg would still read the entirety of test > root to report on tests that were not run. Even with current suite of tests >

[jdk20] Integrated: 8298324: Unable to run shell test with make

2023-01-03 Thread Erik Joelsson
On Thu, 8 Dec 2022 20:38:59 GMT, Erik Joelsson wrote: > The parsing of the TestID in the TEST parameter currently only handles tests > that are .java files. Jtreg tests can also be .html and .sh files. This patch > extends the macro to also handle these kinds of files. > > Without the patch,

Re: [jdk20] RFR: 8298324: Unable to run shell test with make

2023-01-03 Thread David Holmes
On Thu, 8 Dec 2022 20:38:59 GMT, Erik Joelsson wrote: > The parsing of the TestID in the TEST parameter currently only handles tests > that are .java files. Jtreg tests can also be .html and .sh files. This patch > extends the macro to also handle these kinds of files. > > Without the patch,

Re: RFR: 8294403: [REDO] make test should report only on executed tests

2023-01-03 Thread Erik Joelsson
On Tue, 3 Jan 2023 09:39:59 GMT, Aleksey Shipilev wrote: > This should help to speed up tests significantly. Currently, if we run "make > test" with a subset of tests, JTReg would still read the entirety of test > root to report on tests that were not run. Even with current suite of tests >

Re: RFR: 8294403: [REDO] make test should report only on executed tests

2023-01-03 Thread Aleksey Shipilev
On Tue, 3 Jan 2023 09:39:59 GMT, Aleksey Shipilev wrote: > This should help to speed up tests significantly. Currently, if we run "make > test" with a subset of tests, JTReg would still read the entirety of test > root to report on tests that were not run. Even with current suite of tests >

Re: RFR: 8299330: Workflows should not install MSYS2 in the JDK's source directory [v7]

2023-01-03 Thread Julian Waters
On Tue, 3 Jan 2023 10:09:26 GMT, Aleksey Shipilev wrote: > I don't quite understand what is the issue here. We do drop quite a bit of > things in the OpenJDK root: bootjdk, gtest, jtreg, etc. How is msys2 > different here? Unlike the compiled JDK and those other utilities MSYS2 happens to be

Re: RFR: 8299330: Workflows should not install MSYS2 in the JDK's source directory [v9]

2023-01-03 Thread Julian Waters
> MSYS2 should be more appropriately installed into the runner's temporary > directory rather than inside the newly checked out repository containing all > the JDK's source code, as doing so may interfere with the build process and > cause weird corner cases in the submitted actions workflow

Re: RFR: 8299330: Workflows should not install MSYS2 in the JDK's source directory [v7]

2023-01-03 Thread Aleksey Shipilev
On Wed, 28 Dec 2022 16:12:06 GMT, Julian Waters wrote: >> MSYS2 should be more appropriately installed into the runner's temporary >> directory rather than inside the newly checked out repository containing all >> the JDK's source code, as doing so may interfere with the build process and >>