Re: RFR: 8300169: Build failure with clang-15

2023-01-16 Thread Jie Fu
On Tue, 17 Jan 2023 04:29:31 GMT, David Holmes wrote: > Hotspot changes are good. Thanks @dholmes-ora . - PR: https://git.openjdk.org/jdk/pull/12005

Re: RFR: JDK-8300068: UBSan CFLAGS/LDFLAGS not passed when building ADLC

2023-01-16 Thread David Holmes
On Thu, 12 Jan 2023 18:30:12 GMT, Justin King wrote: > Fix misconfigured UBSan build by funneling `UBSAN_CFLAGS` and `UBSAN_LDFLAGS` > to ADLC. ADLC is just a build tool. There is no reason for it to need the hotspot build flags. - PR: https://git.openjdk.org/jdk/pull/11975

Re: RFR: 8300169: Build failure with clang-15

2023-01-16 Thread David Holmes
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote: > Hi all, > > Please review the fix for the build failure with clang-15. > > 1. -Wbitwise-instead-of-logical > >1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the > warning >2) src/hotspot/share/runtime/notificationThre

Re: RFR: 8300120: Configure should support different defaults for CI/dev build environments

2023-01-16 Thread David Holmes
On Fri, 13 Jan 2023 15:42:36 GMT, Magnus Ihse Bursie wrote: > There are several configure settings that should have different default > values depending on if configure is run as part of a CI build, or a local > developer. This change only seems to deal with the jtreg failure handler, are ther

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v11]

2023-01-16 Thread Archie L . Cobbs
> This PR adds a new lint warning category `this-escape`. > > It also adds `@SuppressWarnings` annotations as needed to the JDK itself to > allow the JDK to continue to compile with `-Xlint:all`. > > A 'this' escape warning is generated for a constructor `A()` in a class `A` > when the compiler

Integrated: 8298047: Remove all non-significant trailing whitespace from properties files

2023-01-16 Thread Magnus Ihse Bursie
On Fri, 2 Dec 2022 17:06:23 GMT, Magnus Ihse Bursie wrote: > [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729) was created in an > attempt to remove all trailing whitespace from properties files, and enable a > jcheck verification that they did not come back, similar to other source >

Re: RFR: 8298047: Remove all non-significant trailing whitespace from properties files [v2]

2023-01-16 Thread Magnus Ihse Bursie
On Mon, 16 Jan 2023 17:22:36 GMT, Roger Riggs wrote: >> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master' into properties-eol-clean-safe >> - 8298047: Remove all non-si

Re: RFR: 8298047: Remove all non-significant trailing whitespace from properties files [v2]

2023-01-16 Thread Roger Riggs
On Mon, 16 Jan 2023 16:50:06 GMT, Magnus Ihse Bursie wrote: >> [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729) was created in an >> attempt to remove all trailing whitespace from properties files, and enable >> a jcheck verification that they did not come back, similar to other sourc

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v9]

2023-01-16 Thread Maurizio Cimadamore
On Mon, 16 Jan 2023 16:29:31 GMT, Archie L. Cobbs wrote: > It looks like you might be counting the "here via invocation" lines as > separate warnings. These are really part of the previous `possible 'this' > escape` line, e.g.: yes, I really did the simplest possible thing (e.g. just counting

Re: RFR: JDK-8300069: Left shift of negative value in share/adlc/dict2.cpp [v4]

2023-01-16 Thread Magnus Ihse Bursie
On Fri, 13 Jan 2023 16:01:55 GMT, Justin King wrote: >> Refactor `hashstr` to use unsigned integrals to avoid undefined behavior. > > Justin King has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains four commits: > > - Resolve conflict

Re: RFR: 8298047: Remove all non-significant trailing whitespace from properties files

2023-01-16 Thread Magnus Ihse Bursie
On Fri, 2 Dec 2022 17:06:23 GMT, Magnus Ihse Bursie wrote: > [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729) was created in an > attempt to remove all trailing whitespace from properties files, and enable a > jcheck verification that they did not come back, similar to other source >

Re: RFR: 8298047: Remove all non-significant trailing whitespace from properties files [v2]

2023-01-16 Thread Magnus Ihse Bursie
> [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729) was created in an > attempt to remove all trailing whitespace from properties files, and enable a > jcheck verification that they did not come back, similar to other source > code. It turned out that this was not so simple, however, si

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v9]

2023-01-16 Thread Archie L . Cobbs
On Mon, 16 Jan 2023 12:51:49 GMT, Maurizio Cimadamore wrote: >> The number of times around any single loop is bounded by the number of new >> references that can possibly be created during the analysis of that loop. >> >> That number is at most 2 * (1 + 1 + 1 + 1 + N) where N is the number of

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v10]

2023-01-16 Thread Archie L . Cobbs
On Mon, 16 Jan 2023 11:53:40 GMT, Maurizio Cimadamore wrote: >> Archie L. Cobbs has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fix bug where field initializer warnings could be incorrectly suppressed. >> - Consolidate all the unit t

Re: RFR: 8146132: Excessive output from make test-image [v2]

2023-01-16 Thread Coleen Phillimore
On Thu, 12 Jan 2023 18:01:50 GMT, Coleen Phillimore wrote: >> This change makes native output files be only printed when building with >> LOG=info, to make the build not have so many pages of output. >> Tested with GHA and locally (tbd) > > Coleen Phillimore has updated the pull request incremen

Withdrawn: 8146132: Excessive output from make test-image

2023-01-16 Thread Coleen Phillimore
On Tue, 10 Jan 2023 20:48:55 GMT, Coleen Phillimore wrote: > This change makes native output files be only printed when building with > LOG=info, to make the build not have so many pages of output. > Tested with GHA and locally (tbd) This pull request has been closed without being integrated.

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v9]

2023-01-16 Thread Maurizio Cimadamore
On Fri, 13 Jan 2023 21:28:51 GMT, Archie L. Cobbs wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java >> line 1088: >> >>> 1086: private void visitLooped(T tree, Consumer >>> visitor) { >>> 1087: visitScoped(tree, false, t -> { >>> 1088:

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v10]

2023-01-16 Thread Maurizio Cimadamore
On Fri, 13 Jan 2023 22:48:59 GMT, Archie L. Cobbs wrote: >> This PR adds a new lint warning category `this-escape`. >> >> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to >> allow the JDK to continue to compile with `-Xlint:all`. >> >> A 'this' escape warning is gene

Re: RFR: 8297851: Add devkit for RISC-V

2023-01-16 Thread Magnus Ihse Bursie
On Wed, 30 Nov 2022 14:03:30 GMT, Magnus Ihse Bursie wrote: > We should add devkit support for linux/riscv64. Bot, gimme some slack. - PR: https://git.openjdk.org/jdk/pull/11432

Re: RFR: 8300169: Build failure with clang-15

2023-01-16 Thread Alan Bateman
On Mon, 16 Jan 2023 08:56:13 GMT, Jie Fu wrote: > Mainly caused by files under `src/java.base/share/native/libzip/zlib/`. I'm > not sure if there is already a bug report to the upstream. Maybe this one: https://github.com/madler/zlib/issues/633 - PR: https://git.openjdk.org/jdk/pu

Re: RFR: 8300169: Build failure with clang-15

2023-01-16 Thread Jie Fu
On Mon, 16 Jan 2023 08:51:34 GMT, Jie Fu wrote: > For the libzip issues, are these in the native methods or when compiling the > zlib code, just wondering if there are bug reports for upstream there too. Mainly caused by files under `src/java.base/share/native/libzip/zlib/`. I'm not sure if the

Re: RFR: 8300169: Build failure with clang-15

2023-01-16 Thread Jie Fu
On Mon, 16 Jan 2023 08:21:47 GMT, Alan Bateman wrote: > Is there a list of the issues building libjli? I don't see the in the PR or > the JBS issue. For the libzip issues, are these in the native methods or when > compiling the zlib code, just wondering if there are bug reports for upstream >

Re: RFR: 8300169: Build failure with clang-15

2023-01-16 Thread Alan Bateman
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote: > It occurred while building LIBJLI, LIBZIP and LIBSPLASHSCREEN. Is there a list of the issues building libjli? I don't see the in the PR or the JBS issue. For the libzip issues, are these in the native methods or when compiling the zlib code, ju