Re: [jdk20] RFR: 8300490: Spaces in name of MacOS Code Signing Identity are not correctly handled after JDK-8293550

2023-01-18 Thread Christoph Langer
On Wed, 18 Jan 2023 14:26:01 GMT, Erik Joelsson wrote: >> This fixes an issue when the MacOS codesign identity contains spaces. For >> that case, quoted arguments are not correctly handled in current code. We >> need to pass doublequotes literally in the argument parameter and then have >>

[jdk20] Integrated: 8300490: Spaces in name of MacOS Code Signing Identity are not correctly handled after JDK-8293550

2023-01-18 Thread Christoph Langer
On Wed, 18 Jan 2023 11:09:21 GMT, Christoph Langer wrote: > This fixes an issue when the MacOS codesign identity contains spaces. For > that case, quoted arguments are not correctly handled in current code. We > need to pass doublequotes literally in the argument parameter and then have >

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v14]

2023-01-18 Thread Archie L . Cobbs
> This PR adds a new lint warning category `this-escape`. > > It also adds `@SuppressWarnings` annotations as needed to the JDK itself to > allow the JDK to continue to compile with `-Xlint:all`. > > A 'this' escape warning is generated for a constructor `A()` in a class `A` > when the

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v13]

2023-01-18 Thread Archie L . Cobbs
On Tue, 17 Jan 2023 23:59:04 GMT, Archie L. Cobbs wrote: >> This PR adds a new lint warning category `this-escape`. >> >> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to >> allow the JDK to continue to compile with `-Xlint:all`. >> >> A 'this' escape warning is

RFR: JDK-8300592: ASan build does not correctly propagate options to some test launchers

2023-01-18 Thread Justin King
Update some custom launchers to set the default ASan options, without it the tests fail due to incompatibility with LSan. Additionally adds `-fno-common` for ASan build, as suggested by the docs. - Commit messages: - Fix ASan build for custom test launchers Changes:

Integrated: 8300550: BASIC_JVM_LIBS is set for buildjdk even if this is incorrect

2023-01-18 Thread Magnus Ihse Bursie
On Wed, 18 Jan 2023 16:13:25 GMT, Magnus Ihse Bursie wrote: > We setup a bunch of default library (`-l`) flags for the JVM compilation > in the variable BASIC_JVM_LIBS in LIB_SETUP_LIBRARIES. Almost all of these > are dependent on OS, and are thus safe to use both the the target and build >

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions [v10]

2023-01-18 Thread Matias Saavedra Silva
> This is an enhancement of the test case in > [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests > against an archive created by the "boot JDK", which is usually set as the > previous official JDK release when building the JDK repo. > > If it's able to acquire previous

Re: RFR: 8300550: BASIC_JVM_LIBS is set for buildjdk even if this is incorrect

2023-01-18 Thread Erik Joelsson
On Wed, 18 Jan 2023 16:13:25 GMT, Magnus Ihse Bursie wrote: > We setup a bunch of default library (`-l`) flags for the JVM compilation > in the variable BASIC_JVM_LIBS in LIB_SETUP_LIBRARIES. Almost all of these > are dependent on OS, and are thus safe to use both the the target and build >

RFR: 8300550: BASIC_JVM_LIBS is set for buildjdk even if this is incorrect

2023-01-18 Thread Magnus Ihse Bursie
We setup a bunch of default library (`-l`) flags for the JVM compilation in the variable BASIC_JVM_LIBS in LIB_SETUP_LIBRARIES. Almost all of these are dependent on OS, and are thus safe to use both the the target and build compilation (since we do not support cross-OS compilation). However,

Integrated: 8297851: Add devkit for RISC-V

2023-01-18 Thread Magnus Ihse Bursie
On Wed, 30 Nov 2022 14:03:30 GMT, Magnus Ihse Bursie wrote: > We should add devkit support for linux/riscv64. This pull request has now been integrated. Changeset: c205caea Author:Magnus Ihse Bursie URL: https://git.openjdk.org/jdk/commit/c205caead557aea92e319c85d0e974ca7b4830e1

Re: RFR: 8297851: Add devkit for RISC-V [v3]

2023-01-18 Thread Magnus Ihse Bursie
On Wed, 18 Jan 2023 15:41:53 GMT, Magnus Ihse Bursie wrote: >> We should add devkit support for linux/riscv64. > > Magnus Ihse Bursie has updated the pull request incrementally with one > additional commit since the last revision: > > Bump minor revision for jib package The solution worked

Re: RFR: 8297851: Add devkit for RISC-V [v3]

2023-01-18 Thread Magnus Ihse Bursie
On Wed, 18 Jan 2023 15:41:53 GMT, Magnus Ihse Bursie wrote: >> We should add devkit support for linux/riscv64. > > Magnus Ihse Bursie has updated the pull request incrementally with one > additional commit since the last revision: > > Bump minor revision for jib package It turned out we

Re: RFR: 8297851: Add devkit for RISC-V [v3]

2023-01-18 Thread Magnus Ihse Bursie
> We should add devkit support for linux/riscv64. Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision: Bump minor revision for jib package - Changes: - all: https://git.openjdk.org/jdk/pull/11432/files - new:

Re: RFR: 8295795: hsdis does not build with binutils 2.39+

2023-01-18 Thread Ludovic Henry
On Fri, 21 Oct 2022 15:26:59 GMT, Aleksey Shipilev wrote: > Fails like this: > > > $ sh ./configure --with-boot-jdk=jdk19u-ea --with-hsdis=binutils > --with-binutils-src=binutils-2.39 > $ make clean build-hsdis > > === Output from failing command(s) repeated here === > * For target

Re: RFR: 8295795: hsdis does not build with binutils 2.39+

2023-01-18 Thread Aleksey Shipilev
On Fri, 21 Oct 2022 15:33:10 GMT, Aleksey Shipilev wrote: >> Fails like this: >> >> >> $ sh ./configure --with-boot-jdk=jdk19u-ea --with-hsdis=binutils >> --with-binutils-src=binutils-2.39 >> $ make clean build-hsdis >> >> === Output from failing command(s) repeated here === >> * For target

Re: RFR: 8295795: hsdis does not build with binutils 2.39+

2023-01-18 Thread Ludovic Henry
On Fri, 21 Oct 2022 15:33:10 GMT, Aleksey Shipilev wrote: >> Fails like this: >> >> >> $ sh ./configure --with-boot-jdk=jdk19u-ea --with-hsdis=binutils >> --with-binutils-src=binutils-2.39 >> $ make clean build-hsdis >> >> === Output from failing command(s) repeated here === >> * For target

Re: RFR: 8297851: Add devkit for RISC-V [v2]

2023-01-18 Thread Magnus Ihse Bursie
On Wed, 18 Jan 2023 01:24:24 GMT, Fei Yang wrote: >> make/devkit/Tools.gmk line 71: >> >>> 69: BASE_OS_VERSION := $(DEFAULT_OS_VERSION) >>> 70: endif >>> 71: BASE_URL := >>> http://fedora.riscv.rocks/repos-dist/$(BASE_OS_VERSION)/$(ARCH)/Packages/ >> >> Hi, thanks for adding

Re: RFR: JDK-8300531: MSVC CFlags look suspicious

2023-01-18 Thread Justin King
On Wed, 18 Jan 2023 14:32:20 GMT, Justin King wrote: > Update MSVC CFlags to be more consistent with other compilers. Also disables > RTTI in a simliar manner to GCC/Clang for the JVM. Not sure why `-Oy-` was used. GCC/Clang omit frame pointers by default these days, IIRC. So forcing MSVC to

RFR: JDK-8300531: MSVC CFlags look suspicious

2023-01-18 Thread Justin King
Update MSVC CFlags to be more consistent with other compilers. Also disables RTTI in a simliar manner to GCC/Clang for the JVM. - Commit messages: - Update MSVC CFlags Changes: https://git.openjdk.org/jdk/pull/12073/files Webrev: https://webrevs.openjdk.org/?repo=jdk=12073=00

Re: RFR: 8297851: Add devkit for RISC-V [v2]

2023-01-18 Thread Magnus Ihse Bursie
> We should add devkit support for linux/riscv64. Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the

Re: RFR: 8297851: Add devkit for RISC-V

2023-01-18 Thread Erik Joelsson
On Wed, 30 Nov 2022 14:03:30 GMT, Magnus Ihse Bursie wrote: > We should add devkit support for linux/riscv64. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11432

Re: [jdk20] RFR: 8300490: Spaces in name of MacOS Code Signing Identity are not correctly handled after JDK-8293550

2023-01-18 Thread Erik Joelsson
On Wed, 18 Jan 2023 11:09:21 GMT, Christoph Langer wrote: > This fixes an issue when the MacOS codesign identity contains spaces. For > that case, quoted arguments are not correctly handled in current code. We > need to pass doublequotes literally in the argument parameter and then have >

[jdk20] RFR: 8300490: Spaces in name of MacOS Code Signing Identity are not correctly handled after JDK-8293550

2023-01-18 Thread Christoph Langer
This fixes an issue when the MacOS codesign identity contains spaces. For that case, quoted arguments are not correctly handled in current code. We need to pass doublequotes literally in the argument parameter and then have eval handle the call to correctly construct the args to codesign.

Integrated: 8300169: Build failure with clang-15

2023-01-18 Thread Jie Fu
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote: > Hi all, > > Please review the fix for the build failure with clang-15. > > 1. -Wbitwise-instead-of-logical > >1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the > warning >2)