Re: RFR: 8300692: GCC 12 reports some compiler warnings in bundled freetype

2023-01-19 Thread Sergey Bylokhov
On Thu, 19 Jan 2023 20:00:56 GMT, Dan Lutker wrote: > Disabling warnings for bundled Freetype Marked as reviewed by serb (Reviewer). - PR: https://git.openjdk.org/jdk/pull/12102

Integrated: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions

2023-01-19 Thread Matias Saavedra Silva
On Wed, 4 Jan 2023 20:07:48 GMT, Matias Saavedra Silva wrote: > This is an enhancement of the test case in > [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests > against an archive created by the "boot JDK", which is usually set as the > previous official JDK release

Integrated: Merge jdk20

2023-01-19 Thread Jesper Wilhelmsson
On Thu, 19 Jan 2023 20:42:26 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 20 -> JDK 21 This pull request has now been integrated. Changeset: dfcd65c2 Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/dfcd65c2719cae19d41caf25f9aa0691568247e8 Stats: 45 lines

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions [v11]

2023-01-19 Thread Matias Saavedra Silva
On Thu, 19 Jan 2023 20:10:23 GMT, Matias Saavedra Silva wrote: >> This is an enhancement of the test case in >> [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests >> against an archive created by the "boot JDK", which is usually set as the >> previous official JDK

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions [v11]

2023-01-19 Thread Ioi Lam
On Thu, 19 Jan 2023 20:10:23 GMT, Matias Saavedra Silva wrote: >> This is an enhancement of the test case in >> [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests >> against an archive created by the "boot JDK", which is usually set as the >> previous official JDK

Re: RFR: 8300692: GCC 12 reports some compiler warnings in bundled freetype

2023-01-19 Thread Erik Joelsson
On Thu, 19 Jan 2023 20:00:56 GMT, Dan Lutker wrote: > Disabling warnings for bundled Freetype Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.org/jdk/pull/12102

Re: RFR: JDK-8300592: ASan build does not correctly propagate options to some test launchers

2023-01-19 Thread Justin King
On Wed, 18 Jan 2023 20:40:40 GMT, Justin King wrote: > Update some custom launchers to set the default ASan options, without it the > tests fail due to incompatibility with LSan. Additionally adds `-fno-common` > for ASan build, as suggested by the docs. @magicus Yet more build fixes for

RFR: Merge jdk20

2023-01-19 Thread Jesper Wilhelmsson
Forwardport JDK 20 -> JDK 21 - Commit messages: - Merge remote-tracking branch 'jdk20/master' into Merge_jdk20 - 8298400: Virtual thread instability when stack overflows - 8300490: Spaces in name of MacOS Code Signing Identity are not correctly handled after JDK-8293550 The

Re: RFR: JDK-8300531: MSVC CFlags look suspicious [v2]

2023-01-19 Thread Justin King
On Thu, 19 Jan 2023 19:23:30 GMT, Erik Joelsson wrote: > Changing the global optimization flags is a pretty big and potentially > intrusive change. It's quite possible that the current flags need a > re-evaluation, since they were chosen a long time ago, for a much older > version of Visual

Re: RFR: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions [v11]

2023-01-19 Thread Matias Saavedra Silva
> This is an enhancement of the test case in > [JDK-8296754](https://bugs.openjdk.org/browse/JDK-8296754), which tests > against an archive created by the "boot JDK", which is usually set as the > previous official JDK release when building the JDK repo. > > If it's able to acquire previous

RFR: 8300692: GCC 12 reports some compiler warnings in bundled freetype

2023-01-19 Thread Dan Lutker
Disabling warnings for bundled Freetype - Commit messages: - 8300692: GCC 12 reports some compiler warnings in bundled freetype Changes: https://git.openjdk.org/jdk/pull/12102/files Webrev: https://webrevs.openjdk.org/?repo=jdk=12102=00 Issue:

Re: RFR: JDK-8300531: MSVC CFlags look suspicious [v2]

2023-01-19 Thread Erik Joelsson
On Thu, 19 Jan 2023 19:23:30 GMT, Erik Joelsson wrote: > I don't think making the number after the O in the flags match what we use > for other compilers is motivation enough to warrant a change like this. > Different compilers are sure to have their optimization levels mean different >

Re: RFR: JDK-8300531: MSVC CFlags look suspicious [v2]

2023-01-19 Thread Erik Joelsson
On Thu, 19 Jan 2023 17:27:57 GMT, Justin King wrote: >> Update MSVC CFlags to be more consistent with other compilers. Also disables >> RTTI in a simliar manner to GCC/Clang for the JVM. > > Justin King has updated the pull request with a new target base due to a > merge or a rebase. The

Re: RFR: JDK-8300531: MSVC CFlags look suspicious [v2]

2023-01-19 Thread Justin King
> Update MSVC CFlags to be more consistent with other compilers. Also disables > RTTI in a simliar manner to GCC/Clang for the JVM. Justin King has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by

Re: RFR: 8295795: hsdis does not build with binutils 2.39+

2023-01-19 Thread Ludovic Henry
On Fri, 21 Oct 2022 15:26:59 GMT, Aleksey Shipilev wrote: > Fails like this: > > > $ sh ./configure --with-boot-jdk=jdk19u-ea --with-hsdis=binutils > --with-binutils-src=binutils-2.39 > $ make clean build-hsdis > > === Output from failing command(s) repeated here === > * For target

Re: RFR: 8295795: hsdis does not build with binutils 2.39+

2023-01-19 Thread Aleksey Shipilev
On Wed, 18 Jan 2023 15:08:00 GMT, Ludovic Henry wrote: > Edit: Issue arises because hsdis needs to support older versions of hotspot > which expect a `...` argument. Other than breaking compatibility of newer > hsdis for older JVMs, I don't know how to keep the compatibility both ways. Yes,