Integrated: 8301267: Update of config.guess broke build on WSL

2023-01-30 Thread Erik Joelsson
On Fri, 27 Jan 2023 21:11:00 GMT, Erik Joelsson wrote: > After JDK-8300805, config.guess has changed output when running on WSL. This > is caused by the autoconf-config.guess now reporting it as > `x86_64-pc-linux-gnu` instead of `x86_64-unknown-linux-gnu`, and our wrapper > script is expectin

Re: RFR: 8301267: Update of config.guess broke build on WSL

2023-01-30 Thread Daniel JeliƄski
On Fri, 27 Jan 2023 21:11:00 GMT, Erik Joelsson wrote: > After JDK-8300805, config.guess has changed output when running on WSL. This > is caused by the autoconf-config.guess now reporting it as > `x86_64-pc-linux-gnu` instead of `x86_64-unknown-linux-gnu`, and our wrapper > script is expectin

Integrated: 8298424: Remove redundant FOUND_CORES variable in build-performance.m4

2023-01-30 Thread Amit Kumar
On Mon, 30 Jan 2023 08:42:14 GMT, Amit Kumar wrote: > Beside any specific reason which I'm unaware of, IMO FOUND_CORES variable > serves no purpose. So probably we could remove it, without any issue. > > Any suggestion/thoughts are appreciated :) This pull request has now been integrated. Ch

Re: RFR: 8298424: Remove redundant FOUND_CORES variable in build-performance.m4

2023-01-30 Thread Tyler Steele
On Mon, 30 Jan 2023 08:42:14 GMT, Amit Kumar wrote: > Beside any specific reason which I'm unaware of, IMO FOUND_CORES variable > serves no purpose. So probably we could remove it, without any issue. > > Any suggestion/thoughts are appreciated :) Marked as reviewed by tsteele (Committer). --

Re: RFR: 8298424: Remove redundant FOUND_CORES variable in build-performance.m4

2023-01-30 Thread Amit Kumar
On Mon, 30 Jan 2023 13:52:48 GMT, Erik Joelsson wrote: >> Beside any specific reason which I'm unaware of, IMO FOUND_CORES variable >> serves no purpose. So probably we could remove it, without any issue. >> >> Any suggestion/thoughts are appreciated :) > > There is one subtle change in behavi

Re: RFR: 8298424: Remove redundant FOUND_CORES variable in build-performance.m4

2023-01-30 Thread Erik Joelsson
On Mon, 30 Jan 2023 08:42:14 GMT, Amit Kumar wrote: > Beside any specific reason which I'm unaware of, IMO FOUND_CORES variable > serves no purpose. So probably we could remove it, without any issue. > > Any suggestion/thoughts are appreciated :) There is one subtle change in behavior in this

RFR: 8298424: Remove redundant FOUND_CORES variable in build-performance.m4

2023-01-30 Thread Amit Kumar
Beside any specific reason which I'm unaware of, IMO FOUND_CORES variable serves no purpose. So probably we could remove it, without any issue. Any suggestion/thoughts are appreciated :) - Commit messages: - FOUND_CORES variable could be removed Changes: https://git.openjdk.org/j