Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-02 Thread Thomas Stuefe
On Thu, 2 Feb 2023 06:34:56 GMT, Thomas Stuefe wrote: >> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Support CDS >> >> Signed-off-by: Justin King > > Thinking this through some more: > > Why would

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v3]

2023-02-02 Thread David Holmes
On Thu, 2 Feb 2023 15:52:01 GMT, Justin King wrote: >> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been >> used to identify multiple leaks so far. It can run most of the test suite >> except those that also fail with ASan, which is being looked at separately. >> It is

Re: RFR: 8301717: Remove obsolete jib profiles

2023-02-02 Thread David Holmes
On Thu, 2 Feb 2023 22:44:40 GMT, Erik Joelsson wrote: > This patch removes some now obsolete jib profiles configurations. Removal seems fine. Thanks. - Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.org/jdk/pull/12395

RFR: 8301717: Remove obsolete jib profiles

2023-02-02 Thread Erik Joelsson
This patch removes some now obsolete jib profiles configurations. - Commit messages: - JDK-8301717 Changes: https://git.openjdk.org/jdk/pull/12395/files Webrev: https://webrevs.openjdk.org/?repo=jdk=12395=00 Issue: https://bugs.openjdk.org/browse/JDK-8301717 Stats: 18 lines in

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-02 Thread Justin King
On Thu, 2 Feb 2023 06:34:56 GMT, Thomas Stuefe wrote: >> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Support CDS >> >> Signed-off-by: Justin King > > Thinking this through some more: > > Why would

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-02 Thread Justin King
On Thu, 2 Feb 2023 06:06:04 GMT, David Holmes wrote: >> src/hotspot/share/runtime/arguments.cpp line 3979: >> >>> 3977: // LSAN relies on pointers to be natively aligned. Using compressed >>> class pointers breaks this >>> 3978: // expectation and results in nondeterministic leak reports.

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v2]

2023-02-02 Thread Justin King
On Thu, 2 Feb 2023 05:34:57 GMT, David Holmes wrote: >> Justin King has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Support CDS >> >> Signed-off-by: Justin King > > make/data/lsan/lsan_default_options.c line 49: > >> 47: //

Re: RFR: JDK-8298445: Add LeakSanitizer support in HotSpot [v3]

2023-02-02 Thread Justin King
> Adds initial LSan (LeakSanitizer) support to Hotspot. This setup has been > used to identify multiple leaks so far. It can run most of the test suite > except those that rely on testing compressed oops or compressed class > pointers. It is especially useful when combined with ASan, as LSan