Re: RFR: 8301119: Support for GB18030-2022 [v2]

2023-02-22 Thread Naoto Sato
On Wed, 22 Feb 2023 11:34:59 GMT, Alan Bateman wrote: >> src/java.base/share/classes/sun/nio/cs/StandardCharsets.java.template line >> 217: >> >>> 215: if (VM.initLevel() < 1) { >>> 216: // Cannot get the system property yet. Assumes non-2000 >>> 217:

Re: RFR: 8301119: Support for GB18030-2022 [v2]

2023-02-22 Thread Naoto Sato
> Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since > this is not a compatible upgrade to the existing mapping, a new system > property `jdk.charset.GB18030` is introduced. If it is set to "2000", the > mapping falls back to the existing mapping based on the 2000 standa

Re: RFR: 8302659: Modernize Windows native code for NetworkInterface [v3]

2023-02-22 Thread Rich DiCroce
On Fri, 17 Feb 2023 20:51:35 GMT, Daniel Jeliński wrote: >> Though it's more complicated than that. Some machines may have both IPv6 and >> IPv4, some machine may only have IPv4, and some machine may only have IPv6. >> I haven't looked at the test yet, but picking up the right interface on the

Re: RFR: 8302659: Modernize Windows native code for NetworkInterface [v3]

2023-02-22 Thread Rich DiCroce
On Fri, 17 Feb 2023 20:58:13 GMT, Daniel Jeliński wrote: >> For the IPv6 code, this should be the same as before. See >> getAddrsFromAdapter in the original code, which enumerates the unicast >> addresses first and then does the anycast addresses. >> >> For IPv4, I'm not sure. The MS docs for

Re: RFR: 8302659: Modernize Windows native code for NetworkInterface [v3]

2023-02-22 Thread Rich DiCroce
On Thu, 16 Feb 2023 15:48:17 GMT, Daniel Jeliński wrote: >> Rich DiCroce has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Forgot to add file >> - Resolve review comments > > src/java.base/windows/native/libnet/NetworkInterface.c line 2

Re: RFR: 8302659: Modernize Windows native code for NetworkInterface [v2]

2023-02-22 Thread Rich DiCroce
On Fri, 17 Feb 2023 10:37:30 GMT, Mark Sheppard wrote: >> Rich DiCroce has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Limit line length to 80-ish characters > > I don't think the NetworkInterface.h file should be dropped. > It is prefer

Re: RFR: 8302659: Modernize Windows native code for NetworkInterface [v3]

2023-02-22 Thread Rich DiCroce
> Improves performance and correctness, as discussed on the net-dev mailing > list. Rich DiCroce has updated the pull request incrementally with two additional commits since the last revision: - Forgot to add file - Resolve review comments - Changes: - all: https://git.openjdk

Re: RFR: 8301119: Support for GB18030-2022

2023-02-22 Thread Alan Bateman
On Fri, 10 Feb 2023 20:35:58 GMT, Naoto Sato wrote: > Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since > this is not a compatible upgrade to the existing mapping, a new system > property `jdk.charset.GB18030` is introduced. If it is set to "2000", the > mapping falls

Re: Windows compiled pandoc seems to not work properly

2023-02-22 Thread Julian Waters
Hi Erik, thanks for the heads up, I'll look at the linked entry closer ~Julian On Wed, Feb 22, 2023 at 9:52 PM wrote: > It's a known problem, though we could certainly handle it better. > > https://bugs.openjdk.org/browse/JDK-8223157 > > /Erik > > On 2/21/23 23:11, Julian Waters wrote: > > Hi a

Re: Windows compiled pandoc seems to not work properly

2023-02-22 Thread erik . joelsson
It's a known problem, though we could certainly handle it better. https://bugs.openjdk.org/browse/JDK-8223157 /Erik On 2/21/23 23:11, Julian Waters wrote: Hi all, While generating docs on Windows, it appears to me that pandoc compiled natively for the Windows OS itself never seems to work p

Re: RFR: 8301119: Support for GB18030-2022

2023-02-22 Thread Alan Bateman
On Wed, 22 Feb 2023 10:46:10 GMT, Sean Coffey wrote: > curious - what scenario triggers this call at initLevel < 1 ? It's not supported, but it is possible that someone might run with -Dfile.encoding=GB18030, in which case the default charset is used before the system properties are initialize

Re: RFR: 8301119: Support for GB18030-2022

2023-02-22 Thread Sean Coffey
On Fri, 10 Feb 2023 20:35:58 GMT, Naoto Sato wrote: > Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since > this is not a compatible upgrade to the existing mapping, a new system > property `jdk.charset.GB18030` is introduced. If it is set to "2000", the > mapping falls

Re: RFR: 8301119: Support for GB18030-2022

2023-02-22 Thread Alan Bateman
On Fri, 10 Feb 2023 20:35:58 GMT, Naoto Sato wrote: > Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since > this is not a compatible upgrade to the existing mapping, a new system > property `jdk.charset.GB18030` is introduced. If it is set to "2000", the > mapping falls