Re: RFR: JDK-8303166: Disable RTTI for Hotspot when building with MSVC [v3]

2023-02-24 Thread Alex Menkov
On Fri, 24 Feb 2023 19:56:39 GMT, Justin King wrote: >> Disable RTTI `-GR-` for Hotspot when building with MSVC. This drops the size >> of `jvm.dll` by roughly 1 MB. Hotspot does not rely on RTTI and it is >> disabled for both GCC/Clang and Open XL C/C++ already. This change disables >> it

Re: RFR: JDK-8303166: Disable RTTI for Hotspot when building with MSVC [v3]

2023-02-24 Thread Justin King
> Disable RTTI `-GR-` for Hotspot when building with MSVC. This drops the size > of `jvm.dll` by roughly 1 MB. Hotspot does not rely on RTTI and it is > disabled for both GCC/Clang and Open XL C/C++ already. This change disables > it for MSVC, ensuring we do not accidently rely on RTTI for

Re: RFR: JDK-8303166: Disable RTTI for Hotspot when building with MSVC [v2]

2023-02-24 Thread Justin King
> Disable RTTI `-GR-` for Hotspot when building with MSVC. This drops the size > of `jvm.dll` by roughly 1 MB. Hotspot does not rely on RTTI and it is > disabled for both GCC/Clang and Open XL C/C++ already. This change disables > it for MSVC, ensuring we do not accidently rely on RTTI for

Re: RFR: JDK-8303166: Disable RTTI for Hotspot when building with MSVC

2023-02-24 Thread Chris Plummer
On Fri, 24 Feb 2023 15:36:16 GMT, Justin King wrote: > Disable RTTI `-GR-` for Hotspot when building with MSVC. This drops the size > of `jvm.dll` by roughly 1 MB. Hotspot does not rely on RTTI and it is > disabled for both GCC/Clang and Open XL C/C++ already. This change disables > it for

Re: RFR: 8301119: Support for GB18030-2022 [v4]

2023-02-24 Thread Lance Andersen
On Fri, 24 Feb 2023 17:23:25 GMT, Naoto Sato wrote: >> Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since >> this is not a compatible upgrade to the existing mapping, a new system >> property `jdk.charset.GB18030` is introduced. If it is set to "2000", the >> mapping

Re: RFR: 8301119: Support for GB18030-2022 [v4]

2023-02-24 Thread Naoto Sato
> Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since > this is not a compatible upgrade to the existing mapping, a new system > property `jdk.charset.GB18030` is introduced. If it is set to "2000", the > mapping falls back to the existing mapping based on the 2000

Re: RFR: 8301119: Support for GB18030-2022 [v3]

2023-02-24 Thread Naoto Sato
On Fri, 24 Feb 2023 08:34:48 GMT, Ichiroh Takiguchi wrote: > Hello @naotoj . Sorry for bothering you. > > I have following question: > > * Why GB18030.java.template is in > src/jdk.charsets/share/classes/sun/nio/cs/ext/ directory even if the > generated code is always stored into sun/nio/cs

RFR: JDK-8303166: Disable RTTI for Hotspot when building with MSVC

2023-02-24 Thread Justin King
Disable RTTI `-GR-` for Hotspot when building with MSVC. This drops the size of `jvm.dll` by roughly 1 MB. Hotspot does not rely on RTTI and it is disabled for both GCC/Clang and Open XL C/C++ already. This change disables it for MSVC, ensuring we do not accidently rely on RTTI for

Re: RFR: 8301119: Support for GB18030-2022 [v3]

2023-02-24 Thread Alan Bateman
On Fri, 24 Feb 2023 08:34:48 GMT, Ichiroh Takiguchi wrote: > * Why GB18030.java.template is in > src/jdk.charsets/share/classes/sun/nio/cs/ext/ directory even if the > generated code is always stored into sun/nio/cs ? That is a good question. It could move, and $PACKAGE replaced with

Re: RFR: 8301119: Support for GB18030-2022 [v3]

2023-02-24 Thread Sean Coffey
On Thu, 23 Feb 2023 19:34:44 GMT, Naoto Sato wrote: >> Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since >> this is not a compatible upgrade to the existing mapping, a new system >> property `jdk.charset.GB18030` is introduced. If it is set to "2000", the >> mapping

Integrated: 8303131: pandoc.exe mangles all processed html files

2023-02-24 Thread Julian Waters
On Thu, 23 Feb 2023 19:18:32 GMT, Julian Waters wrote: > pandoc.exe follows the Windows CRLF format of newlines, whereas we only ever > have LF in our documentation files. As a result whenever we generate html the > resulting html files will all be mangled, even if there was no change to the

Re: RFR: 8303131: pandoc.exe mangles all processed html files

2023-02-24 Thread Julian Waters
On Thu, 23 Feb 2023 21:01:52 GMT, Erik Joelsson wrote: >> pandoc.exe follows the Windows CRLF format of newlines, whereas we only ever >> have LF in our documentation files. As a result whenever we generate html >> the resulting html files will all be mangled, even if there was no change to

Re: RFR: 8301119: Support for GB18030-2022 [v3]

2023-02-24 Thread Ichiroh Takiguchi
On Thu, 23 Feb 2023 19:34:44 GMT, Naoto Sato wrote: >> Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since >> this is not a compatible upgrade to the existing mapping, a new system >> property `jdk.charset.GB18030` is introduced. If it is set to "2000", the >> mapping