Re: RFR: JDK-8303166: Disable RTTI for Hotspot when building with MSVC [v3]

2023-02-25 Thread David Holmes
On Fri, 24 Feb 2023 19:56:39 GMT, Justin King wrote: >> Disable RTTI `-GR-` for Hotspot when building with MSVC. This drops the size >> of `jvm.dll` by roughly 1 MB. Hotspot does not rely on RTTI and it is >> disabled for both GCC/Clang and Open XL C/C++ already. This change disables >> it for

Re: RFR: 8301119: Support for GB18030-2022 [v3]

2023-02-25 Thread Ichiroh Takiguchi
On Fri, 24 Feb 2023 17:19:22 GMT, Naoto Sato wrote: >> Hello @naotoj . >> Sorry for bothering you. >> >> I have following question: >> - Why GB18030.java.template is in >> src/jdk.charsets/share/classes/sun/nio/cs/ext/ directory even if the >> generated code is always stored into sun/nio/cs ?

Re: RFR: JDK-8303166: Disable RTTI for Hotspot when building with MSVC [v3]

2023-02-25 Thread Kim Barrett
On Fri, 24 Feb 2023 19:56:39 GMT, Justin King wrote: >> Disable RTTI `-GR-` for Hotspot when building with MSVC. This drops the size >> of `jvm.dll` by roughly 1 MB. Hotspot does not rely on RTTI and it is >> disabled for both GCC/Clang and Open XL C/C++ already. This change disables >> it for