On Tue, 28 Feb 2023 20:45:38 GMT, Phil Race wrote:
>> I think you have read more about the differences between -fpic and -fPIC
>> than I have, so nothing I can add here.
>>
>> Making this option only on aarch64 seems like a reasonable idea if that's
>> where we see the effect.
>
>> I dont thin
On Tue, 28 Feb 2023 23:55:31 GMT, Sergey Bylokhov wrote:
> When I mention that option in the JBS, I meant that we should take a look on
> how the methods in the library are "packed" since for some reason "-fpic"
> make some difference, probably we should use "static" more often or something
>
On Wed, 1 Mar 2023 00:01:39 GMT, Mikael Vidstedt wrote:
> Update the devkit used for cross compiling linux-aarch64 binaries on
> linux-x64 at Oracle.
This pull request has now been integrated.
Changeset: 65da2c5d
Author:Mikael Vidstedt
URL:
https://git.openjdk.org/jdk/commit/65da2c
On Wed, 1 Mar 2023 00:01:39 GMT, Mikael Vidstedt wrote:
> Update the devkit used for cross compiling linux-aarch64 binaries on
> linux-x64 at Oracle.
Looks good. Thanks for fixing!
-
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12793
Update the devkit used for cross compiling linux-aarch64 binaries on linux-x64
at Oracle.
-
Commit messages:
- 8303412: Update linux_x64-to-linux_aarch64 cross compilation devkit at Oracle
Changes: https://git.openjdk.org/jdk/pull/12793/files
Webrev: https://webrevs.openjdk.org/?r
On Tue, 28 Feb 2023 06:55:36 GMT, Jayathirth D V wrote:
>> Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of
>> gcc optimizations from -O1 level for libawt build. This improved our
>> J2DBench performance numbers in some options considerably.
>>
>> Recent changes done
On Tue, 28 Feb 2023 13:57:21 GMT, Erik Joelsson wrote:
>> Thanks @prrace for your inputs.
>> I dont think -fPIC is implied by -fpic. @erikj79 please clarify.
>>
>> Difference between -fpic and -fPIC:
>> 1) With -fPIC we have unlimited storage capacity for global offset table and
>> with -fpic
On Mon, 27 Feb 2023 15:54:28 GMT, Dmitry Markov wrote:
> Added the section devoted to client UI test which use Robot API
This pull request has now been integrated.
Changeset: a10d5ac6
Author:Dmitry Markov
URL:
https://git.openjdk.org/jdk/commit/a10d5ac61be3d074937f629959c7aeb6941472
> Eclipse is a popular and very well-known IDE in the world of Java
> development, utilized widely in many contexts, by beginners and experienced
> teams alike. Although a relatively lightweight IDE, it features surprisingly
> powerful indexing and code analysis capabilities, as well as useful t
On Wed, 22 Feb 2023 17:40:31 GMT, Rich DiCroce wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing
>> list.
>
> Rich DiCroce has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Forgot to add file
> - Resolve
On Tue, 28 Feb 2023 17:03:01 GMT, Dmitry Markov wrote:
>> Added the section devoted to client UI test which use Robot API
>
> Dmitry Markov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix link
Thank you for this doc update.
--
On Tue, 28 Feb 2023 17:03:01 GMT, Dmitry Markov wrote:
>> Added the section devoted to client UI test which use Robot API
>
> Dmitry Markov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix link
Marked as reviewed by prr (Reviewer).
---
On Wed, 22 Feb 2023 17:40:31 GMT, Rich DiCroce wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing
>> list.
>
> Rich DiCroce has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Forgot to add file
> - Resolve
On Tue, 28 Feb 2023 17:03:01 GMT, Dmitry Markov wrote:
>> Added the section devoted to client UI test which use Robot API
>
> Dmitry Markov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix link
Marked as reviewed by aivanov (Reviewer).
On Tue, 28 Feb 2023 16:45:36 GMT, Alexey Ivanov wrote:
>> Dmitry Markov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo
>
> doc/testing.md line 668:
>
>> 666: Additional information about Client UI tests configuration for vario
> Added the section devoted to client UI test which use Robot API
Dmitry Markov has updated the pull request incrementally with one additional
commit since the last revision:
Fix link
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12772/files
- new: https://git.openjdk.or
On Tue, 28 Feb 2023 14:17:11 GMT, Dmitry Markov wrote:
>> Added the section devoted to client UI test which use Robot API
>
> Dmitry Markov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo
Changes requested by aivanov (Reviewer).
On Tue, 28 Feb 2023 14:17:11 GMT, Dmitry Markov wrote:
>> Added the section devoted to client UI test which use Robot API
>
> Dmitry Markov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo
Marked as reviewed by erikj (Reviewer).
-
On Wed, 22 Feb 2023 17:40:31 GMT, Rich DiCroce wrote:
>> Improves performance and correctness, as discussed on the net-dev mailing
>> list.
>
> Rich DiCroce has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Forgot to add file
> - Resolve
On Thu, 16 Feb 2023 14:47:52 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added 4-byte Unicode text to Utf8EntryTest
>
> src/java.base/share/classes/jdk/internal/classfile/impl/Instructi
On Thu, 16 Feb 2023 14:41:16 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added 4-byte Unicode text to Utf8EntryTest
>
> src/java.base/share/classes/jdk/internal/classfile/impl/ConcreteE
On Thu, 16 Feb 2023 13:43:32 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added 4-byte Unicode text to Utf8EntryTest
>
> src/java.base/share/classes/jdk/internal/classfile/impl/BytecodeH
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
>
On Tue, 28 Feb 2023 14:33:58 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/impl/AttributeHolder.java
>> line 38:
>>
>>> 36: private final List> attributes = new ArrayList<>();
>>> 37:
>>> 38: public AttributeHolder() {
>>
>> default constructor
>
> yes,
lgtm
Le mar. 28 févr. 2023 à 15:18, Dmitry Markov a écrit :
> On Tue, 28 Feb 2023 14:00:21 GMT, Erik Joelsson wrote:
>
> >> Dmitry Markov has updated the pull request incrementally with one
> additional commit since the last revision:
> >>
> >> Fix review findings
> >
> > doc/testing.md line
On Thu, 16 Feb 2023 13:47:04 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added 4-byte Unicode text to Utf8EntryTest
>
> src/java.base/share/classes/jdk/internal/classfile/impl/Attribute
On Thu, 16 Feb 2023 13:40:49 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added 4-byte Unicode text to Utf8EntryTest
>
> src/java.base/share/classes/jdk/internal/classfile/constantpool/C
> Added the section devoted to client UI test which use Robot API
Dmitry Markov has updated the pull request incrementally with one additional
commit since the last revision:
Fix typo
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12772/files
- new: https://git.openjdk.or
On Tue, 28 Feb 2023 14:00:21 GMT, Erik Joelsson wrote:
>> Dmitry Markov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix review findings
>
> doc/testing.md line 666:
>
>> 664: the `ForegroundLockTimeout` value is set to 0.
>> 665:
>
On Thu, 16 Feb 2023 12:55:06 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added 4-byte Unicode text to Utf8EntryTest
>
> src/java.base/share/classes/jdk/internal/classfile/impl/SplitCons
On Tue, 28 Feb 2023 11:03:41 GMT, Dmitry Markov wrote:
>> Added the section devoted to client UI test which use Robot API
>
> Dmitry Markov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix review findings
doc/testing.md line 666:
> 664
On Tue, 28 Feb 2023 06:47:37 GMT, Jayathirth D V wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 130:
>>
>>> 128: BUILD_LIBAWT_debug_mem.c_CFLAGS := -w
>>> 129: # This option improves performance of FillRect/FillOval in Java2D by
>>> 15% for some gcc
>>> 130: LIBAWT_CFLAGS
pre submit tests failed
Le mar. 28 févr. 2023 à 12:04, Dmitry Markov a écrit :
> On Mon, 27 Feb 2023 20:52:52 GMT, Sergey Bylokhov
> wrote:
>
> >> Dmitry Markov has updated the pull request incrementally with one
> additional commit since the last revision:
> >>
> >> Fix review findings
> >
>
On Mon, 27 Feb 2023 18:49:15 GMT, Alexey Ivanov wrote:
>> Dmitry Markov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix review findings
>
> doc/testing.md line 616:
>
>> 614: system key shortcuts for various platforms are provided b
On Mon, 27 Feb 2023 20:52:52 GMT, Sergey Bylokhov wrote:
>> Dmitry Markov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix review findings
>
> doc/testing.md line 664:
>
>> 662: select Registry Editor; navigate to the following key:
On Mon, 27 Feb 2023 21:11:33 GMT, Alexey Ivanov wrote:
>> doc/testing.html line 621:
>>
>>> 619: the following apps are allowed to control your computer:
>>> 620: Java and Terminal. If the tests are run from
>>> 621: an IDE, the IDE should be granted this permission too.
>>
>> You can mention t
On Mon, 27 Feb 2023 15:54:28 GMT, Dmitry Markov wrote:
> Added the section devoted to client UI test which use Robot API
@aivanov-jdk @mrserb Thanks for review. I have updated the text based on your
suggestions. Please have a look at the new version.
-
PR: https://git.openjdk.org/
> Added the section devoted to client UI test which use Robot API
Dmitry Markov has updated the pull request incrementally with one additional
commit since the last revision:
Fix review findings
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12772/files
- new: https://git
38 matches
Mail list logo
