Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v9]

2023-04-08 Thread Roger Riggs
> Define an internal jdk.internal.util.Architecture enumeration and static > methods to replace uses of the system property `os.arch`. > The enumeration values are defined to match those used in the build. > The initial values are: `X64, X86, IA64, ARM, AARCH64, RISCV64, S390X, > PPC64LE` > Note

Integrated: 8305721: add `make compile-commands` artifacts to .gitignore

2023-04-08 Thread Joshua Cao
On Thu, 6 Apr 2023 23:59:55 GMT, Joshua Cao wrote: > `make compile-commands` produces > > * `compile-commands.json` - so clangd knows how to build the project > * `.cache` - I believe clangd uses this as an indexing cache > > Tested by confirming artifacts are not shown when running `git status

Re: RFR: 8305721: add `make compile-commands` artifacts to .gitignore

2023-04-08 Thread Julian Waters
On Thu, 6 Apr 2023 23:59:55 GMT, Joshua Cao wrote: > `make compile-commands` produces > > * `compile-commands.json` - so clangd knows how to build the project > * `.cache` - I believe clangd uses this as an indexing cache > > Tested by confirming artifacts are not shown when running `git status

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v8]

2023-04-08 Thread ExE Boss
On Fri, 7 Apr 2023 21:13:03 GMT, Roger Riggs wrote: >> Define an internal jdk.internal.util.Architecture enumeration and static >> methods to replace uses of the system property `os.arch`. >> The enumeration values are defined to match those used in the build. >> The initial values are: `X64, X8

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v7]

2023-04-08 Thread Thomas Stuefe
On Fri, 7 Apr 2023 21:15:11 GMT, Roger Riggs wrote: > Refactored the way that build time architecture values are mapped to the > Architecture enum. Thank you for this, Roger. - PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1161075537