Re: RFR: 8307058: Implementation of Generational ZGC [v6]

2023-05-04 Thread Stefan Karlsson
On Fri, 5 May 2023 06:28:59 GMT, Yadong Wang wrote: >> Thanks for reporting. It would be interesting to see what address you get >> and compare it to the range [ZAddressHeapBase, >> ZAddressHeapBase+ZAddressOffsetMax). > > We emailed to erik to discuss this issue two months ago, and maybe he mi

Re: RFR: 8307058: Implementation of Generational ZGC [v6]

2023-05-04 Thread Yadong Wang
On Fri, 5 May 2023 05:17:44 GMT, Stefan Karlsson wrote: >> test/hotspot/gtest/gc/z/test_zForwarding.cpp line 68: >> >>> 66: >>> 67: bool reserved = >>> os::attempt_reserve_memory_at((char*)ZAddressHeapBase, ZGranuleSize, false >>> /* executable */); >>> 68: ASSERT_TRUE(reserved); >>

Re: Compiler/aot testing on MacOS

2023-05-04 Thread David Holmes
Hi Joe, It looks like you were not subscribed to the mailing list and this email only just got cleared and has turned up. is this still an issue? Cheers, David On 24/03/2023 12:20 am, Joe Braley wrote: Hello, Our team publishes Microsoft's build of OpenJDK, and we have observed some test f

Re: RFR: 8307058: Implementation of Generational ZGC [v6]

2023-05-04 Thread Stefan Karlsson
On Fri, 5 May 2023 01:54:48 GMT, Fei Yang wrote: >> Stefan Karlsson has updated the pull request incrementally with one >> additional commit since the last revision: >> >> undefine glibc major/minor macros > > test/hotspot/gtest/gc/z/test_zForwarding.cpp line 68: > >> 66: >> 67: bool re

Re: RFR: 8307058: Implementation of Generational ZGC [v6]

2023-05-04 Thread Stefan Karlsson
On Thu, 4 May 2023 20:21:12 GMT, Andrey Turbanov wrote: >> Stefan Karlsson has updated the pull request incrementally with one >> additional commit since the last revision: >> >> undefine glibc major/minor macros > > test/hotspot/jtreg/runtime/stringtable/StringTableCleaningTest.java line 117

Re: RFR: 8307058: Implementation of Generational ZGC [v7]

2023-05-04 Thread Stefan Karlsson
> Hi all, > > Please review the implementation of Generational ZGC, which can be turned on > by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational > ZGC is a major rewrite of the non-generational ZGC version that exists in the > openjdk/jdk repository. It splits the heap i

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots

2023-05-04 Thread Sergey Bylokhov
On Thu, 4 May 2023 14:18:44 GMT, Alexander Zvegintsev wrote: > If the user wishes to change their mind about the screens allowed to be > captured, the user should use the new Robot#resetScreenCapturePermission > method Do we really need to add this new API? probably we can implement the featu

Re: RFR: 8307058: Implementation of Generational ZGC [v6]

2023-05-04 Thread Fei Yang
On Thu, 4 May 2023 11:44:14 GMT, Stefan Karlsson wrote: >> Hi all, >> >> Please review the implementation of Generational ZGC, which can be turned on >> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational >> ZGC is a major rewrite of the non-generational ZGC version tha

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v8]

2023-05-04 Thread Jim Laskey
I suppose that’s a possibility. But is it more informative to have the class print with the synthetic flag? 📱 > On May 4, 2023, at 5:54 PM, Maurizio Cimadamore > wrote: > > On Mon, 1 May 2023 13:06:24 GMT, Jim Laskey wrote: > >>> Add flexible main methods and anonymous main classes to the

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v8]

2023-05-04 Thread Maurizio Cimadamore
On Mon, 1 May 2023 13:06:24 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request incrementally with two additional > commits since the last revision: > > - Anonymous main classes renamed to unnamed clas

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots

2023-05-04 Thread Phil Race
On Thu, 4 May 2023 19:56:21 GMT, Erik Joelsson wrote: > I would like to understand why we need to add third party headers to our > source tree. Are these not generally available on Linux systems? They are not available on anything except very new Linux distros. Forget RHEL 6.x / 7.x. I'm fairl

Re: RFR: 8307058: Implementation of Generational ZGC [v6]

2023-05-04 Thread Andrey Turbanov
On Thu, 4 May 2023 11:44:14 GMT, Stefan Karlsson wrote: >> Hi all, >> >> Please review the implementation of Generational ZGC, which can be turned on >> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational >> ZGC is a major rewrite of the non-generational ZGC version tha

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots

2023-05-04 Thread Erik Joelsson
On Thu, 4 May 2023 14:18:44 GMT, Alexander Zvegintsev wrote: > Modern Linux systems often come with > [Wayland](https://wayland.freedesktop.org/) by default. > This comes with some difficulties, and one of them is the inability to get > screenshots from the system. > This is because we now use

Re: RFR: 8307194: Enhance static-libs-image [v5]

2023-05-04 Thread Jiangli Zhou
On Thu, 4 May 2023 19:12:14 GMT, Severin Gehwolf wrote: >> As @jerboaa mentioned, for GraalVM native-image we produce our own >> `libjvm.a` as part of building GraalVM (every native image gets statically >> linked to that library). See >> https://github.com/oracle/graal/blob/f1c1d710625ac84559

Re: RFR: 8307194: Enhance static-libs-image [v5]

2023-05-04 Thread Jiangli Zhou
On Thu, 4 May 2023 19:12:14 GMT, Severin Gehwolf wrote: >> As @jerboaa mentioned, for GraalVM native-image we produce our own >> `libjvm.a` as part of building GraalVM (every native image gets statically >> linked to that library). See >> https://github.com/oracle/graal/blob/f1c1d710625ac84559

Re: RFR: 8307194: Enhance static-libs-image [v5]

2023-05-04 Thread Severin Gehwolf
On Thu, 4 May 2023 09:40:31 GMT, Paul Woegerer wrote: >> GraalVM native-image has it's own `libjvm.a` shim which would likely >> conflict or produce undesirable results. So I'd prefer the approach where >> `static-libs-image` wouldn't produce hotspot `libjvm.a` as part of it. For >> new uses-c

RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots

2023-05-04 Thread Alexander Zvegintsev
Modern Linux systems often come with [Wayland](https://wayland.freedesktop.org/) by default. This comes with some difficulties, and one of them is the inability to get screenshots from the system. This is because we now use the [X Window System API](https://en.wikipedia.org/wiki/X_Window_System)

Compiler/aot testing on MacOS

2023-05-04 Thread Joe Braley
Hello, Our team publishes Microsoft's build of OpenJDK, and we have observed some test failures after upgrading our macOS agents from 10.15 to MacOS 11. We have also seen these failures on macOS 12.x. The tests that are encountering issues are in compiler/aot category. We are only observing t

Re: RFR: JDK-8298908: Instrument Metaspace for ASan [v2]

2023-05-04 Thread Justin King
The macros defined in sanitizer/asan_interface.h and in our header are the same. For consistency I just re-defined them. When the header is available, since it looks like the macros have been there for a long time, we can just skip redefining it and use them directly. I'll add a comment. On Tue, J

Build OpenJDK17 On Win10 error

2023-05-04 Thread 徐杨
Hellow: When i compile openjdk of version jdk-17-35 on windows 10, appear a trouble of follow, I can’t get useful information from the doc, who can help me shoot this trouble? Thanks very much. xsy@DESKTOP-QL6LMRE ~/openjdk/jdk-jdk-17-35 $ ./configure --with-toolchain-version=2017 --disable

Re: RFR: 8307058: Implementation of Generational ZGC [v6]

2023-05-04 Thread Stefan Karlsson
> Hi all, > > Please review the implementation of Generational ZGC, which can be turned on > by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational > ZGC is a major rewrite of the non-generational ZGC version that exists in the > openjdk/jdk repository. It splits the heap i

Re: RFR: 8307058: Implementation of Generational ZGC [v3]

2023-05-04 Thread Axel Boldt-Christmas
On Thu, 4 May 2023 09:50:23 GMT, Axel Boldt-Christmas wrote: >>> I'm getting build warnings on all linux platforms with gcc-11.3.0: >>> >>> ``` >>> src/hotspot/share/gc/z/zDriver.cpp:84:13: error: In the GNU C Library, >>> "minor" is defined >>> by . For historical compatibility, it is >>> c

Re: RFR: 8307058: Implementation of Generational ZGC [v3]

2023-05-04 Thread Martin Doerr
On Thu, 4 May 2023 09:50:23 GMT, Axel Boldt-Christmas wrote: >>> I'm getting build warnings on all linux platforms with gcc-11.3.0: >>> >>> ``` >>> src/hotspot/share/gc/z/zDriver.cpp:84:13: error: In the GNU C Library, >>> "minor" is defined >>> by . For historical compatibility, it is >>> c

Re: RFR: 8307194: Enhance static-libs-image [v5]

2023-05-04 Thread Paul Woegerer
On Wed, 3 May 2023 18:51:54 GMT, Severin Gehwolf wrote: >>> Could we decouple `hotspot-static-libs` from `static-libs-image` somehow, >>> please? `static-libs-image` is used by the `graal-builder-image` target and >>> it would be good if it didn't include hotspot static libs as they are not >>

Re: RFR: 8307058: Implementation of Generational ZGC [v3]

2023-05-04 Thread Axel Boldt-Christmas
On Wed, 3 May 2023 21:58:25 GMT, Stefan Karlsson wrote: > I'm getting build warnings on all linux platforms with gcc-11.3.0: > > ``` > src/hotspot/share/gc/z/zDriver.cpp:84:13: error: In the GNU C Library, > "minor" is defined > by . For historical compatibility, it is > currently defined by

Re: RFR: 8307058: Implementation of Generational ZGC [v2]

2023-05-04 Thread Stefan Karlsson
On Wed, 3 May 2023 21:08:39 GMT, Stefan Karlsson wrote: >> test/jdk/ProblemList-generational-zgc.txt line 27: >> >>> 25: # >>> 26: # List of quarantined tests for testing with Generational ZGC. >>> 27: # >> >> Are the tests in `test/jdk/sun/tools/jhsdb/` not failing? > > It seems like these tes