WSL building performance and questions

2023-05-05 Thread -
Hello, While I was trying to diagnose the problem that JMH benchmarks can't be run on a fresh cygwin or WSL environment, https://bugs.openjdk.org/browse/JDK-8305669 I found myself troubled with path issues and slow building speed with a Windows target. Meanwhile the linux target is totally fine. 1

Re: RFR: 8307058: Implementation of Generational ZGC [v8]

2023-05-05 Thread Quan Anh Mai
On Fri, 5 May 2023 07:43:17 GMT, Stefan Karlsson wrote: >> Hi all, >> >> Please review the implementation of Generational ZGC, which can be turned on >> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational >> ZGC is a major rewrite of the non-generational ZGC version tha

Re: RFR: 8307569: Build with gcc8 is broken after JDK-8307301 [v2]

2023-05-05 Thread Jie Fu
On Sat, 6 May 2023 01:41:11 GMT, Jie Fu wrote: >> The fix disables expansion-to-defined warning for gcc. >> Thanks. > > Jie Fu has updated the pull request incrementally with one additional commit > since the last revision: > > Add comment It failed with gcc8 & gcc9, but passed with gcc10+.

Re: RFR: 8307569: Build with gcc8 is broken after JDK-8307301 [v2]

2023-05-05 Thread Jie Fu
> The fix disables expansion-to-defined warning for gcc. > Thanks. Jie Fu has updated the pull request incrementally with one additional commit since the last revision: Add comment - Changes: - all: https://git.openjdk.org/jdk/pull/13850/files - new: https://git.openjdk.org/j

RFR: 8307569: Build with gcc8 is broken after JDK-8307301

2023-05-05 Thread Jie Fu
The fix disables expansion-to-defined warning for gcc. Thanks. - Commit messages: - 8307569: Build with gcc8 is broken after JDK-8307301 Changes: https://git.openjdk.org/jdk/pull/13850/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13850&range=00 Issue: https://bugs.openj

Re: RFR: 8304434: [AIX] Update minimum xlclang version [v2]

2023-05-05 Thread Tyler Steele
On Tue, 4 Apr 2023 01:49:09 GMT, Tyler Steele wrote: >> Minor changes to the build system to recognize and warn that an incompatible >> toolchain is detected. > > Tyler Steele has updated the pull request incrementally with one additional > commit since the last revision: > > Change min xlx

Re: RFR: 8304434: [AIX] Update minimum xlclang version [v2]

2023-05-05 Thread Tyler Steele
On Tue, 4 Apr 2023 01:49:09 GMT, Tyler Steele wrote: >> Minor changes to the build system to recognize and warn that an incompatible >> toolchain is detected. > > Tyler Steele has updated the pull request incrementally with one additional > commit since the last revision: > > Change min xlx

Re: RFR: 8304434: [AIX] Update minimum xlclang version [v2]

2023-05-05 Thread Tyler Steele
On Tue, 4 Apr 2023 01:49:09 GMT, Tyler Steele wrote: >> Minor changes to the build system to recognize and warn that an incompatible >> toolchain is detected. > > Tyler Steele has updated the pull request incrementally with one additional > commit since the last revision: > > Change min xlx

Re: RFR: 8307194: Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v7]

2023-05-05 Thread Erik Joelsson
On Fri, 5 May 2023 16:52:22 GMT, Jiangli Zhou wrote: >> This PR is branched from the makefile changes for >> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for >> handling the JDK/hotspot static libraries: >> >> - Introduce new make target(s) for creating image/bundle c

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v11]

2023-05-05 Thread Vicente Romero
On Fri, 5 May 2023 19:17:53 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > Refactor source code launcher looks good -

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v11]

2023-05-05 Thread Jim Laskey
> Add flexible main methods and anonymous main classes to the Java language. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Refactor source code launcher - Changes: - all: https://git.openjdk.org/jdk/pull/13689/files

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v10]

2023-05-05 Thread Jim Laskey
On Fri, 5 May 2023 18:15:20 GMT, Vicente Romero wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Typo > > src/jdk.compiler/share/classes/com/sun/tools/javac/launcher/Main.java line > 466: > >> 464: } catch (

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v10]

2023-05-05 Thread Vicente Romero
On Fri, 5 May 2023 17:31:27 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > Typo src/jdk.compiler/share/classes/com/sun/too

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v9]

2023-05-05 Thread Rémi Forax
On Fri, 5 May 2023 17:35:33 GMT, Vicente Romero wrote: >> `Flags.MANDATED` on a class is currently enough to know if it's a unnamed >> class or not, but it's not enough for classes not produced by javac. > > good point Just to be clear, here, Flags.UNNAMED_CLASS is needed because an an unnamed

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v9]

2023-05-05 Thread Vicente Romero
On Fri, 5 May 2023 17:22:03 GMT, Rémi Forax wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java >> line 3999: >> >>> 3997: Name name = names.fromString(simplename); >>> 3998: JCModifiers anonMods = F.at(primaryPos) >>> 3999: >>>

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v9]

2023-05-05 Thread Jim Laskey
On Fri, 5 May 2023 16:42:43 GMT, Vicente Romero wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Recommended changes #2 > > src/java.base/share/classes/jdk/internal/misc/MainMethodFinder.java line 138: > >> 136:

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v9]

2023-05-05 Thread Rémi Forax
On Fri, 5 May 2023 17:08:35 GMT, Vicente Romero wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Recommended changes #2 > > src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java > line 3999: > >

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v10]

2023-05-05 Thread Jim Laskey
> Add flexible main methods and anonymous main classes to the Java language. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Typo - Changes: - all: https://git.openjdk.org/jdk/pull/13689/files - new: https://git.openjd

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v9]

2023-05-05 Thread Vicente Romero
On Fri, 5 May 2023 16:18:42 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > Recommended changes #2 src/java.base/share/clas

Re: RFR: 8307194: Enhance static-libs-image [v7]

2023-05-05 Thread Jiangli Zhou
On Fri, 5 May 2023 16:43:46 GMT, Jiangli Zhou wrote: >>> [...] I'll see if I can test this on a mandrel build tomorrow... >> >> @jianglizhou So I've tested this with a mandrel build and it doesn't break >> terribly, but a graalvm build after this patch has *two* `libjvm.a` which a) >> doesn't

Re: RFR: 8307194: Enhance static-libs-image [v7]

2023-05-05 Thread Jiangli Zhou
> This PR is branched from the makefile changes for > https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for > handling the JDK/VM static libraries: > > - Create libjvm.a together with other JDK static libraries when building > 'static-libs-image' (or 'static-libs-bundles')

Re: RFR: 8307194: Enhance static-libs-image [v6]

2023-05-05 Thread Jiangli Zhou
On Thu, 4 May 2023 19:12:14 GMT, Severin Gehwolf wrote: >> As @jerboaa mentioned, for GraalVM native-image we produce our own >> `libjvm.a` as part of building GraalVM (every native image gets statically >> linked to that library). See >> https://github.com/oracle/graal/blob/f1c1d710625ac84559

Re: RFR: 8307194: Enhance static-libs-image [v6]

2023-05-05 Thread Jiangli Zhou
> This PR is branched from the makefile changes for > https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for > handling the JDK/VM static libraries: > > - Create libjvm.a together with other JDK static libraries when building > 'static-libs-image' (or 'static-libs-bundles')

Re: RFR: 8307194: Enhance static-libs-image [v6]

2023-05-05 Thread Jiangli Zhou
> This PR is branched from the makefile changes for > https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for > handling the JDK/VM static libraries: > > - Create libjvm.a together with other JDK static libraries when building > 'static-libs-image' (or 'static-libs-bundles')

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v9]

2023-05-05 Thread Jim Laskey
> Add flexible main methods and anonymous main classes to the Java language. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Recommended changes #2 - Changes: - all: https://git.openjdk.org/jdk/pull/13689/files - new:

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v8]

2023-05-05 Thread Jim Laskey
On Fri, 5 May 2023 10:15:02 GMT, Jaikiran Pai wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Anonymous main classes renamed to unnamed classes >> - Add test > > src/jdk.compiler/share/classes/com/sun/tools/javac/

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v8]

2023-05-05 Thread Jim Laskey
On Fri, 5 May 2023 09:52:37 GMT, Jaikiran Pai wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Anonymous main classes renamed to unnamed classes >> - Add test > > src/java.base/share/classes/sun/launcher/LauncherHe

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v8]

2023-05-05 Thread Jim Laskey
On Fri, 5 May 2023 09:43:04 GMT, Jaikiran Pai wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Anonymous main classes renamed to unnamed classes >> - Add test > > src/java.base/share/classes/jdk/internal/misc/MainM

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v8]

2023-05-05 Thread Jim Laskey
On Fri, 5 May 2023 09:39:07 GMT, Jaikiran Pai wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Anonymous main classes renamed to unnamed classes >> - Add test > > src/java.base/share/classes/jdk/internal/misc/MainM

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v8]

2023-05-05 Thread Jim Laskey
On Fri, 5 May 2023 09:30:54 GMT, Jaikiran Pai wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Anonymous main classes renamed to unnamed classes >> - Add test > > src/java.base/share/classes/jdk/internal/misc/MainM

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v8]

2023-05-05 Thread Jim Laskey
On Fri, 5 May 2023 09:28:04 GMT, Jaikiran Pai wrote: >> Jim Laskey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Anonymous main classes renamed to unnamed classes >> - Add test > > src/java.base/share/classes/jdk/internal/misc/MainM

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots

2023-05-05 Thread Alexander Zvegintsev
On Fri, 5 May 2023 02:37:28 GMT, Sergey Bylokhov wrote: > > If the user wishes to change their mind about the screens allowed to be > > captured, the user should use the new Robot#resetScreenCapturePermission > > method > > Do we really need to add this new API? probably we can implement the f

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

2023-05-05 Thread Maxim Kartashev
On Fri, 5 May 2023 14:26:49 GMT, Alexander Zvegintsev wrote: > P.S. I removed synchronized modifier from getRGBPixels My main point was that you don't seem to need to have both, and while I picked one you picked the other ;-) So it's OK. >> src/java.desktop/unix/native/libawt_xawt/awt/screenca

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

2023-05-05 Thread Alexander Zvegintsev
On Thu, 4 May 2023 19:52:22 GMT, Erik Joelsson wrote: >> Alexander Zvegintsev has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - update, based on review comments >> - remove wayland detection >> - BUILD_LIBPIPEWIRE_HEADER_DIRS -> LIBP

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

2023-05-05 Thread Alexander Zvegintsev
> Modern Linux systems often come with > [Wayland](https://wayland.freedesktop.org/) by default. > This comes with some difficulties, and one of them is the inability to get > screenshots from the system. > This is because we now use the [X Window System > API](https://en.wikipedia.org/wiki/X_Wi

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

2023-05-05 Thread Alexander Zvegintsev
On Fri, 5 May 2023 09:33:00 GMT, Maxim Kartashev wrote: >> Alexander Zvegintsev has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - update, based on review comments >> - remove wayland detection >> - BUILD_LIBPIPEWIRE_HEADER_DIRS -> LI

RE: [EXTERNAL] Re: Compiler/aot testing on MacOS

2023-05-05 Thread Joe Braley
Hi David, Yes, this is still an issue our team is experiencing. Regards, Joe Braley -Original Message- From: David Holmes Sent: Friday, May 5, 2023 12:24 AM To: Joe Braley ; build-dev@openjdk.org Subject: [EXTERNAL] Re: Compiler/aot testing on MacOS [You don't often get email from davi

Re: RFR: 8307194: Enhance static-libs-image [v5]

2023-05-05 Thread Alan Bateman
On Thu, 4 May 2023 19:32:45 GMT, Jiangli Zhou wrote: >>> [...] I'll see if I can test this on a mandrel build tomorrow... >> >> @jianglizhou So I've tested this with a mandrel build and it doesn't break >> terribly, but a graalvm build after this patch has *two* `libjvm.a` which a) >> doesn't

Re: RFR: JDK-8306983: Do not invoke external programs when switch terminal to raw mode on selected platforms [v2]

2023-05-05 Thread Erik Joelsson
On Fri, 5 May 2023 12:34:29 GMT, Jan Lahoda wrote: >> To support JShell and other usecases, the JDK uses JLine, which provides >> line-editing functionality inside a terminal. >> >> JLine has several ways to work with the terminal, based on various >> additional libraries and tools. Most of th

Re: RFR: JDK-8306983: Do not invoke external programs when switch terminal to raw mode on selected platforms [v2]

2023-05-05 Thread Jan Lahoda
> To support JShell and other usecases, the JDK uses JLine, which provides > line-editing functionality inside a terminal. > > JLine has several ways to work with the terminal, based on various additional > libraries and tools. Most of them are not directly usable inside the JDK, so > currently

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v3]

2023-05-05 Thread Jim Laskey
On Thu, 27 Apr 2023 20:51:53 GMT, Maurizio Cimadamore wrote: >> Jim Laskey has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 14 commits: >> >> - Merge branch 'master' into 8306112 >> - PreviewFeatures.isEnabled() >> - Clean up i

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots

2023-05-05 Thread Maxim Kartashev
On Thu, 4 May 2023 14:18:44 GMT, Alexander Zvegintsev wrote: > Modern Linux systems often come with > [Wayland](https://wayland.freedesktop.org/) by default. > This comes with some difficulties, and one of them is the inability to get > screenshots from the system. > This is because we now use

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v8]

2023-05-05 Thread Jaikiran Pai
On Mon, 1 May 2023 13:06:24 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request incrementally with two additional > commits since the last revision: > > - Anonymous main classes renamed to unnamed clas

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v8]

2023-05-05 Thread Jaikiran Pai
On Mon, 1 May 2023 13:06:24 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request incrementally with two additional > commits since the last revision: > > - Anonymous main classes renamed to unnamed clas

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v8]

2023-05-05 Thread Jaikiran Pai
On Mon, 1 May 2023 13:06:24 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request incrementally with two additional > commits since the last revision: > > - Anonymous main classes renamed to unnamed clas

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v8]

2023-05-05 Thread Jaikiran Pai
On Mon, 1 May 2023 13:06:24 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request incrementally with two additional > commits since the last revision: > > - Anonymous main classes renamed to unnamed clas

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v8]

2023-05-05 Thread Jaikiran Pai
On Mon, 1 May 2023 13:06:24 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request incrementally with two additional > commits since the last revision: > > - Anonymous main classes renamed to unnamed clas

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v8]

2023-05-05 Thread Jaikiran Pai
On Mon, 1 May 2023 13:06:24 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request incrementally with two additional > commits since the last revision: > > - Anonymous main classes renamed to unnamed clas

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v8]

2023-05-05 Thread Jaikiran Pai
On Mon, 1 May 2023 13:06:24 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request incrementally with two additional > commits since the last revision: > > - Anonymous main classes renamed to unnamed clas

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v8]

2023-05-05 Thread Jaikiran Pai
On Mon, 1 May 2023 13:06:24 GMT, Jim Laskey wrote: >> Add flexible main methods and anonymous main classes to the Java language. > > Jim Laskey has updated the pull request incrementally with two additional > commits since the last revision: > > - Anonymous main classes renamed to unnamed clas

Re: RFR: 8307058: Implementation of Generational ZGC [v8]

2023-05-05 Thread Stefan Karlsson
> Hi all, > > Please review the implementation of Generational ZGC, which can be turned on > by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational > ZGC is a major rewrite of the non-generational ZGC version that exists in the > openjdk/jdk repository. It splits the heap i