> Please review changes to `EquivMapsGenerator.java` (which is used to generate
> the Locale equivalencies for the JDK).
>
> The file previously used large concatenated Strings, which are now replaced
> with text blocks, in addition to some cleanup. No functionality is changed,
> the Locale
On Thu, 11 May 2023 20:34:48 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Adjust new lines to appease jcheck?
>> - Review: remove new line literals for new lines
>> - Review: fix method / var
> Please review changes to `EquivMapsGenerator.java` (which is used to generate
> the Locale equivalencies for the JDK).
>
> The file previously used large concatenated Strings, which are now replaced
> with text blocks, in addition to some cleanup. No functionality is changed,
> the Locale
On Thu, 11 May 2023 20:21:57 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is adjusted to support reading in
On Thu, 11 May 2023 20:21:57 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is adjusted to support reading in
> This PR converts Unicode sequences to UTF-8 native in .properties file.
> (Excluding the Unicode space and tab sequence). The conversion was done using
> native2ascii.
>
> In addition, the build logic is adjusted to support reading in the
> .properties files as UTF-8 during the conversion
On Thu, 11 May 2023 15:40:50 GMT, Justin Lu wrote:
> Please review changes to `EquivMapsGenerator.java` (which is used to generate
> the Locale equivalencies for the JDK).
>
> The file previously used large concatenated Strings, which are now replaced
> with text blocks, in addition to some
On Thu, 11 May 2023 14:17:56 GMT, Jan Lahoda wrote:
>> To support JShell and other usecases, the JDK uses JLine, which provides
>> line-editing functionality inside a terminal.
>>
>> JLine has several ways to work with the terminal, based on various
>> additional libraries and tools. Most of
On Thu, 11 May 2023 15:15:02 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflecting review feedback.
>
>
On Thu, 11 May 2023 14:17:56 GMT, Jan Lahoda wrote:
>> To support JShell and other usecases, the JDK uses JLine, which provides
>> line-editing functionality inside a terminal.
>>
>> JLine has several ways to work with the terminal, based on various
>> additional libraries and tools. Most of
Please review changes to `EquivMapsGenerator.java` (which is used to generate
the Locale equivalencies for the JDK).
The file previously used large concatenated Strings, which are now replaced
with text blocks, in addition to some cleanup. No functionality is changed,
`EquivMapsGenerator.java`
On Thu, 11 May 2023 13:27:44 GMT, JoKern65 wrote:
> In the compile flags, set the minimum supported CPU architecture to Power8 on
> AIX, because we do not want to support pwr7 architecture any more.
Marked as reviewed by erikj (Reviewer).
-
PR Review:
> To support JShell and other usecases, the JDK uses JLine, which provides
> line-editing functionality inside a terminal.
>
> JLine has several ways to work with the terminal, based on various additional
> libraries and tools. Most of them are not directly usable inside the JDK, so
>
On Wed, 10 May 2023 21:59:37 GMT, Phil Race wrote:
> > It is not for the "we have all permissions" case, it is for the case when
> > we only have a permission to some screens. So it won't hurt.
>
> But how does the app know when to call it ?
Right now it doesn't know. If the user is not
On Wed, 10 May 2023 13:52:50 GMT, JoKern65 wrote:
>> The new xlc17 compiler should be supported to build OpenJDK on AIX. This
>> compiler, compared to the currently supported xlc16, has a significantly
>> more recent clang (xlc 17.1.1 uses clang 15) included.
>> 1. Because the frontend
On Thu, 11 May 2023 12:12:56 GMT, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review the implementation of Generational ZGC, which can be turned on
>> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
>> ZGC is a major rewrite of the non-generational ZGC version
On Wed, 3 May 2023 09:04:50 GMT, Stefan Karlsson wrote:
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that
On Thu, 11 May 2023 13:27:44 GMT, JoKern65 wrote:
> In the compile flags, set the minimum supported CPU architecture to Power8 on
> AIX, because we do not want to support pwr7 architecture any more.
LGTM
I would recommend to enable the PR also for our nightly makes to check the flag
in the
In the compile flags, set the minimum supported CPU architecture to Power8 on
AIX, because we do not want to support pwr7 architecture any more.
-
Commit messages:
- accidentially changed mode bits
- JDK-8307520
Changes: https://git.openjdk.org/jdk/pull/13933/files
Webrev:
On Thu, 11 May 2023 13:27:44 GMT, JoKern65 wrote:
> In the compile flags, set the minimum supported CPU architecture to Power8 on
> AIX, because we do not want to support pwr7 architecture any more.
Now Pwr8 should be the minimum hardware on AIX to run jdk
-
PR Comment:
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap
> Hi all,
>
> Please review the implementation of Generational ZGC, which can be turned on
> by adding -XX:+ZGenerational in addition to using -XX:+UseZGC. Generational
> ZGC is a major rewrite of the non-generational ZGC version that exists in the
> openjdk/jdk repository. It splits the heap
> Add flexible main methods and anonymous main classes to the Java language.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Update VirtualParser.java
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13689/files
-
> Add flexible main methods and anonymous main classes to the Java language.
Jim Laskey has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 26 commits:
- Merge branch 'master' into 8306112
- Refactor source code launcher
- Typo
-
On Wed, 10 May 2023 11:01:24 GMT, JoKern65 wrote:
> The new xlc17 compiler should be supported to build OpenJDK on AIX. This
> compiler, compared to the currently supported xlc16, has a significantly more
> recent clang (xlc 17.1.1 uses clang 15) included.
> 1. Because the frontend interface
On Tue, 9 May 2023 20:49:16 GMT, Brian Burkhalter wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adjusting build script as suggested on the review.
>
> src/jdk.internal.le/linux/native/lible/CLibrary.cpp line 183:
26 matches
Mail list logo
