On Tue, 16 May 2023 17:16:57 GMT, Chen Liang wrote:
>> `@sealedGraph` had a mechanism to render non-sealed classes differently, but
>> it's useless because the graph nodes are not bordered. This patch converts
>> the non-sealed classes to be rendered in italics instead.
>>
>> An example of `Co
> Hi,
>
> This is a redo of JDK-8307855, where issues were found after integration.
>
> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because
> of security concerns. The issue was addressed in
> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building
> fa
On Wed, 17 May 2023 03:26:45 GMT, Kim Barrett wrote:
> This and all uses of snprintf in this change are incorrect. If the output is
> truncated, snprintf returns the number of characters that would have been
> written if there had been enough space. That is, the result may be larger
> than buf
On Tue, 16 May 2023 16:54:47 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> This is a redo of JDK-8307855, where issues were found after integration.
>>
>> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because
>> of security concerns. The issue was addressed in
>> [JDK-829
On Tue, 16 May 2023 16:49:27 GMT, Xue-Lei Andrew Fan wrote:
>> src/utils/hsdis/binutils/hsdis-binutils.c line 248:
>>
>>> 246: size_t used_size = strlen(close);
>>> 247: char* p = buf + used_size;
>>> 248: bufsize -= used_size;
>>
>> May not happen in practice, but if `used_size` is large
On Mon, 15 May 2023 17:05:48 GMT, Jim Laskey wrote:
> InstanceMainTest does check precedence. Are you expecting a test for all
> combinations?
Sorry, we discussed this in previous comments, ignore my latest comment on this.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/136
> Add flexible main methods and anonymous main classes to the Java language.
Jim Laskey has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 29 commits:
- Merge branch 'master' into 8306112
- Requested Changes #2
- Update VirtualParser.
On Mon, 15 May 2023 08:38:54 GMT, Adam Sotona wrote:
> Package `jdk.internal.classfile.java.lang.constant` containing `ModuleDesc`
> and `PackageDesc` become obsolete after
> [JDK-8306729](https://bugs.openjdk.org/browse/JDK-8306729).
> All references to `jdk.internal.classfile.java.lang.const
On Mon, 15 May 2023 06:46:28 GMT, Per Minborg wrote:
>> `@sealedGraph` had a mechanism to render non-sealed classes differently, but
>> it's useless because the graph nodes are not bordered. This patch converts
>> the non-sealed classes to be rendered in italics instead.
>>
>> An example of `C
> `@sealedGraph` had a mechanism to render non-sealed classes differently, but
> it's useless because the graph nodes are not bordered. This patch converts
> the non-sealed classes to be rendered in italics instead.
>
> An example of `ConstantDesc`, which has a sealed hierarchy except
> `Dynami
On Mon, 15 May 2023 21:47:19 GMT, Mikael Vidstedt wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> replace strcpy with snprintf
>
> src/utils/hsdis/binutils/hsdis-binutils.c line 248:
>
>> 246: size_t used_
> Hi,
>
> This is a redo of JDK-8307855, where issues were found after integration.
>
> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because
> of security concerns. The issue was addressed in
> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building
> fa
On Mon, 15 May 2023 12:25:29 GMT, Martin Doerr wrote:
>> What is the warning here? Note that we've already turned off
>> `-Wshift-negative-value` for gcc and xlc
>> (but not for clang, for some reason). See `# Disabled warnings` in
>> CompileJvm.gmk.
>
> I think disabling the warning is fine.
13 matches
Mail list logo
