Withdrawn: JDK-8305090: Some NMT tests broken when running under ASan

2023-05-31 Thread duke
On Tue, 28 Mar 2023 15:05:41 GMT, Justin King wrote: > This change fixes or skips some NMT tests when running under ASan, as well as > fixing a leak. > > - `allocator_may_return_null=1` is added as the default is `0`, meaning ASan > will never return `nullptr` and will instead crash. NMT

Re: RFR: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM [v2]

2023-05-31 Thread David Holmes
On Wed, 31 May 2023 15:27:51 GMT, Gerard Ziemski wrote: > You have chosen to use an OS independent mechanism, at the cost of exposing > the implementation to the outside world, by introducing a new stage (needs > CSR). That is not an accurate characterisation of this change. The CSR request

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Phil Race
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Andrey Turbanov
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Andrey Turbanov
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Andrey Turbanov
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Andrey Turbanov
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Andrey Turbanov
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we

Re: RFR: JDK-8306584: Start of release updates for JDK 22 [v3]

2023-05-31 Thread Joe Darcy
On Wed, 31 May 2023 18:02:09 GMT, Jan Lahoda wrote: >> Joe Darcy has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 24 commits: >> >> - Merge branch 'master' into JDK-8306584 >> - Merge branch 'master' into JDK-8306584 >> - Merge

Re: RFR: JDK-8306584: Start of release updates for JDK 22 [v4]

2023-05-31 Thread Joe Darcy
> Time to get JDK 22 underway... Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 26 commits: - Respond to review comments. - Merge branch 'master' into JDK-8306584 - Merge branch 'master' into JDK-8306584 - Merge branch

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code [v2]

2023-05-31 Thread Phil Race
On Fri, 26 May 2023 08:31:46 GMT, JoKern65 wrote: >> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk >> on AIX , we run into various "warnings as errors". >> Some of those are in shared codebase and could be addressed by small >> adjustments. >> A lot of those

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Phil Race
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we

Re: RFR: JDK-8306584: Start of release updates for JDK 22 [v3]

2023-05-31 Thread Jan Lahoda
On Tue, 30 May 2023 22:16:08 GMT, Joe Darcy wrote: >> Time to get JDK 22 underway... > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 24 commits: > > - Merge branch 'master' into JDK-8306584 > - Merge branch

Re: RFR: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM [v2]

2023-05-31 Thread Gerard Ziemski
On Tue, 30 May 2023 14:39:21 GMT, Gerard Ziemski wrote: >>> I have one question though: why wouldn't it be enough to move `vm_created = >>> 1` from where we had it before, down to where we now have `vm_created = >>> COMPLETE` ? >> >> Because we need to prevent two threads from concurrently

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v8]

2023-05-31 Thread Alexander Zvegintsev
On Tue, 30 May 2023 19:33:20 GMT, Phil Race wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix macos build > > src/java.desktop/unix/classes/sun/awt/screencast/ScreencastHelper.java line > 139: > >>

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Alexander Zvegintsev
> Modern Linux systems often come with > [Wayland](https://wayland.freedesktop.org/) by default. > This comes with some difficulties, and one of them is the inability to get > screenshots from the system. > This is because we now use the [X Window System >

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v24]

2023-05-31 Thread Jim Laskey
> Add flexible main methods and anonymous main classes to the Java language. Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 40 commits: - Merge branch 'master' into 8306112 - Remove mandated flag - Remove trailing

Re: RFR: JDK-8306112 Implementation of JEP 445: Unnamed Classes and Instance Main Methods (Preview) [v23]

2023-05-31 Thread Jim Laskey
> Add flexible main methods and anonymous main classes to the Java language. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Remove mandated flag - Changes: - all: https://git.openjdk.org/jdk/pull/13689/files - new:

Integrated: 8309048: Remove malloc locker test case

2023-05-31 Thread Leo Korinth
On Mon, 29 May 2023 13:14:24 GMT, Leo Korinth wrote: > There is a bunch of tests that are used to test critical section/gc locker. > One of the test is named malloc. In that test, JNI code is doing a loop of > `malloc()` followed `sleep()` followed by a `free()`. There is no JVM lock >

Re: RFR: 8309048: Remove malloc locker test case

2023-05-31 Thread Leo Korinth
On Mon, 29 May 2023 13:14:24 GMT, Leo Korinth wrote: > There is a bunch of tests that are used to test critical section/gc locker. > One of the test is named malloc. In that test, JNI code is doing a loop of > `malloc()` followed `sleep()` followed by a `free()`. There is no JVM lock >

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code [v2]

2023-05-31 Thread JoKern65
On Tue, 30 May 2023 21:44:17 GMT, JoKern65 wrote: >> src/hotspot/share/runtime/javaThread.cpp line 115: >> >>> 113: #include >>> 114: #endif >>> 115: >> >> Could these conditionals be included in globalDefinitions_xlc.hpp instead? > > In principle the `#include ` could be included in >

Re: RFR: JDK-8306584: Start of release updates for JDK 22 [v3]

2023-05-31 Thread David Holmes
On Tue, 30 May 2023 22:16:08 GMT, Joe Darcy wrote: >> Time to get JDK 22 underway... > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 24 commits: > > - Merge branch 'master' into JDK-8306584 > - Merge branch