Withdrawn: 8309934: Update GitHub Actions to use JDK 17 for building jtreg

2023-06-14 Thread Christian Stein
On Wed, 14 Jun 2023 10:07:01 GMT, Christian Stein wrote: > Hi all, > > This pull request contains a backport of commit > [8aad881e](https://github.com/openjdk/jdk/commit/8aad881e803fddc26f45270f779ff0c0e5a095d8) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit

Re: RFR: 8309934: Update GitHub Actions to use JDK 17 for building jtreg [v2]

2023-06-14 Thread Christian Stein
On Wed, 14 Jun 2023 18:45:04 GMT, Christian Stein wrote: >> Hi all, >> >> This pull request contains a backport of commit >> [8aad881e](https://github.com/openjdk/jdk/commit/8aad881e803fddc26f45270f779ff0c0e5a095d8) >> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The

Re: RFR: 8309934: Update GitHub Actions to use JDK 17 for building jtreg [v2]

2023-06-14 Thread Christian Stein
> Hi all, > > This pull request contains a backport of commit > [8aad881e](https://github.com/openjdk/jdk/commit/8aad881e803fddc26f45270f779ff0c0e5a095d8) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Christian Stein on 13 Jun

Re: RFR: 8309934: Update GitHub Actions to use JDK 17 for building jtreg

2023-06-14 Thread Martin Doerr
On Wed, 14 Jun 2023 10:07:01 GMT, Christian Stein wrote: > Hi all, > > This pull request contains a backport of commit > [8aad881e](https://github.com/openjdk/jdk/commit/8aad881e803fddc26f45270f779ff0c0e5a095d8) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit

Re: RFR: 8309934: Update GitHub Actions to use JDK 17 for building jtreg

2023-06-14 Thread Christian Stein
On Wed, 14 Jun 2023 12:39:00 GMT, Martin Doerr wrote: > Could you enable GitHub Actions and run the tests, please? I enabled workflows on the fork the bot created for me - how do I trigger a run now? Manually via https://github.com/openjdk-bots/jdk21/actions/workflows/main.yml and use the def

Integrated: 8309746: Reconfigure check should include make/conf/version-numbers.conf

2023-06-14 Thread Erik Joelsson
On Tue, 13 Jun 2023 21:15:29 GMT, Erik Joelsson wrote: > When we bump the JDK version, we need to reconfigure to get a working build. > Users were reporting that this didn't happen automatically, or wasn't warned > about, after pulling down that change. This patch addresses that by adding > th

Integrated: 8308585: AC_REQUIRE: `PLATFORM_EXTRACT_TARGET_AND_BUILD' was expanded before it was required

2023-06-14 Thread Erik Joelsson
On Tue, 13 Jun 2023 21:47:28 GMT, Erik Joelsson wrote: > Autoconf is emitting this warning after > [JDK-8307573](https://bugs.openjdk.org/browse/JDK-8307573): > > stdin:85: warning: AC_REQUIRE: `PLATFORM_EXTRACT_TARGET_AND_BUILD' was > expanded before it was required > stdin:85: > http://www.

Re: RFR: 8309934: Update GitHub Actions to use JDK 17 for building jtreg

2023-06-14 Thread Martin Doerr
On Wed, 14 Jun 2023 10:07:01 GMT, Christian Stein wrote: > Hi all, > > This pull request contains a backport of commit > [8aad881e](https://github.com/openjdk/jdk/commit/8aad881e803fddc26f45270f779ff0c0e5a095d8) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit

Integrated: 8309880: Add support for linking libffi on Windows and Mac

2023-06-14 Thread Jorn Vernee
On Tue, 13 Jun 2023 12:48:12 GMT, Jorn Vernee wrote: > Update the make/autoconf/lib-ffi.m4 script to support using libffi on Windows > and Mac. > > For Windows I had to tweak `fallbackLinker.c` to be able to build: there was > an import of `stdint.h` missing, and since it was using `WSAGetLast

Re: RFR: JDK-8309934: Update GitHub Actions to use JDK 17 for building jtreg [v2]

2023-06-14 Thread Thomas Stuefe
On Wed, 14 Jun 2023 10:04:43 GMT, Christian Stein wrote: > > Will you downport this to JDK 17 too? > > No. JDK 17 is archived and it uses JDK 8 to build jtreg within a single-file > workflow definition: > > * > https://github.com/openjdk/jdk17/blob/master/.github/workflows/submit.yml#L88

RFR: 8309934: Update GitHub Actions to use JDK 17 for building jtreg

2023-06-14 Thread Christian Stein
Hi all, This pull request contains a backport of commit [8aad881e](https://github.com/openjdk/jdk/commit/8aad881e803fddc26f45270f779ff0c0e5a095d8) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Christian Stein on 13 Jun 2023 and was

Re: RFR: JDK-8309934: Update GitHub Actions to use JDK 17 for building jtreg [v2]

2023-06-14 Thread Christian Stein
On Wed, 14 Jun 2023 09:49:33 GMT, Thomas Stuefe wrote: > Do you know why this helped? No, unfortunately not: _"Switching from 11 to 17 seems to mend the (unknown underlying) issue for the time being."_ A test build using the same JDK as pre-installed on GitHub-hosted runners on my local machin

Re: RFR: JDK-8309934: Update GitHub Actions to use JDK 17 for building jtreg [v2]

2023-06-14 Thread Thomas Stuefe
On Tue, 13 Jun 2023 13:52:53 GMT, Christian Stein wrote: >> Please review this change to use the pre-installed JDK 17 for building jtreg >> when running on GitHub Actions. > > Christian Stein has updated the pull request incrementally with one > additional commit since the last revision: > >