Re: [jdk21] RFR: 8310259: Pin msys2/setup-msys2 github action to a specific commit

2023-06-19 Thread Jaikiran Pai
On Mon, 19 Jun 2023 11:39:21 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which backports the fixes for > https://bugs.openjdk.org/browse/JDK-8310259? > > This wasn't a clean backport because this also brings in > https://bugs.openjdk.org/browse/JDK-8309934 which in

[jdk21] Integrated: 8310259: Pin msys2/setup-msys2 github action to a specific commit

2023-06-19 Thread Jaikiran Pai
On Mon, 19 Jun 2023 11:39:21 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which backports the fixes for > https://bugs.openjdk.org/browse/JDK-8310259? > > This wasn't a clean backport because this also brings in > https://bugs.openjdk.org/browse/JDK-8309934 which in

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-19 Thread Anthony Scarpino
On Tue, 13 Jun 2023 20:36:28 GMT, Anthony Scarpino wrote: > Hi, > > I need a code review for moving the contents of the jdk.crypto.ec module into > java.base. This moves the SunEC JCE Provider (Elliptic Curve) into > java.base. EC has always been separate from the base module/pkg because

Re: RFR: JDK-8310321: make JDKOPT_CHECK_CODESIGN_PARAMS more verbose

2023-06-19 Thread Matthias Baesken
On Mon, 19 Jun 2023 14:08:34 GMT, Matthias Baesken wrote: > We were running into some issues with the configure checks checking the > codesign tool. Unfortunately the output is a bit limited and should be > enhanced, especially printing what is really called. A related question, maybe someone

RFR: JDK-8310321: make JDKOPT_CHECK_CODESIGN_PARAMS more verbose

2023-06-19 Thread Matthias Baesken
We were running into some issues with the configure checks checking the codesign tool. Unfortunately the output is a bit limited and should be enhanced, especially printing what is really called. - Commit messages: - JDK-8310321 Changes:

Re: RFR: 8310259: Pin msys2/setup-msys2 github action to a specific commit

2023-06-19 Thread Christoph Langer
On Mon, 19 Jun 2023 11:39:21 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which backports the fixes for > https://bugs.openjdk.org/browse/JDK-8310259? > > This wasn't a clean backport because this also brings in > https://bugs.openjdk.org/browse/JDK-8309934 which in

Re: RFR: 8310306: Pin msys2/setup-msys2 github action to a specific commit

2023-06-19 Thread Christoph Langer
On Mon, 19 Jun 2023 11:39:21 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which backports the fixes for > https://bugs.openjdk.org/browse/JDK-8310259? > > This wasn't a clean backport because this also brings in > https://bugs.openjdk.org/browse/JDK-8309934 which in

Re: RFR: 8310306: Pin msys2/setup-msys2 github action to a specific commit

2023-06-19 Thread Christian Stein
On Mon, 19 Jun 2023 11:39:21 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which backports the fixes for > https://bugs.openjdk.org/browse/JDK-8310259? > > This wasn't a clean backport because this also brings in > https://bugs.openjdk.org/browse/JDK-8309934 which in

RFR: 8310306: Pin msys2/setup-msys2 github action to a specific commit

2023-06-19 Thread Jaikiran Pai
Can I please get a review of this change which backports the fixes for https://bugs.openjdk.org/browse/JDK-8310259? This wasn't a clean backport because this also brings in https://bugs.openjdk.org/browse/JDK-8309934 which in theory isn't a must-have change, but I think it's good to have these

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-19 Thread Alan Bateman
On Mon, 19 Jun 2023 05:46:34 GMT, Anthony Scarpino wrote: > From what I was told, the native library was one of the reasons it was not in > the base pkg before modularization and just remained so afterwards. Maybe you are thinking about the size of libsunec or non-technical issues that meant