On Wed, 2 Aug 2023 06:54:36 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8313274?
>
> The commit in this PR reverts the commit that was introduced in
> https://github.com/openjdk/jdk/pull/14561. Martin, in the
Hi all,
This pull request contains a backport of commit
[8248e351](https://github.com/openjdk/jdk/commit/8248e351d0bed263fb68d8468004a4286e6391af)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Sergey Bylokhov on 2 Aug 2023 and
was
On Wed, 2 Aug 2023 23:55:24 GMT, Sergey Bylokhov wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [8248e351](https://github.com/openjdk/jdk/commit/8248e351d0bed263fb68d8468004a4286e6391af)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
On Wed, 2 Aug 2023 19:15:24 GMT, Matias Saavedra Silva
wrote:
> The recent change in
> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more
> -Wconversion warnings that are addressed in this patch. The aforementioned
> change has overlooked inconsistencies with the types
On Wed, 2 Aug 2023 02:01:44 GMT, Sergey Bylokhov wrote:
> One warning is disabled for the freetype.
This pull request has now been integrated.
Changeset: 8248e351
Author:Sergey Bylokhov
URL:
https://git.openjdk.org/jdk/commit/8248e351d0bed263fb68d8468004a4286e6391af
Stats: 2
Introducing a new formatting class for locale-dependent list patterns. The
class is to provide the functionality from the Unicode Consortium's LDML
specification for [list
patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns).
For example, given a list of String as
On Wed, 28 Jun 2023 18:53:12 GMT, Tim Prinzing wrote:
>> The socket read/write JFR events currently use instrumentation of java.base
>> code using templates in the jdk.jfr modules. This results in some java.base
>> code residing in the jdk.jfr module which is undesirable.
>>
>> JDK19 added
On Wed, 2 Aug 2023 20:18:04 GMT, Sergey Bylokhov wrote:
>> One warning is disabled for the freetype.
>
> Sergey Bylokhov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> add comment about gcc 7
Marked as reviewed by prr (Reviewer).
The recent change in [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996)
added more -Wconversion warnings that are addressed in this patch. The
aforementioned change has overlooked inconsistencies with the types used by
`ResolvedFieldEntry` and the method `fill_in()`. Verified with tier
> One warning is disabled for the freetype.
Sergey Bylokhov has updated the pull request incrementally with one additional
commit since the last revision:
add comment about gcc 7
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15116/files
- new:
On Wed, 2 Aug 2023 18:19:27 GMT, Tim Prinzing wrote:
> I believe this has all requested changes or has separate bug reports to
> address changes yet needing to be made.
> https://bugs.openjdk.org/browse/JDK-8310979 - better exception handling
> https://bugs.openjdk.org/browse/JDK-8310978 -
On Wed, 2 Aug 2023 19:00:05 GMT, Sergey Bylokhov wrote:
>> One warning is disabled for the freetype.
>
> Sergey Bylokhov has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - DISABLED_WARNINGS_gcc_ftobjs.c
> - Revert "8313576: GCC 7 reports
Fuvj you
Le mer. 2 août 2023, 21:01, Sergey Bylokhov a écrit :
> On Wed, 2 Aug 2023 02:01:44 GMT, Sergey Bylokhov wrote:
>
> > One warning is disabled for the freetype.
>
> Tested with "--with-freetype=bundled", "--with-freetype=system" and w/o
> option.
>
> -
>
> PR Comment:
On Wed, 2 Aug 2023 18:54:31 GMT, Sergey Bylokhov wrote:
>> One warning is disabled for the freetype.
>
> Sergey Bylokhov has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - DISABLED_WARNINGS_gcc_ftobjs.c
> - Revert "8313576: GCC 7 reports
> One warning is disabled for the freetype.
Sergey Bylokhov has updated the pull request incrementally with two additional
commits since the last revision:
- DISABLED_WARNINGS_gcc_ftobjs.c
- Revert "8313576: GCC 7 reports some compiler warnings in bundled freetype
2.13.0"
This reverts
On Wed, 2 Aug 2023 02:01:44 GMT, Sergey Bylokhov wrote:
> One warning is disabled for the freetype.
Tested with "--with-freetype=bundled", "--with-freetype=system" and w/o option.
-
PR Comment: https://git.openjdk.org/jdk/pull/15116#issuecomment-1662789955
On Wed, 2 Aug 2023 18:21:00 GMT, Aleksey Shipilev wrote:
>> One warning is disabled for the freetype.
>
> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 456:
>
>> 454: EXTRA_HEADER_DIRS := $(BUILD_LIBFREETYPE_HEADER_DIRS), \
>> 455: DISABLED_WARNINGS_microsoft := 4267 4244
On Wed, 2 Aug 2023 02:01:44 GMT, Sergey Bylokhov wrote:
> One warning is disabled for the freetype.
It looks fine, but I have a question that might make the fix more precise:
make/modules/java.desktop/lib/Awt2dLibraries.gmk line 456:
> 454: EXTRA_HEADER_DIRS :=
On Wed, 28 Jun 2023 18:53:12 GMT, Tim Prinzing wrote:
>> The socket read/write JFR events currently use instrumentation of java.base
>> code using templates in the jdk.jfr modules. This results in some java.base
>> code residing in the jdk.jfr module which is undesirable.
>>
>> JDK19 added
On Wed, 2 Aug 2023 15:20:55 GMT, Andreas Steiner wrote:
>> Add the default include location(/opt/freeware/include/) for cups on AIX.
>> With this set the additional configure parameter --with-cups-include can be
>> removed, which was needed on AIX.
>
> Andreas Steiner has updated the pull
> Add the default include location(/opt/freeware/include/) for cups on AIX.
> With this set the additional configure parameter --with-cups-include can be
> removed, which was needed on AIX.
Andreas Steiner has updated the pull request incrementally with one additional
commit since the last
On Tue, 1 Aug 2023 12:50:47 GMT, Andreas Steiner wrote:
>> Add the default include location(/opt/freeware/include/) for cups on AIX.
>> With this set the additional configure parameter --with-cups-include can be
>> removed, which was needed on AIX.
>
> Andreas Steiner has updated the pull
On Tue, 1 Aug 2023 14:37:18 GMT, Christoph Langer wrote:
> Currently, if somebody sets both, --with-cups= and --with-cups-include,
> with-cups-include gets precedence. The problem is only theoretical
The default for with-cups-include on AIX will be set only if --with-cups is not
set. See my
On Wed, 2 Aug 2023 06:54:36 GMT, Jaikiran Pai wrote:
> tier testing is currently in progress with this change.
tier1, tier2 and tier3 tests have passed with this change.
-
PR Comment: https://git.openjdk.org/jdk/pull/15118#issuecomment-1661821594
Currently, RISC-V differs from other platforms in that it requires the linkage
to libatomic.so to support sub-word atomic operations. However, because it is
linked dynamically, it will depend on the installation of libatomic.so on the
system where the Java application will run, which no other
Can I please get a review of this change which proposes to fix
https://bugs.openjdk.org/browse/JDK-8313274?
The commit in this PR reverts the commit that was introduced in
https://github.com/openjdk/jdk/pull/14561. Martin, in the 8313274 JBS issue,
notes that the failure started happening
On Wed, 2 Aug 2023 05:24:28 GMT, David Holmes wrote:
> @jaikiran I would concur - back out the change that caused the problem.
Hello David, I have now opened a PR to revert that change
https://github.com/openjdk/jdk/pull/15118
-
PR Comment:
27 matches
Mail list logo
