On Thu, 3 Aug 2023 20:53:56 GMT, Matias Saavedra Silva
wrote:
>> The recent change in
>> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more
>> -Wconversion warnings that are addressed in this patch. The aforementioned
>> change has overlooked inconsistencies with the types
On Thu, 3 Aug 2023 19:15:30 GMT, Coleen Phillimore wrote:
>> As far as I've designed it, only the last two bits of the flags are ever set
>> or used. C++ booleans are either 0 or 1 so the higher bits should never be
>> set.
>
> It is only two bits and the only variable here "is_final_shift" is
On Thu, 3 Aug 2023 20:53:56 GMT, Matias Saavedra Silva
wrote:
>> The recent change in
>> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more
>> -Wconversion warnings that are addressed in this patch. The aforementioned
>> change has overlooked inconsistencies with the types
> The recent change in
> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more
> -Wconversion warnings that are addressed in this patch. The aforementioned
> change has overlooked inconsistencies with the types used by
> `ResolvedFieldEntry` and the method `fill_in()`. Verified
On Wed, 2 Aug 2023 06:55:40 GMT, Ludovic Henry wrote:
> Currently, RISC-V differs from other platforms in that it requires the
> linkage to libatomic.so to support sub-word atomic operations. However,
> because it is linked dynamically, it will depend on the installation of
> libatomic.so on
On Wed, 2 Aug 2023 06:55:40 GMT, Ludovic Henry wrote:
> Currently, RISC-V differs from other platforms in that it requires the
> linkage to libatomic.so to support sub-word atomic operations. However,
> because it is linked dynamically, it will depend on the installation of
> libatomic.so on
On Thu, 3 Aug 2023 16:16:12 GMT, Matias Saavedra Silva
wrote:
>> I still don't see the point of using checked_cast if we know that this is
>> only two bits.
>
> As far as I've designed it, only the last two bits of the flags are ever set
> or used. C++ booleans are either 0 or 1 so the higher
We don't need the fully bootable Debian installation to build against.
Therefore, we can bootstrap with `--variant=minbase`. The sysroots are about
5..10% smaller then.
This would also make our builds more immune to issues like
[JDK-8313701](https://bugs.openjdk.org/browse/JDK-8313701). Note
> Hi please consider.
>
> This works with 2.30, 2.34, 2.38, 2.39, 2.40, 2.41 and current master head.
> (tested x64 and some RV)
>
> There are 4 changes in binutils we work around.
> - zstd compressed debug sections
> - libsframe added
> - init_disassemble_info() change
> - libbfd.a is only
On Wed, 2 Aug 2023 23:55:24 GMT, Sergey Bylokhov wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [8248e351](https://github.com/openjdk/jdk/commit/8248e351d0bed263fb68d8468004a4286e6391af)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
On Thu, 3 Aug 2023 11:48:43 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/oops/resolvedFieldEntry.hpp line 106:
>>
>>> 104: void set_flags(bool is_final, bool is_volatile) {
>>> 105: int new_flags = (is_final << is_final_shift) |
>>> static_cast(is_volatile);
>>> 106: _flags =
On Thu, 3 Aug 2023 11:42:47 GMT, Alan Bateman wrote:
>JDK 21 is in RDP2 so only P1/P2 with approval. Maybe you want to target jdk21u
>instead.
Yeah, for some reason I thought that rdp2 accepting tests, docs and build
breakages.
-
PR Comment:
On Thu, 3 Aug 2023 12:48:50 GMT, Robbin Ehn wrote:
> Hi please consider.
>
> This works with 2.30, 2.34, 2.38, 2.39, 2.40, 2.41 and current master head.
> (tested x64 and some RV)
>
> There are 4 changes in binutils we work around.
> - zstd compressed debug sections
> - libsframe added
> -
Hi please consider.
This works with 2.30, 2.34, 2.38, 2.39, 2.40, 2.41 and current master head.
(tested x64 and some RV)
There are 4 changes in binutils we work around.
- zstd compressed debug sections
- libsframe added
- init_disassemble_info() change
- libbfd.a is only present in .lib
On Thu, 3 Aug 2023 09:05:12 GMT, Dean Long wrote:
>> The recent change in
>> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more
>> -Wconversion warnings that are addressed in this patch. The aforementioned
>> change has overlooked inconsistencies with the types used by
>>
On Wed, 2 Aug 2023 23:55:24 GMT, Sergey Bylokhov wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [8248e351](https://github.com/openjdk/jdk/commit/8248e351d0bed263fb68d8468004a4286e6391af)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
On Wed, 2 Aug 2023 06:55:40 GMT, Ludovic Henry wrote:
> Currently, RISC-V differs from other platforms in that it requires the
> linkage to libatomic.so to support sub-word atomic operations. However,
> because it is linked dynamically, it will depend on the installation of
> libatomic.so on
On Wed, 2 Aug 2023 23:55:24 GMT, Sergey Bylokhov wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [8248e351](https://github.com/openjdk/jdk/commit/8248e351d0bed263fb68d8468004a4286e6391af)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
On Thu, 3 Aug 2023 08:16:55 GMT, Andreas Steiner wrote:
>> Add the default include location(/opt/freeware/include/) for cups on AIX.
>> With this set the additional configure parameter --with-cups-include can be
>> removed, which was needed on AIX.
>
> Andreas Steiner has updated the pull
On Wed, 2 Aug 2023 19:15:24 GMT, Matias Saavedra Silva
wrote:
> The recent change in
> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more
> -Wconversion warnings that are addressed in this patch. The aforementioned
> change has overlooked inconsistencies with the types
On Wed, 2 Aug 2023 19:15:24 GMT, Matias Saavedra Silva
wrote:
> The recent change in
> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more
> -Wconversion warnings that are addressed in this patch. The aforementioned
> change has overlooked inconsistencies with the types
On Thu, 3 Aug 2023 08:16:55 GMT, Andreas Steiner wrote:
>> Add the default include location(/opt/freeware/include/) for cups on AIX.
>> With this set the additional configure parameter --with-cups-include can be
>> removed, which was needed on AIX.
>
> Andreas Steiner has updated the pull
> Add the default include location(/opt/freeware/include/) for cups on AIX.
> With this set the additional configure parameter --with-cups-include can be
> removed, which was needed on AIX.
Andreas Steiner has updated the pull request incrementally with one additional
commit since the last
On Wed, 2 Aug 2023 06:54:36 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8313274?
>
> The commit in this PR reverts the commit that was introduced in
> https://github.com/openjdk/jdk/pull/14561. Martin, in the
On Wed, 2 Aug 2023 19:15:24 GMT, Matias Saavedra Silva
wrote:
> The recent change in
> [JDK-8301996](https://bugs.openjdk.org/browse/JDK-8301996) added more
> -Wconversion warnings that are addressed in this patch. The aforementioned
> change has overlooked inconsistencies with the types
On Wed, 2 Aug 2023 06:54:36 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8313274?
>
> The commit in this PR reverts the commit that was introduced in
> https://github.com/openjdk/jdk/pull/14561. Martin, in the
26 matches
Mail list logo