Re: RFR: 8314166: Update googletest to v1.14.0

2023-08-12 Thread Thomas Stuefe
On Fri, 11 Aug 2023 22:24:00 GMT, Mikael Vidstedt wrote: > As part of the ongoing work to enable -Wconversion with gcc there are a > number of occurrences of code in the GoogleTest code itself which need > fixing. These have been addressed in version 1.14.0 of GoogleTest. This > change is pick

Re: RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds [v6]

2023-08-12 Thread Jan Kratochvil
On Wed, 9 Aug 2023 12:36:59 GMT, Jan Kratochvil wrote: >> https://bugs.openjdk.org/browse/JDK-8313374 >> --enable-ccache's CCACHE_BASEDIR breaks builds > > Jan Kratochvil has updated the pull request incrementally with one additional > commit since the last revision: > > Use true/false for RE

Re: RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds [v6]

2023-08-12 Thread Kim Barrett
On Sun, 13 Aug 2023 00:11:22 GMT, Jan Kratochvil wrote: > > I don't understand what problem this PR is fixing. > > Does the reproducer work for you? https://bugs.openjdk.org/browse/JDK-8313374 Yes, it works for me. Or at least, with the commands and setup I normally use, it works. One differe

Re: RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds [v6]

2023-08-12 Thread Kim Barrett
On Wed, 9 Aug 2023 12:36:59 GMT, Jan Kratochvil wrote: >> https://bugs.openjdk.org/browse/JDK-8313374 >> --enable-ccache's CCACHE_BASEDIR breaks builds > > Jan Kratochvil has updated the pull request incrementally with one additional > commit since the last revision: > > Use true/false for RE

Re: RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds [v6]

2023-08-12 Thread Jan Kratochvil
On Sun, 13 Aug 2023 00:01:00 GMT, Kim Barrett wrote: > I don't understand what problem this PR is fixing. Does the reproducer work for you? https://bugs.openjdk.org/browse/JDK-8313374 - PR Comment: https://git.openjdk.org/jdk/pull/15080#issuecomment-1676155431

Re: RFR: 8314166: Update googletest to v1.14.0

2023-08-12 Thread Kim Barrett
On Fri, 11 Aug 2023 22:24:00 GMT, Mikael Vidstedt wrote: > As part of the ongoing work to enable -Wconversion with gcc there are a > number of occurrences of code in the GoogleTest code itself which need > fixing. These have been addressed in version 1.14.0 of GoogleTest. This > change is pick