On Tue, 22 Aug 2023 02:14:54 GMT, Andrew John Hughes wrote:
> GHA regularly breaks because we specify a very explicit GCC version, even
> down to the release versioning of the Ubuntu package. In just this last
> week, it has caused issues with the testing of PRs on 11u
>
On Tue, 22 Aug 2023 02:14:54 GMT, Andrew John Hughes wrote:
> GHA regularly breaks because we specify a very explicit GCC version, even
> down to the release versioning of the Ubuntu package. In just this last
> week, it has caused issues with the testing of PRs on 11u
>
Building JDK with mawk on windows fails due to regular expression. I use WSL
Debian. Debian has mawk as the default awk implementation.
$ awk
Usage: mawk [Options] [Program] [file ...]
$ make images
Building target 'images' in configuration 'windows-x86_64-server-fastdebug'
...
nawk: line 1:
On Tue, 22 Aug 2023 02:14:54 GMT, Andrew John Hughes wrote:
> GHA regularly breaks because we specify a very explicit GCC version, even
> down to the release versioning of the Ubuntu package. In just this last
> week, it has caused issues with the testing of PRs on 11u
>
On Tue, 22 Aug 2023 13:01:03 GMT, Erik Joelsson wrote:
> > I did notice that this is set for the riscv64 build in
> > `make/conf/jib-profiles.js`
>
> This configuration only exists to verify that the build works. We don't
> currently use the binaries for anything. Using "bundled" made devkit
On Tue, 22 Aug 2023 12:16:49 GMT, Johan Sjölen wrote:
> Hi,
>
> I'd like to propose that rvalue references and move semantics are now
> considered permitted in the style guide. This change would allow for move
> constructors to be written. This enables more performant code, if the move
> ctr
On Mon, 21 Aug 2023 16:57:57 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/io/ObjectStreamClass.java line 1670:
>>
>>> 1668: ObjectStreamField[] serialPersistentFields = null;
>>> 1669: try {
>>> 1670: Field f = getDeclaredField(cl,
On Tue, 22 Aug 2023 13:35:18 GMT, Volker Simonis wrote:
> Maybe we could use
> [devkits](https://github.com/openjdk/jdk/blob/master/doc/building.md#cross-compiling-the-easy-way-with-openjdk-devkits)
> to pin the compiler version? I'm not sure how feasible that is in the GHA
> context. It
On Tue, 22 Aug 2023 13:35:18 GMT, Volker Simonis wrote:
> In principle I very much prefer locking down dependency versions to keep the
> build as reliable as possible. Unfortunately, as we have experienced so far,
> this isn't possible with GHA because the exact package versions aren't kept
>
On Tue, 22 Aug 2023 14:55:18 GMT, Pavel Rappo wrote:
>> Please review this trivial PR.
>
> Pavel Rappo has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains two commits:
>
> - Merge branch 'master' into 8314753
> - Initial commit
On Tue, 22 Aug 2023 14:55:18 GMT, Pavel Rappo wrote:
>> Please review this trivial PR.
>
> Pavel Rappo has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains two commits:
>
> - Merge branch 'master' into 8314753
> - Initial commit
> Please review this trivial PR.
Pavel Rappo has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains two commits:
- Merge branch 'master' into 8314753
- Initial commit
-
Changes: https://git.openjdk.org/jdk/pull/15385/files
> There is no need for keyring installation after
> [JDK-8313701](https://bugs.openjdk.org/browse/JDK-8313701). We can simplify
> that part to reduce the difference between different JDK releases.
>
> Additional testing:
> - [ ] GHA
Aleksey Shipilev has updated the pull request with a new
On Tue, 22 Aug 2023 06:49:21 GMT, Aleksey Shipilev wrote:
> Current GHA bootstraps fail for some arches with the incompatibility between
> libfreetype-dev and libfreetype6-dev. Current RISC-V GHA bootstrap fails due
> to this conflict.
>
> In both sid, bullseye, jammy, libfreetype6-dev is a
On Tue, 22 Aug 2023 06:49:21 GMT, Aleksey Shipilev wrote:
> Current GHA bootstraps fail for some arches with the incompatibility between
> libfreetype-dev and libfreetype6-dev. Current RISC-V GHA bootstrap fails due
> to this conflict.
>
> In both sid, bullseye, jammy, libfreetype6-dev is a
On Tue, 22 Aug 2023 13:09:21 GMT, Erik Joelsson wrote:
> In principle I very much prefer locking down dependency versions to keep the
> build as reliable as possible. Unfortunately, as we have experienced so far,
> this isn't possible with GHA because the exact package versions aren't kept
>
On Tue, 22 Aug 2023 02:14:54 GMT, Andrew John Hughes wrote:
> GHA regularly breaks because we specify a very explicit GCC version, even
> down to the release versioning of the Ubuntu package. In just this last
> week, it has caused issues with the testing of PRs on 11u
>
On Tue, 22 Aug 2023 12:08:46 GMT, Andrew John Hughes wrote:
> I did notice that this is set for the riscv64 build in
> `make/conf/jib-profiles.js`
This configuration only exists to verify that the build works. We don't
currently use the binaries for anything. Using "bundled" made devkit
On Tue, 22 Aug 2023 08:42:32 GMT, Pavel Rappo wrote:
> Please review this simple PR.
This pull request has now been integrated.
Changeset: f39fc0aa
Author:Pavel Rappo
URL:
https://git.openjdk.org/jdk/commit/f39fc0aa2de19332fa51af605ece0660891d8c7a
Stats: 124 lines in 28 files
On Tue, 22 Aug 2023 06:49:21 GMT, Aleksey Shipilev wrote:
> Current GHA bootstraps fail for some arches with the incompatibility between
> libfreetype-dev and libfreetype6-dev. Current RISC-V GHA bootstrap fails due
> to this conflict.
>
> In both sid and bullseye, libfreetype6-dev is a
On Tue, 22 Aug 2023 08:42:32 GMT, Pavel Rappo wrote:
> Please review this simple PR.
You can leave the copyright years as-is.
-
PR Comment: https://git.openjdk.org/jdk/pull/15382#issuecomment-1688104170
On Tue, 22 Aug 2023 08:42:32 GMT, Pavel Rappo wrote:
> Please review this simple PR.
Removing `@revised` tags is not a substantive change, so I wouldn’t update the
copyright year as you have in some of these files.
Otherwise, this looks fine.
-
Marked as reviewed by mr (Lead).
On Tue, 22 Aug 2023 12:23:18 GMT, Mark Reinhold wrote:
> I wouldn’t update the copyright year as you have in some of these files.
I was taught to do it every time when I change a file. Would you like me to
revert those changes to copyright years in this case?
-
PR Comment:
Please review this trivial PR.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jdk/pull/15387/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15387=00
Issue: https://bugs.openjdk.org/browse/JDK-8314762
Stats: 6 lines in 3 files changed: 0 ins; 0 del; 6
Hi,
I'd like to propose that rvalue references and move semantics are now
considered permitted in the style guide. This change would allow for move
constructors to be written. This enables more performant code, if the move ctr
is less expensive than the copy ctr, but also more correct code.
On Tue, 22 Aug 2023 07:30:15 GMT, Aleksey Shipilev wrote:
> This looks okay.
>
Thanks.
> That said, it is rather unnatural to forward-port the patches. Next time, I
> would like to see a clean mainline RFE, which would then be cleanly
> backported to each of the JDK updates trees.
Agreed.
On Tue, 22 Aug 2023 06:49:21 GMT, Aleksey Shipilev wrote:
> Current GHA bootstraps fail for some arches with the incompatibility between
> libfreetype-dev and libfreetype6-dev. libfreetype6-dev. Current RISC-V GHA
> bootstrap fails due to this conflict.
>
> In both sid and bullseye and sid,
Aleksey Shipilev schrieb am Di., 22. Aug. 2023, 09:33:
> On Tue, 22 Aug 2023 02:14:54 GMT, Andrew John Hughes
> wrote:
>
> > GHA regularly breaks because we specify a very explicit GCC version,
> even down to the release versioning of the Ubuntu package. In just this
> last week, it has caused
On Tue, 22 Aug 2023 11:09:39 GMT, Pavel Rappo wrote:
> Please review this trivial PR.
CC'ing client-libs-dev because @beaninfo and @Note and jmx-dev because of
@since.unbundled, which might've been used for JMX before 2007.
-
PR Comment:
On Tue, 22 Aug 2023 11:09:39 GMT, Pavel Rappo wrote:
> Please review this trivial PR.
CC'ing core-libs-dev whose members might also have some recollection on tags in
question.
-
PR Comment: https://git.openjdk.org/jdk/pull/15385#issuecomment-1687995105
On Tue, 22 Aug 2023 11:09:39 GMT, Pavel Rappo wrote:
> Please review this trivial PR.
CC'ing client-libs-dev because `@beaninfo` and `@Note` and jmx-dev because of
`@since.unbundled`, which might've been used for JMX before 2007.
-
PR Comment:
Please review this trivial PR.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jdk/pull/15385/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15385=00
Issue: https://bugs.openjdk.org/browse/JDK-8314753
Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0
Current GHA bootstraps fail for some arches with the incompatibility between
libfreetype-dev and libfreetype6-dev. libfreetype6-dev. Current RISC-V GHA
bootstrap fails due to this conflict.
In both sid and bullseye and sid, libfreetype6-dev is a transitional package:
On Tue, 22 Aug 2023 08:47:32 GMT, Thomas Stuefe wrote:
> Looks good.
>
> Anyone knows whats up with riscv64, though? It worked on my GHA run from this
> morning
> https://github.com/openjdk/jdk/pull/15041/checks?check_run_id=16096790652
It's #15378, manifests in official Debian repository.
On Wed, 28 Jun 2023 18:53:12 GMT, Tim Prinzing wrote:
>> The socket read/write JFR events currently use instrumentation of java.base
>> code using templates in the jdk.jfr modules. This results in some java.base
>> code residing in the jdk.jfr module which is undesirable.
>>
>> JDK19 added
On Tue, 22 Aug 2023 02:14:54 GMT, Andrew John Hughes wrote:
> GHA regularly breaks because we specify a very explicit GCC version, even
> down to the release versioning of the Ubuntu package. In just this last
> week, it has caused issues with the testing of PRs on 11u
>
Please review this simple PR.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jdk/pull/15382/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15382=00
Issue: https://bugs.openjdk.org/browse/JDK-8314738
Stats: 124 lines in 28 files changed: 0 ins; 116
On Wed, 28 Jun 2023 18:53:12 GMT, Tim Prinzing wrote:
>> The socket read/write JFR events currently use instrumentation of java.base
>> code using templates in the jdk.jfr modules. This results in some java.base
>> code residing in the jdk.jfr module which is undesirable.
>>
>> JDK19 added
On Tue, 27 Jun 2023 18:29:45 GMT, Tim Prinzing wrote:
>> src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java line 408:
>>
>>> 406: @Override
>>> 407: public int read(ByteBuffer buf) throws IOException {
>>> 408: if (!SocketReadEvent.enabled()) {
>>
>> The read/write
On Wed, 28 Jun 2023 06:09:14 GMT, Alan Bateman wrote:
>> Tim Prinzing has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains ten commits:
>>
>> - remove unused SOCKET_READ and SOCKET_WRITE configurations.
>> - Merge branch 'master'
On Thu, 22 Jun 2023 13:39:51 GMT, Erik Gahlin wrote:
> An exception event will be emitted. The event is disabled by default, but
> there is ongoing work on a throttling mechanism, so it can be always-on.
Good, I think the exception cases are probably the most interesting for this
area when it
On Wed, 28 Jun 2023 18:53:12 GMT, Tim Prinzing wrote:
>> The socket read/write JFR events currently use instrumentation of java.base
>> code using templates in the jdk.jfr modules. This results in some java.base
>> code residing in the jdk.jfr module which is undesirable.
>>
>> JDK19 added
On Wed, 2 Aug 2023 20:09:39 GMT, Alan Bateman wrote:
> https://bugs.openjdk.org/browse/JDK-8310979 - better exception handling
> https://bugs.openjdk.org/browse/JDK-8310978 - missing code paths for event
> generation https://bugs.openjdk.org/browse/JDK-8310994 - non-blocking, event
> for
On Tue, 22 Aug 2023 02:14:54 GMT, Andrew John Hughes wrote:
> GHA regularly breaks because we specify a very explicit GCC version, even
> down to the release versioning of the Ubuntu package. In just this last
> week, it has caused issues with the testing of PRs on 11u
>
44 matches
Mail list logo
