Re: RFR: 8314483: Optionally override copyright header in generated source

2023-08-23 Thread David Holmes
On Fri, 18 Aug 2023 14:22:49 GMT, Erik Joelsson wrote: > In the JDK build we have various build tools that generate source code from > data files. For most of these tools, the source files are based on template > files, which already have copyright headers, but for some, the complete > source

Integrated: 8314555: Build with mawk fails on Windows

2023-08-23 Thread Koichi Sakata
On Mon, 21 Aug 2023 07:13:37 GMT, Koichi Sakata wrote: > Building JDK with mawk on windows fails due to regular expression. I use WSL > Debian. Debian has mawk as the default awk implementation. > > $ awk > Usage: mawk [Options] [Program] [file ...] > > $ make images > Building target 'images'

Re: RFR: 8314555: Build with mawk fails on Windows

2023-08-23 Thread Koichi Sakata
On Mon, 21 Aug 2023 07:13:37 GMT, Koichi Sakata wrote: > Building JDK with mawk on windows fails due to regular expression. I use WSL > Debian. Debian has mawk as the default awk implementation. > > $ awk > Usage: mawk [Options] [Program] [file ...] > > $ make images > Building target 'images'

Re: RFR: 8314644: Change "Rvalue references and move semantics" into an accepted feature

2023-08-23 Thread daniel . daugherty
A couple of questions: - Are these C++ features supported in all of the compilers that we use/support   in OpenJDK? I mean the Tier1 platforms that Oracle supports in our CI and the   other platforms that OpenJDK supports in the GHA setups. - How do we gauge the quality of support for these C+

Is there a make target to only build (but not run) the gtestLauncher?

2023-08-23 Thread Kemper, William
I'm trying to integrate gtest execution with my IDE (CLion), and I'd like it to update the gtestLauncher without running the tests. Can this be done? or is there a better way to integrate gtest execution? Thank you, William

RFR: 8310454: Introduce static-libs-graal bundle

2023-08-23 Thread Erik Joelsson
[JDK-8307858](https://bugs.openjdk.org/browse/JDK-8307858) added libjvm.a to the set of static-libs in the static-libs image and subsequently the static-libs bundle. The main user of the existing static-image was the graal build, which doesn't need libjvm. Since libjvm is considerably bigger tha

Re: RFR: 8314644: Change "Rvalue references and move semantics" into an accepted feature

2023-08-23 Thread Kim Barrett
On Tue, 22 Aug 2023 12:16:49 GMT, Johan Sjölen wrote: > Hi, > > I'd like to propose that rvalue references and move semantics are now > considered permitted in the style guide. This change would allow for move > constructors to be written. This enables more performant code, if the move > ctr

Re: RFR: JDK-8313764: Offer JVM HS functionality to shared lib load operations done by the JDK codebase [v2]

2023-08-23 Thread Matthias Baesken
> Currently there is a number of functionality that would be interesting to > have for shared lib load operations in the JDK C code. > Some examples : > Events::log_dll_message for hs-err files reporting > JFR event NativeLibraryLoad > There is the need to update the shared lib Cache on AIX ( see

Re: RFR: 8314555: Build with mawk fails on Windows

2023-08-23 Thread Erik Joelsson
On Mon, 21 Aug 2023 07:13:37 GMT, Koichi Sakata wrote: > Building JDK with mawk on windows fails due to regular expression. I use WSL > Debian. Debian has mawk as the default awk implementation. > > $ awk > Usage: mawk [Options] [Program] [file ...] > > $ make images > Building target 'images'

Re: RFR: JDK-8313764: Offer JVM HS functionality to shared lib load operations done by the JDK codebase

2023-08-23 Thread Martin Doerr
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote: > Currently there is a number of functionality that would be interesting to > have for shared lib load operations in the JDK C code. > Some examples : > Events::log_dll_message for hs-err files reporting > JFR event NativeLibraryLoad > Th

Integrated: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds

2023-08-23 Thread Jan Kratochvil
On Sat, 29 Jul 2023 13:58:37 GMT, Jan Kratochvil wrote: > https://bugs.openjdk.org/browse/JDK-8313374 > --enable-ccache's CCACHE_BASEDIR breaks builds This pull request has now been integrated. Changeset: 571c435e Author:Jan Kratochvil Committer: Yuri Nesterenko URL: https://git.o

Re: RFR: 8314656: GHA: No need for Debian ports keyring installation after JDK-8313701 [v4]

2023-08-23 Thread Fei Yang
On Wed, 23 Aug 2023 08:40:25 GMT, Aleksey Shipilev wrote: >> There is no need for keyring installation after >> [JDK-8313701](https://bugs.openjdk.org/browse/JDK-8313701). We can simplify >> that part to reduce the difference between different JDK releases. >> >> Additional testing: >> - [ ]

Re: RFR: 8314656: GHA: No need for Debian ports keyring installation after JDK-8313701 [v4]

2023-08-23 Thread Aleksey Shipilev
> There is no need for keyring installation after > [JDK-8313701](https://bugs.openjdk.org/browse/JDK-8313701). We can simplify > that part to reduce the difference between different JDK releases. > > Additional testing: > - [ ] GHA Aleksey Shipilev has updated the pull request with a new targ