On Wed, 23 Aug 2023 15:18:03 GMT, Matthias Baesken wrote:
>> Currently there is a number of functionality that would be interesting to
>> have for shared lib load operations in the JDK C code.
>> Some examples :
>> Events::log_dll_message for hs-err files reporting
>> JFR event NativeLibraryLoad
On Fri, 25 Aug 2023 22:31:31 GMT, Erik Joelsson wrote:
> After [JDK-8313374](https://bugs.openjdk.org/browse/JDK-8313374), out of tree
> incremental builds with ccache started failing. The rewriting of the
> generated dependency (*.d) files creates object file paths with `/../` in
> them which
On Tue, 22 Aug 2023 12:19:42 GMT, Pavel Rappo wrote:
> Please review this trivial PR.
LGTM
-
Marked as reviewed by chegar (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15387#pullrequestreview-1597197292
On Fri, 25 Aug 2023 20:07:18 GMT, Erik Joelsson wrote:
>> Ao Qi has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> rename LOONGARCH and move RISCV32 to zero
>
> Marked as reviewed by erikj (Reviewer).
Thanks @erikj79 and @RealFYang for you
On Sun, 27 Aug 2023 09:03:57 GMT, Ao Qi wrote:
>> The `LOONGARCH` is not a macro that must be defined. It is not a C/C++
>> pre-defined macro and is also not pre-defined in libraries such as libffi.
>> We'd better use a macro defined in jdk.
>
> Ao Qi has updated the pull request incrementally
On Sun, 27 Aug 2023 03:49:28 GMT, Fei Yang wrote:
>> Ao Qi has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> rename LOONGARCH and move RISCV32 to zero
>
> Two minor nits.
Thanks for your advice, @RealFYang. I have updated the patch.
> The `LOONGARCH` is not a macro that must be defined. It is not a C/C++
> pre-defined macro and is also not pre-defined in libraries such as libffi.
> We'd better use a macro defined in jdk.
Ao Qi has updated the pull request incrementally with one additional commit
since the last revision:
