Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v2]

2023-10-16 Thread Joe Wang
On Mon, 16 Oct 2023 23:37:51 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY. Alt

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v10]

2023-10-16 Thread David Holmes
On Mon, 16 Oct 2023 16:22:27 GMT, Andrew Haley wrote: >> A bug in GCC causes shared libraries linked with -ffast-math to disable >> denormal arithmetic. This breaks Java's floating-point semantics. >> >> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522 >> >> One solution is to sav

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v2]

2023-10-16 Thread Roger Riggs
On Mon, 16 Oct 2023 23:37:51 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY. Alt

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v2]

2023-10-16 Thread Naoto Sato
> CLDR provides very few short names for time zones, such as PST/PDT. This will > typically end up substituting names from the COMPAT provider. Once the COMPAT > is removed, they will be displayed in the GMT format, i.e., GMT+XX:YY. > Although some of the short names in the COMPAT provider are s

RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider

2023-10-16 Thread Naoto Sato
CLDR provides very few short names for time zones, such as PST/PDT. This will typically end up substituting names from the COMPAT provider. Once the COMPAT is removed, they will be displayed in the GMT format, i.e., GMT+XX:YY. Although some of the short names in the COMPAT provider are somewhat

Re: jdk8u: VS_DESCRIPTION_2017 (Microsoft Visual Studio 2017 - CURRENTLY NOT WORKING)

2023-10-16 Thread erik . joelsson
When the configure support for VS 2017 was originally added, there were still compilation errors when using it. We never got around to removing that comment after getting the build working again until a later JDK release. /Erik On 10/16/23 07:59, Andrew Leonard wrote: Does anyone know why the

Re: RFR: 8308753: Class-File API transition to Preview [v21]

2023-10-16 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v10]

2023-10-16 Thread Andrew Haley
> A bug in GCC causes shared libraries linked with -ffast-math to disable > denormal arithmetic. This breaks Java's floating-point semantics. > > The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522 > > One solution is to save and restore the floating-point control word around > System

Re: RFR: 8318078: ADLC: pass ASSERT and PRODUCT flags [v2]

2023-10-16 Thread Vladimir Kozlov
On Mon, 16 Oct 2023 10:34:37 GMT, Emanuel Peter wrote: >> @vnkozlov asked me to guard some debug AD file rules in `#ifdef ASSERT`. >> https://github.com/openjdk/jdk/pull/14785#discussion_r1349391130 >> >> We discovered that the `ASSERT` and `PRODUCT` are not yet passed to ADLC, >> and hence th

jdk8u: VS_DESCRIPTION_2017 (Microsoft Visual Studio 2017 - CURRENTLY NOT WORKING)

2023-10-16 Thread Andrew Leonard
Does anyone know why the jdk8u toolchain_windows.m4 VS_DESCRIPTION_2017 description contains "CURRENTLY NOT WORKING" ? https://github.com/openjdk/jdk8u/blob/b24b03f9dbeb2c1e8b5cb0279659eee489bd9df4/common/autoconf/toolchain_windows.m4#L74 Thanks

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v9]

2023-10-16 Thread Andrew Haley
On Wed, 11 Oct 2023 18:08:55 GMT, Vladimir Ivanov wrote: >> Andrew Haley has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add TestDenormalDouble.java > > test/hotspot/jtreg/compiler/floatingpoint/libfast-math.c line 26: > >> 24: #include

Re: RFR: 8318078: ADLC: pass ASSERT and PRODUCT flags [v2]

2023-10-16 Thread Erik Joelsson
On Mon, 16 Oct 2023 10:34:37 GMT, Emanuel Peter wrote: >> @vnkozlov asked me to guard some debug AD file rules in `#ifdef ASSERT`. >> https://github.com/openjdk/jdk/pull/14785#discussion_r1349391130 >> >> We discovered that the `ASSERT` and `PRODUCT` are not yet passed to ADLC, >> and hence th

Re: RFR: 8318078: ADLC: pass ASSERT and PRODUCT flags [v2]

2023-10-16 Thread Emanuel Peter
> @vnkozlov asked me to guard some debug AD file rules in `#ifdef ASSERT`. > https://github.com/openjdk/jdk/pull/14785#discussion_r1349391130 > > We discovered that the `ASSERT` and `PRODUCT` are not yet passed to ADLC, and > hence they are always considered `undefined`. Hence, all of these `ifd

Re: RFR: 8318078: ADLC: pass ASSERT and PRODUCT flags [v2]

2023-10-16 Thread Emanuel Peter
On Fri, 13 Oct 2023 17:23:32 GMT, Vladimir Kozlov wrote: >> Emanuel Peter has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add comments like Vladimir requested > > make/hotspot/gensrc/GensrcAdlc.gmk line 138: > >> 136: # Set ASSERT, ND