Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v11]

2023-10-17 Thread David Holmes
On Tue, 17 Oct 2023 11:43:59 GMT, Andrew Haley wrote: >> A bug in GCC causes shared libraries linked with -ffast-math to disable >> denormal arithmetic. This breaks Java's floating-point semantics. >> >> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522 >> >> One solution is to

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v10]

2023-10-17 Thread David Holmes
On Tue, 17 Oct 2023 10:56:33 GMT, Andrew Haley wrote: >> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 5169: >> >>> 5167: // Perform a little arithmetic to make sure that denormal >>> 5168: // numbers are handled correctly, i.e. that the "Denormals Are >>> 5169: // Zeros"

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

2023-10-17 Thread Naoto Sato
On Tue, 17 Oct 2023 21:45:57 GMT, Steven Loomis wrote: > > CLDR provides very few short names for time zones, such as PST/PDT. This > > will typically end up substituting names from the COMPAT provider. Once the > > COMPAT is removed, they will be displayed in the GMT format, i.e., > >

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

2023-10-17 Thread Steven Loomis
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY.

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

2023-10-17 Thread Roger Riggs
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY.

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

2023-10-17 Thread Iris Clark
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY.

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

2023-10-17 Thread Erik Joelsson
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY.

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

2023-10-17 Thread Lance Andersen
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY.

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

2023-10-17 Thread Joe Wang
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY.

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v2]

2023-10-17 Thread Naoto Sato
On Tue, 17 Oct 2023 02:03:06 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use ZoneOffset to parse offset > > Looks fine. > (I can't help thinking that some of this pre-processing would be easier

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

2023-10-17 Thread Naoto Sato
> CLDR provides very few short names for time zones, such as PST/PDT. This will > typically end up substituting names from the COMPAT provider. Once the COMPAT > is removed, they will be displayed in the GMT format, i.e., GMT+XX:YY. > Although some of the short names in the COMPAT provider are

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v11]

2023-10-17 Thread Andrew Haley
> A bug in GCC causes shared libraries linked with -ffast-math to disable > denormal arithmetic. This breaks Java's floating-point semantics. > > The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522 > > One solution is to save and restore the floating-point control word around >

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v10]

2023-10-17 Thread Andrew Haley
On Tue, 17 Oct 2023 02:15:45 GMT, David Holmes wrote: >> Andrew Haley has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Comments only. >> - Review feedback > > src/hotspot/cpu/x86/macroAssembler_x86.cpp line 5169: > >> 5167: //

Re: jdk8u: VS_DESCRIPTION_2017 (Microsoft Visual Studio 2017 - CURRENTLY NOT WORKING)

2023-10-17 Thread Andrew Leonard
Thanks Erik, We can safely ignore then, cool thanks Cheers Andrew On Mon, Oct 16, 2023 at 6:17 PM wrote: > When the configure support for VS 2017 was originally added, there were > still compilation errors when using it. We never got around to removing > that comment after getting the build

Integrated: 8318078: ADLC: pass ASSERT and PRODUCT flags

2023-10-17 Thread Emanuel Peter
On Fri, 13 Oct 2023 09:49:48 GMT, Emanuel Peter wrote: > @vnkozlov asked me to guard some debug AD file rules in `#ifdef ASSERT`. > https://github.com/openjdk/jdk/pull/14785#discussion_r1349391130 > > We discovered that the `ASSERT` and `PRODUCT` are not yet passed to ADLC, and > hence they

Re: RFR: 8318078: ADLC: pass ASSERT and PRODUCT flags [v2]

2023-10-17 Thread Emanuel Peter
On Mon, 16 Oct 2023 16:03:39 GMT, Vladimir Kozlov wrote: >> Emanuel Peter has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add comments like Vladimir requested > > Good Thanks @vnkozlov @TobiHartmann for the help figuring this out. And