> Prepare HotSpot for the permissive- Visual C++ flag, this change contains all
> of the fixes required for HotSpot to compile under the stricter mode
> activated when the permissive- flag is passed
>
> - Reworks code in topLevelUnhandledExceptionFilter for os_windows.cpp to
> avoid goto
On Tue, 31 Oct 2023 16:12:21 GMT, Joe Darcy wrote:
>> doc/testing.md line 147:
>>
>>> 145: manner.
>>> 146: As a guideline, nearly all individual tests in `tier1` should
>>> complete in less than ten seconds
>>> 147: when run on common configurations used for development. Long-running
On Wed, 25 Oct 2023 23:06:59 GMT, Jonathan Gibbons wrote:
> Please review an update to the way that `javadoc` handles the default legal
> notices when generating docs.
>
> Previously, the default notices were taken from the module's `legal`
> directory (`$JAVA_HOME/legal/jdk.javadoc`), but in
On Tue, 31 Oct 2023 20:58:04 GMT, Jonathan Gibbons wrote:
>> Please review an update to the way that `javadoc` handles the default legal
>> notices when generating docs.
>>
>> Previously, the default notices were taken from the module's `legal`
>> directory (`$JAVA_HOME/legal/jdk.javadoc`),
> Please review an update to the way that `javadoc` handles the default legal
> notices when generating docs.
>
> Previously, the default notices were taken from the module's `legal`
> directory (`$JAVA_HOME/legal/jdk.javadoc`), but in some contexts, these files
> were either symbolic links,
On Tue, 31 Oct 2023 13:05:44 GMT, Robbin Ehn wrote:
> Hi, please consider.
>
> insn_options[0] is set to empty string if there is no options (NULL or empty
> strings).
> Checking it for empty string should cover both cases, caller option is NULL
> or caller option is empty string.
>
> Tested
On Mon, 30 Oct 2023 21:43:11 GMT, Mandy Chung wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review feedback
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDoclet.java
On Tue, 31 Oct 2023 14:42:22 GMT, Robbin Ehn wrote:
>> The parse_caller_options handles the NULL case, so I forgot about the early
>> bailout.
>>
>> for (p = caller_options; p != NULL; ) {
>> }
>> *iop = '\0';
>>
>>
>> Sorry.
>
> Sorry again, long day:
>
> struct hsdis_app_data
On Tue, 31 Oct 2023 07:05:47 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Initial check-in of updated HTML file.
>
> doc/testing.md line 147:
>
>> 145: manner.
>> 146: As a guideline, nearly
> Clarify the intention of tier 1 tests. I'll reflow the paragraph and
> regenerate the HTML file once the wording is agreed upon.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Update wording.
-
Changes:
- all:
On Tue, 31 Oct 2023 14:30:26 GMT, Robbin Ehn wrote:
>> src/utils/hsdis/binutils/hsdis-binutils.c line 340:
>>
>>> 338: native_bfd,
>>> 339: /* On some archs we get warnings, if
>>> we pass empty options */
>>> 340:
On Tue, 31 Oct 2023 14:30:26 GMT, Robbin Ehn wrote:
>> src/utils/hsdis/binutils/hsdis-binutils.c line 340:
>>
>>> 338: native_bfd,
>>> 339: /* On some archs we get warnings, if
>>> we pass empty options */
>>> 340:
On Tue, 31 Oct 2023 14:15:16 GMT, Andrew Haley wrote:
>> Hi, please consider.
>>
>> insn_options[0] is set to empty string if there is no options (NULL or empty
>> strings).
>> Checking it for empty string should cover both cases, caller option is NULL
>> or caller option is empty string.
>>
On Tue, 31 Oct 2023 13:05:44 GMT, Robbin Ehn wrote:
> Hi, please consider.
>
> insn_options[0] is set to empty string if there is no options (NULL or empty
> strings).
> Checking it for empty string should cover both cases, caller option is NULL
> or caller option is empty string.
>
> Tested
Hi, please consider.
insn_options[0] is set to empty string if there is no options (NULL or empty
strings).
Checking it for empty string should cover both cases, caller option is NULL or
caller option is empty string.
Tested hsdis no longer gives me the warning.
-
Commit
On Tue, 31 Oct 2023 12:53:56 GMT, Erik Joelsson wrote:
> > I think you are correct, I tested on some more machines.
> > On my vf2 dev board (4-core rv64) it do speed up sh configure, from 7:19 to
> > 3:40. I see like 20 instances of cc1 instead 1, a bit to many :)
>
> Adding the `-j` flag
On Tue, 31 Oct 2023 06:39:55 GMT, Robbin Ehn wrote:
> I think you are correct, I tested on some more machines.
>
> On my vf2 dev board (4-core rv64) it do speed up sh configure, from 7:19 to
> 3:40. I see like 20 instances of cc1 instead 1, a bit to many :)
Adding the `-j` flag without a
On Tue, 31 Oct 2023 07:32:35 GMT, Kim Barrett wrote:
>> I know he was away until October but not exactly when in October.
>
> Ick! I hadn't followed https://github.com/openjdk/jdk/pull/15096 closely, so
> hadn't noticed the discussion there. Not sure why this is using a literal 0
> rather than
On Tue, 3 Oct 2023 07:45:42 GMT, David Holmes wrote:
>> Is Thomas around? Would like to get his opinion of what to do with this
>> particular snippet
>
> I know he was away until October but not exactly when in October.
Ick! I hadn't followed https://github.com/openjdk/jdk/pull/15096 closely,
On Tue, 31 Oct 2023 00:23:44 GMT, Joe Darcy wrote:
>> Clarify the intention of tier 1 tests. I'll reflow the paragraph and
>> regenerate the HTML file once the wording is agreed upon.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
On Mon, 30 Oct 2023 15:41:48 GMT, Robbin Ehn wrote:
> Hi all, please consider.
>
> Tested configure with binutils-src.
>
> Thanks
I think you are correct, I tested on some more machines.
On my vf2 dev board (4-core rv64) it do speed up sh configure, from 7:19 to
3:40.
I see like 20
On Mon, 30 Oct 2023 15:41:48 GMT, Robbin Ehn wrote:
> Hi all, please consider.
>
> Tested configure with binutils-src.
>
> Thanks
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/16421
22 matches
Mail list logo
