Re: Cannot configure on Windows in Chinese Environment

2023-11-02 Thread 吴 国璋
If OpenJDK requires en-us environment, then nothing needs to be changed. Please ignore this thread. 发件人: David Holmes 发送时间: 2023年11月3日 13:13 收件人: 吴 国璋 ; build-dev@openjdk.org 主题: Re: Cannot configure on Windows in Chinese Environment Notwithstanding what was

Re: Cannot configure on Windows in Chinese Environment

2023-11-02 Thread David Holmes
Notwithstanding what was done in 2013 to try and be more locale tolerant with cl.exe: https://mail.openjdk.org/pipermail/build-dev/2013-October/010444.html I think the basic position is that supported building of OpenJDK requires a US-English locale and toolchain. For some reason this never

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v2]

2023-11-02 Thread Zhao Song
On Thu, 2 Nov 2023 16:09:28 GMT, Zhao Song wrote: >> @erikj79 >> Thanks for the review. >> The code has been updated > > Hi @xpbob, > The jcheck is continuously failing because your GitHub name is `null`. Please > set your name in your profile. > And out of curiosity, I want to know did you

Integrated: 8319268: Build failure with GCC8.3.1 after 8313643

2023-11-02 Thread xpbob
On Thu, 2 Nov 2023 04:29:01 GMT, xpbob wrote: > Build failure with GCC8.3.1 > > === Output from failing command(s) repeated here === > * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o: > /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc: > In

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v2]

2023-11-02 Thread xpbob
On Thu, 2 Nov 2023 16:09:28 GMT, Zhao Song wrote: >> @erikj79 >> Thanks for the review. >> The code has been updated > > Hi @xpbob, > The jcheck is continuously failing because your GitHub name is `null`. Please > set your name in your profile. > And out of curiosity, I want to know did you

Re: Cannot configure on Windows in Chinese Environment

2023-11-02 Thread Julian Waters
Hi, I can help you, how should I create the issue? best regards, Julian

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v3]

2023-11-02 Thread xpbob
On Thu, 2 Nov 2023 14:01:20 GMT, xpbob wrote: >> Build failure with GCC8.3.1 >> >> === Output from failing command(s) repeated here === >> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o: >> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc: >>

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v3]

2023-11-02 Thread xpbob
On Thu, 2 Nov 2023 17:51:15 GMT, Phil Race wrote: >> xpbob has updated the pull request incrementally with one additional commit >> since the last revision: >> >> Update make/modules/java.desktop/lib/Awt2dLibraries.gmk >> >> break up line >> >> Co-authored-by: Erik Joelsson

Re: Cannot configure on Windows in Chinese Environment

2023-11-02 Thread 吴 国璋
Thanks, I will take a look. Because I am new here, according to the developer's guide, I need to find a sponsor, who helps me create an issue in jira, before I can submit a pull request. Is there anyone who wants to help me? 发件人: Robbin Ehn 发送时间: 2023年11月2日

Integrated: JDK-8296240: Augment discussion of test tiers in doc/testing.md

2023-11-02 Thread Joe Darcy
On Thu, 26 Oct 2023 19:04:16 GMT, Joe Darcy wrote: > Clarify the intention of tier 1 tests. I'll reflow the paragraph and > regenerate the HTML file once the wording is agreed upon. This pull request has now been integrated. Changeset: c788160f Author:Joe Darcy URL:

Re: RFR: JDK-8296240: Augment discussion of test tiers in doc/testing.md [v7]

2023-11-02 Thread Joe Darcy
> Clarify the intention of tier 1 tests. I'll reflow the paragraph and > regenerate the HTML file once the wording is agreed upon. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Reflow paragraph. - Changes: - all:

Re: RFR: JDK-8296240: Augment discussion of test tiers in doc/testing.md [v6]

2023-11-02 Thread Alan Bateman
On Tue, 31 Oct 2023 16:11:47 GMT, Joe Darcy wrote: >> Clarify the intention of tier 1 tests. I'll reflow the paragraph and >> regenerate the HTML file once the wording is agreed upon. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v3]

2023-11-02 Thread Phil Race
On Thu, 2 Nov 2023 14:01:20 GMT, null wrote: >> Build failure with GCC8.3.1 >> >> === Output from failing command(s) repeated here === >> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o: >> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc: >>

Re: RFR: 8317620: Build JDK tools with ModuleMainClass attribute [v2]

2023-11-02 Thread Alan Bateman
On Thu, 2 Nov 2023 16:19:35 GMT, Mandy Chung wrote: >> Tool modules can be created via `jmod --main-class` option such that >> `ModuleMainClass` attribute will be added in `module-info.class` and the >> module's main class can be launched via `java -m ` without >> specifying the name of the

building on macOS 14

2023-11-02 Thread Alan Snyder
As you may know, a JDK built on macOS 14 using the macOS 14 SDK crashes during initialization of AWT. (The problem appears to be Apple’s bug. It is triggered by a runtime check that is enabled only in programs that were linked against the macOS 14 SDK.) So I tried to build JDK using the macOS

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v3]

2023-11-02 Thread Erik Joelsson
On Thu, 2 Nov 2023 14:01:20 GMT, null wrote: >> Build failure with GCC8.3.1 >> >> === Output from failing command(s) repeated here === >> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o: >> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc: >>

Re: RFR: 8317620: Build JDK tools with ModuleMainClass attribute [v2]

2023-11-02 Thread Mandy Chung
> Tool modules can be created via `jmod --main-class` option such that > `ModuleMainClass` attribute will be added in `module-info.class` and the > module's main class can be launched via `java -m ` without > specifying the name of the main class. > > In addition, for modules with

Re: RFR: 8317620: Build JDK tools with ModuleMainClass attribute

2023-11-02 Thread Mandy Chung
On Thu, 2 Nov 2023 07:41:27 GMT, Alan Bateman wrote: >> Tool modules can be created via `jmod --main-class` option such that >> `ModuleMainClass` attribute will be added in `module-info.class` and the >> module's main class can be launched via `java -m ` without >> specifying the name of the

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v2]

2023-11-02 Thread Zhao Song
On Thu, 2 Nov 2023 13:58:01 GMT, null wrote: >> null has updated the pull request incrementally with one additional commit >> since the last revision: >> >> add comments > > @erikj79 > Thanks for the review. > The code has been updated Hi @xpbob, The jcheck is continuously failing because

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v2]

2023-11-02 Thread null
On Thu, 2 Nov 2023 07:14:14 GMT, null wrote: >> Build failure with GCC8.3.1 >> >> === Output from failing command(s) repeated here === >> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o: >> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc: >>

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v3]

2023-11-02 Thread null
> Build failure with GCC8.3.1 > > === Output from failing command(s) repeated here === > * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o: > /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc: > In function 'hb_bool_t

Re: RFR: 8317620: Build JDK tools with ModuleMainClass attribute

2023-11-02 Thread Erik Joelsson
On Wed, 1 Nov 2023 19:58:07 GMT, Mandy Chung wrote: > Tool modules can be created via `jmod --main-class` option such that > `ModuleMainClass` attribute will be added in `module-info.class` and the > module's main class can be launched via `java -m ` without > specifying the name of the main

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v2]

2023-11-02 Thread Erik Joelsson
On Thu, 2 Nov 2023 07:14:14 GMT, null wrote: >> Build failure with GCC8.3.1 >> >> === Output from failing command(s) repeated here === >> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o: >> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc: >>

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string [v2]

2023-11-02 Thread Robbin Ehn
On Thu, 2 Nov 2023 09:22:55 GMT, Andrew Haley wrote: >> Robbin Ehn has updated the pull request incrementally with one additional >> commit since the last revision: >> >> More clear > > src/utils/hsdis/binutils/hsdis-binutils.c line 341: > >> 339: /* On some

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string [v3]

2023-11-02 Thread Robbin Ehn
> Hi, please consider. > > insn_options[0] is set to empty string if there is no options (NULL or empty > strings). > Checking it for empty string should cover both cases, caller option is NULL > or caller option is empty string. > > Tested hsdis no longer gives me the warning. Robbin Ehn has

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string [v2]

2023-11-02 Thread Robbin Ehn
On Wed, 1 Nov 2023 11:52:20 GMT, Robbin Ehn wrote: >> Hi, please consider. >> >> insn_options[0] is set to empty string if there is no options (NULL or empty >> strings). >> Checking it for empty string should cover both cases, caller option is NULL >> or caller option is empty string. >> >>

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string [v2]

2023-11-02 Thread Andrew Haley
On Wed, 1 Nov 2023 11:52:20 GMT, Robbin Ehn wrote: >> Hi, please consider. >> >> insn_options[0] is set to empty string if there is no options (NULL or empty >> strings). >> Checking it for empty string should cover both cases, caller option is NULL >> or caller option is empty string. >> >>

Re: RFR: 8319165: hsdis binutils: warns on empty string as option string [v2]

2023-11-02 Thread Jesper Wilhelmsson
On Wed, 1 Nov 2023 11:52:20 GMT, Robbin Ehn wrote: >> Hi, please consider. >> >> insn_options[0] is set to empty string if there is no options (NULL or empty >> strings). >> Checking it for empty string should cover both cases, caller option is NULL >> or caller option is empty string. >> >>

Integrated: 8317132: Prepare HotSpot for permissive-

2023-11-02 Thread Julian Waters
On Thu, 28 Sep 2023 03:22:30 GMT, Julian Waters wrote: > Prepare HotSpot for the permissive- Visual C++ flag, this change contains all > of the fixes required for HotSpot to compile under the stricter mode > activated when the permissive- flag is passed > > - Reworks code in

Re: RFR: 8317132: Prepare HotSpot for permissive- [v14]

2023-11-02 Thread David Holmes
On Thu, 2 Nov 2023 07:26:38 GMT, Julian Waters wrote: >> Prepare HotSpot for the permissive- Visual C++ flag, this change contains >> all of the fixes required for HotSpot to compile under the stricter mode >> activated when the permissive- flag is passed >> >> - Reworks code in

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v18]

2023-11-02 Thread Thomas Stuefe
On Fri, 27 Oct 2023 11:59:59 GMT, Andrew Haley wrote: >> A bug in GCC causes shared libraries linked with -ffast-math to disable >> denormal arithmetic. This breaks Java's floating-point semantics. >> >> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522 >> >> One solution is to

Re: RFR: 8317620: Build JDK tools with ModuleMainClass attribute

2023-11-02 Thread Alan Bateman
On Wed, 1 Nov 2023 19:58:07 GMT, Mandy Chung wrote: > Tool modules can be created via `jmod --main-class` option such that > `ModuleMainClass` attribute will be added in `module-info.class` and the > module's main class can be launched via `java -m ` without > specifying the name of the main

Re: RFR: 8317132: Prepare HotSpot for permissive- [v14]

2023-11-02 Thread Julian Waters
> Prepare HotSpot for the permissive- Visual C++ flag, this change contains all > of the fixes required for HotSpot to compile under the stricter mode > activated when the permissive- flag is passed > > - Reworks code in topLevelUnhandledExceptionFilter for os_windows.cpp to > avoid goto

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v2]

2023-11-02 Thread null
> Build failure with GCC8.3.1 > > === Output from failing command(s) repeated here === > * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o: > /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc: > In function 'hb_bool_t

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643

2023-11-02 Thread null
On Thu, 2 Nov 2023 06:54:01 GMT, Jie Fu wrote: >> Build failure with GCC8.3.1 >> >> === Output from failing command(s) repeated here === >> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o: >> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc: >>

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v2]

2023-11-02 Thread Jie Fu
On Thu, 2 Nov 2023 07:11:49 GMT, null wrote: >> Build failure with GCC8.3.1 >> >> === Output from failing command(s) repeated here === >> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o: >> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc: >>

Re: RFR: 8319268: Build failure with GCC8.3.1 after 8313643

2023-11-02 Thread Jie Fu
On Thu, 2 Nov 2023 04:29:01 GMT, null wrote: > Build failure with GCC8.3.1 > > === Output from failing command(s) repeated here === > * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o: > /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc: > In

Re: RFR: 8317132: Prepare HotSpot for permissive- [v13]

2023-11-02 Thread David Holmes
On Thu, 2 Nov 2023 05:54:31 GMT, Julian Waters wrote: >> Prepare HotSpot for the permissive- Visual C++ flag, this change contains >> all of the fixes required for HotSpot to compile under the stricter mode >> activated when the permissive- flag is passed >> >> - Reworks code in