Re: RFR: 8320533: Adjust capstone integration for v6 changes [v5]

2023-11-26 Thread Galder Zamarreño
> FYI @theRealAph > > It includes a couple of commits to integrate with Capstone v6 while still > working with Capstone v5 and before: > * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of > `CS_ARCH_ARM64`. See [this > document](https://github.com/Rot127/capstone/blob/v6-release-

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v2]

2023-11-26 Thread Galder Zamarreño
On Sat, 25 Nov 2023 00:56:59 GMT, Jatin Bhateja wrote: >> Added a comment. > > Please also update the copyright year for this file. Updated - PR Review Comment: https://git.openjdk.org/jdk/pull/16788#discussion_r1405744455

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v3]

2023-11-26 Thread Galder Zamarreño
On Thu, 23 Nov 2023 16:31:22 GMT, Galder Zamarreño wrote: >> FYI @theRealAph >> >> It includes a couple of commits to integrate with Capstone v6 while still >> working with Capstone v5 and before: >> * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of >> `CS_ARCH_ARM64`. See [thi

Re: RFR: 8320533: Adjust capstone integration for v6 changes [v4]

2023-11-26 Thread Galder Zamarreño
> FYI @theRealAph > > It includes a couple of commits to integrate with Capstone v6 while still > working with Capstone v5 and before: > * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead of > `CS_ARCH_ARM64`. See [this > document](https://github.com/Rot127/capstone/blob/v6-release-

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v4]

2023-11-26 Thread Xiaohong Gong
On Thu, 23 Nov 2023 15:43:34 GMT, Andrew Haley wrote: >> Xiaohong Gong has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments in build system > > make/autoconf/lib-vmath.m4 line 94: > >> 92: # Check the ARM SV

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v3]

2023-11-26 Thread Xiaohong Gong
On Thu, 23 Nov 2023 14:01:48 GMT, Magnus Ihse Bursie wrote: >> OK, I see. It makes sense that the suffix name should be choosed mainly >> based on the real module name that is searched/checked in configure. > > This still needs fixing. Yes, I will fix this together with removing the SVE cflags

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v4]

2023-11-26 Thread Xiaohong Gong
On Thu, 23 Nov 2023 14:10:02 GMT, Magnus Ihse Bursie wrote: >> Xiaohong Gong has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments in build system > > make/autoconf/lib-vmath.m4 line 89: > >> 87: if test "x${LIBS