On Wed, 29 Nov 2023 06:45:17 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change will attempts to workaround an issue
> in dsymutil?
>
> The previous attempt to use `--reproducer Off` has shown that it fails to
> build on some other Xcode versions other than 14.3.1. Users have
On Thu, 30 Nov 2023 09:39:54 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change will attempts to workaround an
>> issue in dsymutil?
>>
>> The previous attempt to use `--reproducer Off` has shown that it fails to
>> build on some other Xcode versions other than 14.3.1. Users
On Thu, 30 Nov 2023 23:49:24 GMT, Joe Darcy wrote:
>> Time to start making preparations for JDK 23.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update symbol files to JDK 22 b26.
looks good to me
-
Marked
On Thu, 30 Nov 2023 09:39:54 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change will attempts to workaround an
>> issue in dsymutil?
>>
>> The previous attempt to use `--reproducer Off` has shown that it fails to
>> build on some other Xcode versions other than 14.3.1. Users
On Fri, 1 Dec 2023 10:19:01 GMT, Andrew Haley wrote:
>> Xiaohong Gong has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains ten additional
>> commits
On Fri, 1 Dec 2023 08:48:52 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
On Fri, 1 Dec 2023 16:35:31 GMT, Magnus Ihse Bursie wrote:
>> Yes. It still failed.
>
> You need to expand this logic to cover more instances. See e.g. lib-ffi.m4
> for inspiration.
>
> Basic flow:
> * if user has specified libsleef root with argument, check both lib/ and
> lib64/ under that
On Fri, 1 Dec 2023 10:02:35 GMT, Andrew Haley wrote:
>> Did you try to find the libsleef by passing `--with-libsleef=` ? Currently
>> `--with-libsleef=` can only work for people manually built from sleef source
>> code.
>
> Yes. It still failed.
You need to expand this logic to cover more
On Fri, 1 Dec 2023 08:48:52 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
On Fri, 1 Dec 2023 10:19:01 GMT, Andrew Haley wrote:
>> Xiaohong Gong has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains ten additional
>> commits
> Classfile API is an internal library under package `jdk.internal.classfile`
> in JDK 21.
> This pull request turns the Classfile API into a preview feature and moves it
> into `java.lang.classfile`.
> It repackages all uses across JDK and tests and adds lots of missing Javadoc.
>
> This PR
On Wed, 29 Nov 2023 08:46:46 GMT, Per Minborg wrote:
>> This is explicit list of supported class file versions, so I don't see any
>> other way.
>
> Would it not be possible to expose an immutable `Map` that
> maps from Java version to major class version?
This is actually out of scope of
On Thu, 30 Nov 2023 09:39:54 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change will attempts to workaround an
>> issue in dsymutil?
>>
>> The previous attempt to use `--reproducer Off` has shown that it fails to
>> build on some other Xcode versions other than 14.3.1. Users
On Thu, 30 Nov 2023 09:39:54 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change will attempts to workaround an
>> issue in dsymutil?
>>
>> The previous attempt to use `--reproducer Off` has shown that it fails to
>> build on some other Xcode versions other than 14.3.1. Users
On Fri, 1 Dec 2023 08:48:52 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
On Fri, 1 Dec 2023 08:48:52 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on
On Fri, 1 Dec 2023 01:19:12 GMT, Xiaohong Gong wrote:
> > Not having a build time dependency on libsleef means you cannot really
> > verify that the functions you want to call are correct, but maybe you feel
> > secure that they will never change?
>
> I'm not sure. The main reason that we add
On Fri, 1 Dec 2023 09:59:58 GMT, Andrew Haley wrote:
> Not having a build time dependency on libsleef means you cannot really verify
> that the functions you want to call are correct, but maybe you feel secure
> that they will never change?
We can still have SLEEF tests, but they will require
On Fri, 1 Dec 2023 01:13:37 GMT, Xiaohong Gong wrote:
>> make/autoconf/lib-sleef.m4 line 56:
>>
>>> 54: AC_MSG_CHECKING([for the specified LIBSLEEF])
>>> 55: if test -e ${with_libsleef}/lib/libsleef.so &&
>>> 56:test -e ${with_libsleef}/include/sleef.h; then
>>
>>
On Thu, 30 Nov 2023 14:50:24 GMT, Andrew Haley wrote:
>> Do this, but with the name vect_math.S. Don't use SLEEF headers in the
>> build. I think you can do this with no build-time dependency on SLEEF at all
>> if you load the library lazily at runtime.
>>
>>
On Thu, 30 Nov 2023 23:49:24 GMT, Joe Darcy wrote:
>> Time to start making preparations for JDK 23.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update symbol files to JDK 22 b26.
Good good. I assume you'll bump the
> Currently the vector floating-point math APIs like
> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
> which causes large performance gap on AArch64. Note that those APIs are
> optimized by C2 compiler on X86 platforms by calling Intel's SVML code [1].
> To close
22 matches
Mail list logo
