On Tue, 30 Jan 2024 14:02:41 GMT, Matthias Baesken wrote:
>>> Yes there is a nice define in the AIX header
>>
>> *sigh* On linux, they go to some lengths to avoid this, using a __REDEFINE
>> mechanism. Oh well.
>>
>> Anyway, I think this particular can be resolved by not including the
>> sta
On Mon, 29 Jan 2024 13:13:44 GMT, Matthias Baesken wrote:
>> In the same spirit as
>> [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt
>> the AIX-specific code in hotspot so it uses the well-defined posix ``
>> functions, instead of `64`. By setting the define _LARGE
Please review a small change, at least as a "proof of concept", to allow
customized options to be given to `pandoc` based on the module and filename for
a spec.
The goal is to allow a Markdown spec file to have an auto-generated
table-of-contents, by including the `--toc` option when running pa
> Please review a patch to add support for Markdown syntax in documentation
> comments, as described in the associated JEP.
>
> Notable features:
>
> * support for `///` documentation comments in `JavaTokenizer`
> * new module `jdk.internal.md` -- a private copy of the `commonmark-java`
> libra
On Wed, 24 Jan 2024 22:38:58 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upstream/master
>> - Merge remote-tracki
On Wed, 24 Jan 2024 19:43:51 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upstream/master
>> - Merge remote-tracki
On Wed, 24 Jan 2024 16:30:50 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upstream/master
>> - Merge remote-tracki
On Wed, 24 Jan 2024 16:24:25 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - fix @since tags
>> - fix copyright year
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/tree/DocTreeMaker.
On Wed, 24 Jan 2024 12:17:19 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upstream/master
>> - Merge remote-tracki
On Tue, 23 Jan 2024 15:17:14 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upstream/master
>> - Merge remote-tracki
On Mon, 22 Jan 2024 16:57:16 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upstream/master
>> - Merge remote-tracki
On Tue, 23 Jan 2024 15:07:15 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upstream/master
>> - Merge remote-tracki
On Tue, 23 Jan 2024 12:50:45 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upstream/master
>> - Merge remote-tracki
On Thu, 25 Jan 2024 12:41:02 GMT, Pavel Rappo wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java
>> line 1388:
>>
>>> 1386: * @see >> href="https://spec.commonmark.org/0.30/#thematic-breaks";>Thematic Break
>>> 1387: */
>>> 1388:
On Tue, 23 Jan 2024 12:01:38 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upstream/master
>> - Merge remote-tracki
On Wed, 17 Jan 2024 00:14:58 GMT, Jiangli Zhou wrote:
> Please review this PR with a simple solution for resolving duplicate `Thread`
> symbol issue. In https://github.com/openjdk/jdk/pull/14808 comments, there
> was an alternative suggestion to redefine the symbol at build time, such as
> us
On Tue, 30 Jan 2024 19:05:02 GMT, Magnus Ihse Bursie wrote:
> or was it just a premature optimization that is causing us headache now?
This one. When I did this originally, I thought why have another job when we
can stash some groups together? But the cost for additional job is not actually
th
On Mon, 22 Jan 2024 15:35:41 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upstream/master
>> - Merge remote-tracki
On Tue, 30 Jan 2024 10:34:40 GMT, Aleksey Shipilev wrote:
> See the description in the bug. This mitigates the issue by splitting out the
> only test job that has two test suites in it.
I think this combination of two tests were made due to fear of too much
overhead of creating a small test su
On Tue, 30 Jan 2024 16:13:42 GMT, Hannes Wallnöfer wrote:
> This change adds the DejaVu web fonts that were previously maintained
> externally to the open repository so they are available both in JDK API
> documentation and any API documentation generated with the `javadoc` tool.
> All files a
On Tue, 30 Jan 2024 10:34:40 GMT, Aleksey Shipilev wrote:
> See the description in the bug. This mitigates the issue by splitting out the
> only test job that has two test suites in it.
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17627#pul
See the description in the bug. This mitigates the issue by splitting out the
only test job that has two test suites in it.
-
Commit messages:
- Revert test breakage and touchups
- Break the tier1_compiler test and see what happens
- Fix
Changes: https://git.openjdk.org/jdk/pull/
This change adds the DejaVu web fonts that were previously maintained
externally to the open repository so they are available both in JDK API
documentation and any API documentation generated with the `javadoc` tool. All
files added in this PR are the same as the ones previously maintained
exte
On Tue, 30 Jan 2024 14:15:57 GMT, Magnus Ihse Bursie wrote:
>> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
>> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
>> native libraries.
>
> Magnus Ihse Bursie has updated the pull request with a
> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
> native libraries.
Magnus Ihse Bursie has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev
On Tue, 30 Jan 2024 13:54:45 GMT, Magnus Ihse Bursie wrote:
> I'd appreciate if you could take the latest version for a spin, particularly
> a debug build...
Yes we pick up the latest version of the PR in a couple of hours for the
build+'lots of tests' (and this includes a fastdebug too).
--
On Thu, 18 Jan 2024 16:21:46 GMT, Julian Waters wrote:
>> [JDK-8323008](https://bugs.openjdk.org/browse/JDK-8323008) reports unwanted
>> autoconf flags being added to the command line, and solves the issue by
>> filtering out the added flags by force. This is not optimal however, as
>> doing s
On Tue, 30 Jan 2024 13:43:35 GMT, Matthias Baesken wrote:
> Yes there is a nice define in the AIX header
*sigh* On linux, they go to some lengths to avoid this, using a __REDEFINE
mechanism. Oh well.
Anyway, I think this particular can be resolved by not including the standard
includes in th
On Tue, 30 Jan 2024 13:02:53 GMT, Magnus Ihse Bursie wrote:
> @MBaesken You gotta be kidding me... They just put in a `#define open open64`
> in a convenient place? 😞
>
> But why do only slowdebug fail? Weird.
Yes there is a nice define in the AIX header
ifdef _LARGE_FILES
#define openope
> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
> native libraries.
Magnus Ihse Bursie has updated the pull request incrementally with one
additional commit since the last revision:
Move
On Tue, 30 Jan 2024 08:18:39 GMT, Matthias Baesken wrote:
>> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
>> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
>> native libraries.
>
> AIX fastdebug build fails with the patch, build error is
On Tue, 30 Jan 2024 12:52:56 GMT, Magnus Ihse Bursie wrote:
>> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
>> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
>> native libraries.
>
> Magnus Ihse Bursie has updated the pull request increm
On Mon, 29 Jan 2024 14:04:15 GMT, Joachim Kern wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Restore AIX dirent64 et al defines
>
> src/java.base/share/native/libjli/wildcard.c line 109:
>
>> 107: retu
On Mon, 29 Jan 2024 14:09:06 GMT, Sam James wrote:
>> src/java.base/unix/native/libjava/UnixFileSystem_md.c line 64:
>>
>>> 62: #define closedir closedir64
>>> 63: #define stat stat64
>>> 64: #endif
>>
>> same as above
>
> https://www.ibm.com/docs/en/aix/7.1?topic=volumes-writing-programs-t
> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
> native libraries.
Magnus Ihse Bursie has updated the pull request incrementally with one
additional commit since the last revision:
Rest
> In the same spirit as
> [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt
> the AIX-specific code in hotspot so it uses the well-defined posix ``
> functions, instead of `64`. By setting the define _LARGE_FILES, this
> will make `` behave as `64`, just as _FILE_OFFSE
On Mon, 29 Jan 2024 16:12:13 GMT, Matthias Baesken wrote:
>> make/autoconf/flags-cflags.m4 line 488:
>>
>>> 486: CFLAGS_OS_DEF_JDK="-D_ALLBSD_SOURCE -D_DARWIN_UNLIMITED_SELECT"
>>> 487: elif test "x$OPENJDK_TARGET_OS" = xaix; then
>>> 488: CFLAGS_OS_DEF_JVM="-DAIX"
>>
>> Why not
>>
On Mon, 29 Jan 2024 13:51:29 GMT, Joachim Kern wrote:
>> In the same spirit as
>> [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt
>> the AIX-specific code in hotspot so it uses the well-defined posix ``
>> functions, instead of `64`. By setting the define _LARGE_FIL
On Mon, 29 Jan 2024 13:13:44 GMT, Matthias Baesken wrote:
>> In the same spirit as
>> [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt
>> the AIX-specific code in hotspot so it uses the well-defined posix ``
>> functions, instead of `64`. By setting the define _LARGE
On Tue, 23 Jan 2024 15:42:55 GMT, Magnus Ihse Bursie wrote:
> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
> native libraries.
AIX fastdebug build fails with the patch, build error is
/
40 matches
Mail list logo
