On Tue, 30 Jan 2024 10:34:40 GMT, Aleksey Shipilev wrote:
> See the description in the bug. This mitigates the issue by splitting out the
> only test job that has two test suites in it.
Marked as reviewed by clanger (Reviewer).
-
PR Review:
> Please review a patch to add support for Markdown syntax in documentation
> comments, as described in the associated JEP.
>
> Notable features:
>
> * support for `///` documentation comments in `JavaTokenizer`
> * new module `jdk.internal.md` -- a private copy of the `commonmark-java`
>
On Fri, 26 Jan 2024 16:33:08 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upstream/master
>> - Merge
On Tue, 30 Jan 2024 00:39:43 GMT, Jonathan Gibbons wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java
>> line 259:
>>
>>> 257: LineKind lineKind = textKind == DocTree.Kind.MARKDOWN ?
>>> peekLineKind() : null;
>>> 258:
>>> 259: if
On Wed, 31 Jan 2024 23:09:57 GMT, Jonathan Gibbons wrote:
>> Yes, you need to escape `[` and `]` within the label of any Markdown
>> reference link, by preceding each with backslash. (Remember, the label is
>> the string used to find the URL for the link; not the displayed text of the
>>
> Please review a patch to add support for Markdown syntax in documentation
> comments, as described in the associated JEP.
>
> Notable features:
>
> * support for `///` documentation comments in `JavaTokenizer`
> * new module `jdk.internal.md` -- a private copy of the `commonmark-java`
>
On Wed, 31 Jan 2024 23:09:22 GMT, Jonathan Gibbons wrote:
>> My recollection is that you have to escape square brackets in a reference
>> label. I will investigate, and if necessary, add a test case.
>
> Yes, you need to escape `[` and `]` within the label of any Markdown
> reference link, by
On Wed, 31 Jan 2024 22:10:03 GMT, Jonathan Gibbons wrote:
>> src/jdk.internal.md/share/classes/jdk/internal/markdown/MarkdownTransformer.java
>> line 543:
>>
>>> 541: @Override
>>> 542: public LinkReferenceDefinition
>>> getLinkReferenceDefinition(String label)
On Tue, 30 Jan 2024 23:42:40 GMT, Jonathan Gibbons wrote:
>> src/jdk.internal.md/share/classes/jdk/internal/markdown/MarkdownTransformer.java
>> line 487:
>>
>>> 485: }
>>> 486:
>>> 487: private static final String AUTOREF_PREFIX = "code:";
>>
>> I wish the prefix were such that it
On Wed, 24 Jan 2024 22:35:31 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upstream/master
>> - Merge
> Please review a patch to add support for Markdown syntax in documentation
> comments, as described in the associated JEP.
>
> Notable features:
>
> * support for `///` documentation comments in `JavaTokenizer`
> * new module `jdk.internal.md` -- a private copy of the `commonmark-java`
>
On Tue, 30 Jan 2024 22:55:27 GMT, Jonathan Gibbons wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/tree/DocTreeMaker.java
>> line 238:
>>
>>> 236: && postamble.isEmpty()
>>> 237: && fullBody.stream().anyMatch(t -> t.getKind()
>>> ==
> Please review a patch to add support for Markdown syntax in documentation
> comments, as described in the associated JEP.
>
> Notable features:
>
> * support for `///` documentation comments in `JavaTokenizer`
> * new module `jdk.internal.md` -- a private copy of the `commonmark-java`
>
On Fri, 12 Jan 2024 15:17:42 GMT, Per Minborg wrote:
> This PR proposes to remove the snippet files in
> `java/lang/foreign/snippet-files` from the build.
This pull request has now been integrated.
Changeset: f2920533
Author:Per Minborg
URL:
On Wed, 31 Jan 2024 00:49:09 GMT, Jonathan Gibbons wrote:
> Please review a small change, at least as a "proof of concept", to allow
> customized options to be given to `pandoc` based on the module and filename
> for a spec.
>
> The goal is to allow a Markdown spec file to have an
On Wed, 31 Jan 2024 17:19:21 GMT, Jonathan Gibbons wrote:
> > Yeah, right, make sure you have the following block in your md file:
> > ```
> > ---
> > # Copyright (c) 1993, 2023, Oracle and/or its affiliates. All rights
> > reserved.
> > ...
> > _pandoc-options_: --toc
> > ---
> > ```
>
> Wow;
On Wed, 31 Jan 2024 10:24:44 GMT, Magnus Ihse Bursie wrote:
> Yeah, right, make sure you have the following block in your md file:
>
> ```
> ---
> # Copyright (c) 1993, 2023, Oracle and/or its affiliates. All rights reserved.
> ...
> _pandoc-options_: --toc
> ---
> ```
Wow; will try that!
>
On Tue, 30 Jan 2024 19:05:02 GMT, Magnus Ihse Bursie wrote:
>> See the description in the bug. This mitigates the issue by splitting out
>> the only test job that has two test suites in it.
>
> I think this combination of two tests were made due to fear of too much
> overhead of creating a
On Wed, 31 Jan 2024 00:49:09 GMT, Jonathan Gibbons wrote:
> Please review a small change, at least as a "proof of concept", to allow
> customized options to be given to `pandoc` based on the module and filename
> for a spec.
>
> The goal is to allow a Markdown spec file to have an
On Wed, 31 Jan 2024 00:49:09 GMT, Jonathan Gibbons wrote:
> Please review a small change, at least as a "proof of concept", to allow
> customized options to be given to `pandoc` based on the module and filename
> for a spec.
>
> The goal is to allow a Markdown spec file to have an
On Tue, 30 Jan 2024 14:15:57 GMT, Magnus Ihse Bursie wrote:
>> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
>> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
>> native libraries.
>
> Magnus Ihse Bursie has updated the pull request with
On Wed, 31 Jan 2024 08:49:58 GMT, Magnus Ihse Bursie wrote:
> I suspect this worry of yours were more directed at the change for the JDK
Yes it is more a general worry, not especially related to Hotspot.
We could also add some kind of check (e.g. static assert or configure check)
to address
On Tue, 30 Jan 2024 12:25:47 GMT, Magnus Ihse Bursie wrote:
>> In the same spirit as
>> [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt
>> the AIX-specific code in hotspot so it uses the well-defined posix ``
>> functions, instead of `64`. By setting the define
On Mon, 29 Jan 2024 13:13:44 GMT, Matthias Baesken wrote:
>> In the same spirit as
>> [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt
>> the AIX-specific code in hotspot so it uses the well-defined posix ``
>> functions, instead of `64`. By setting the define
24 matches
Mail list logo
