Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-02 Thread Joe Darcy
On Fri, 2 Feb 2024 23:38:41 GMT, Joe Darcy wrote: > In its initial form, the changes are tested on Linux. Later on, I'll do > cross-platform builds to make sure there aren't any, say, windows-specific > changes that are needed as well. > PS Builds pass on all platforms (linux, mac, and

RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-02 Thread Joe Darcy
After the "this-escape" lint warning was added to javac (JDK-8015831), the base module was not updated to be able to compile with this warning enabled. This PR makes the necessary changes to allow the base module to build with the warning enabled. - Commit messages: -

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-02 Thread Joe Darcy
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote: > After the "this-escape" lint warning was added to javac (JDK-8015831), the > base module was not updated to be able to compile with this warning enabled. > This PR makes the necessary changes to allow the base module to build with > the

Re: RFR: 8325163: Enable -Wpedantic on clang

2024-02-02 Thread Erik Joelsson
On Fri, 2 Feb 2024 15:22:03 GMT, Magnus Ihse Bursie wrote: > Inspired by (the later backed-out) > [JDK-8296115](https://bugs.openjdk.org/browse/JDK-8296115), I propose to > enable `-Wpedantic` for clang. This has already found some irregularities in > the code, like mistakenly using `#import`

Integrated: JDK-8325148: Enable restricted javac warning in java.base

2024-02-02 Thread Joe Darcy
On Thu, 1 Feb 2024 21:10:48 GMT, Joe Darcy wrote: > The restricted javac warning is disabled for java.base, but could be enabled > by suppressing the warning in a handful of files. This pull request has now been integrated. Changeset: adc36040 Author:Joe Darcy URL:

Re: RFR: JDK-8325148: Enable restricted javac warning in java.base [v3]

2024-02-02 Thread Joe Darcy
> The restricted javac warning is disabled for java.base, but could be enabled > by suppressing the warning in a handful of files. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the

Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v7]

2024-02-02 Thread Magnus Ihse Bursie
On Fri, 2 Feb 2024 07:01:33 GMT, Sam James wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add kludge to BufferedRenderPipe.c for AIX > > make/modules/jdk.hotspot.agent/Lib.gmk line 31: > >> 29: >> 30:

Re: RFR: 8325163: Enable -Wpedantic on clang

2024-02-02 Thread Julian Waters
On Fri, 2 Feb 2024 15:22:03 GMT, Magnus Ihse Bursie wrote: > Inspired by (the later backed-out) > [JDK-8296115](https://bugs.openjdk.org/browse/JDK-8296115), I propose to > enable `-Wpedantic` for clang. This has already found some irregularities in > the code, like mistakenly using `#import`

Re: RFR: 8325163: Enable -Wpedantic on clang

2024-02-02 Thread Julian Waters
On Fri, 2 Feb 2024 15:22:03 GMT, Magnus Ihse Bursie wrote: > Inspired by (the later backed-out) > [JDK-8296115](https://bugs.openjdk.org/browse/JDK-8296115), I propose to > enable `-Wpedantic` for clang. This has already found some irregularities in > the code, like mistakenly using `#import`

Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v7]

2024-02-02 Thread Magnus Ihse Bursie
On Fri, 2 Feb 2024 15:48:04 GMT, Magnus Ihse Bursie wrote: >> src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c line 365: >> >>> 363: #else >>> 364: // Make sure we link to the 64-bit version of the functions >>> 365: my_openat_func = (openat_func*) dlsym(RTLD_DEFAULT,

Re: RFR: 8324539: Do not use LFS64 symbols in JDK libs [v7]

2024-02-02 Thread Magnus Ihse Bursie
On Fri, 2 Feb 2024 07:02:43 GMT, Sam James wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add kludge to BufferedRenderPipe.c for AIX > > src/java.base/linux/native/libnio/ch/FileDispatcherImpl.c line 94: >

Re: RFR: JDK-8325148: Enable restricted javac warning in java.base [v2]

2024-02-02 Thread Magnus Ihse Bursie
On Thu, 1 Feb 2024 22:19:26 GMT, Joe Darcy wrote: >> The restricted javac warning is disabled for java.base, but could be enabled >> by suppressing the warning in a handful of files. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: 8325176: Compiling native tests with clang on linux fails

2024-02-02 Thread Magnus Ihse Bursie
On Fri, 2 Feb 2024 15:27:39 GMT, Magnus Ihse Bursie wrote: > While we do not have automatic testing of using clang instead of gcc on > linux, we try to keep it in working condition. This is still the case for the > JDK itself, but there is a native test which fails to compile with clang. >

RFR: 8325176: Compiling native tests with clang on linux fails

2024-02-02 Thread Magnus Ihse Bursie
While we do not have automatic testing of using clang instead of gcc on linux, we try to keep it in working condition. This is still the case for the JDK itself, but there is a native test which fails to compile with clang. This should be fixed. - Commit messages: - 8325176:

RFR: 8325163: Enable -Wpedantic on clang

2024-02-02 Thread Magnus Ihse Bursie
Inspired by (the later backed-out) [JDK-8296115](https://bugs.openjdk.org/browse/JDK-8296115), I propose to enable `-Wpedantic` for clang. This has already found some irregularities in the code, like mistakenly using `#import` instead of `#include`. In this patch, I disable warnings for these

Re: RFR: 8314488: Compile the JDK as C++17 [v6]

2024-02-02 Thread Magnus Ihse Bursie
On Fri, 19 Jan 2024 12:08:21 GMT, Julian Waters wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Require clang 13 in toolchain.m4 > > Should I split the compiler upgrades into a different change and integrate >

Re: RFR: 8314488: Compile the JDK as C++17 [v6]

2024-02-02 Thread Magnus Ihse Bursie
On Thu, 11 Jan 2024 13:23:45 GMT, Julian Waters wrote: >> Compile the JDK as C++17, enabling the use of all C++17 language features > > Julian Waters has updated the pull request incrementally with one additional > commit since the last revision: > > Require clang 13 in toolchain.m4 Nobody

Re: RFR: 8324243: Fix GCC 14 build [v2]

2024-02-02 Thread Kim Barrett
On Fri, 2 Feb 2024 06:35:26 GMT, Sam James wrote: >> This fixes building with GCC 14: >> * Cherry-pick a fix from Harfbuzz upstream >> * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources >> >> -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses >> -Werror. >>