Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v36]

2024-02-19 Thread Jonathan Gibbons
On Fri, 16 Feb 2024 07:42:47 GMT, Hannes Wallnöfer wrote: >> Jonathan Gibbons has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Support for Table Of Contents in Markdown headings >> - fix typo > > src/jdk.compiler/share/classes/com/sun/

Re: Hotspot symbol visibility - surprising news!

2024-02-19 Thread Daniel Jeliński
Hi Magnus, The "massive generated mapfile" is used on Windows. As you noticed, on Linux symbols are exported if they are both JNIEXPORT and listed in the mapfile. On Windows, the symbols are exported if they are either JNIEXPORT or listed in the mapfile. The Windows symbolicator needs to see the v

Integrated: 8325950: Make sure all files in the JDK pass jcheck

2024-02-19 Thread Magnus Ihse Bursie
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote: > Since jcheck only checks file in a commit, there is a possibility of us > getting files in the repository that would not be accepted by jcheck. This > can happen when extending the set of files checked by jcheck, or if jcheck > chan

Integrated: 8325972: Add -x to bash for building with LOG=debug

2024-02-19 Thread Magnus Ihse Bursie
On Thu, 15 Feb 2024 15:07:46 GMT, Magnus Ihse Bursie wrote: > I don't understand why I have never thought of this before. If we add `-x` to > the set of bash arguments when running with LOG=debug, we get output of *all* > shell commands that make is running, even those for $(shell). > > This m

Re: RFR: 8325881: Require minimum gcc version 10

2024-02-19 Thread Magnus Ihse Bursie
On Sat, 17 Feb 2024 08:28:56 GMT, Kim Barrett wrote: > Please review this change that updates the minimum supported version of gcc > to be used for building OpenJDK from 6.0 to 10.0. > > This permits enabling C++17 (JDK-8314488), though gcc 9.0 might suffice for > that. A minimum of gcc 10 also

Re: Hotspot symbol visibility - surprising news!

2024-02-19 Thread Magnus Ihse Bursie
On 2024-02-14 11:06, Magnus Ihse Bursie wrote: I am currently pursuing improved build functionality for static libraries. One of the issues with static libraries are name collisions, which led me back to an old discussion about which symbols are exported from Hotspot, and how this is achieved.

Re: RFR: 8325963: Clean up NativeCompilation.gmk and its newly created parts

2024-02-19 Thread Julian Waters
On Thu, 15 Feb 2024 14:13:19 GMT, Magnus Ihse Bursie wrote: > This is a follow-up to > [JDK-8325877](https://bugs.openjdk.org/browse/JDK-8325877). I was careful in > that bug not to change order of any lines, only split up the original file > into parts. > > In this PR, I use the new structur

Re: RFR: 8325963: Clean up NativeCompilation.gmk and its newly created parts

2024-02-19 Thread Julian Waters
On Thu, 15 Feb 2024 14:13:19 GMT, Magnus Ihse Bursie wrote: > This is a follow-up to > [JDK-8325877](https://bugs.openjdk.org/browse/JDK-8325877). I was careful in > that bug not to change order of any lines, only split up the original file > into parts. > > In this PR, I use the new structur

Re: RFR: 8325963: Clean up NativeCompilation.gmk and its newly created parts

2024-02-19 Thread Magnus Ihse Bursie
On Thu, 15 Feb 2024 14:13:19 GMT, Magnus Ihse Bursie wrote: > This is a follow-up to > [JDK-8325877](https://bugs.openjdk.org/browse/JDK-8325877). I was careful in > that bug not to change order of any lines, only split up the original file > into parts. > > In this PR, I use the new structur

RFR: 8325963: Clean up NativeCompilation.gmk and its newly created parts

2024-02-19 Thread Magnus Ihse Bursie
This is a follow-up to [JDK-8325877](https://bugs.openjdk.org/browse/JDK-8325877). I was careful in that bug not to change order of any lines, only split up the original file into parts. In this PR, I use the new structure to improve the design. I collect the functionality into three clearly s

Re: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v50]

2024-02-19 Thread Magnus Ihse Bursie
On Sun, 21 Jan 2024 07:58:11 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes >> the Visual C compiler much less acceptin