Re: RFR: 8328614: hsdis: dlsym can't find decode symbol

2024-03-20 Thread Robbin Ehn
On Thu, 21 Mar 2024 06:02:56 GMT, David Holmes wrote: >> Hi, please consider. >> >> [8327045](https://bugs.openjdk.org/browse/JDK-8327045) hide these symbols. >> Tested with gcc and clang, and llvm and binutils backend. >> >> I didn't find any use of the "DLL_ENTRY", so I removed it. >> >> Tha

Re: RFR: 8328614: hsdis: dlsym can't find decode symbol

2024-03-20 Thread David Holmes
On Wed, 20 Mar 2024 16:17:36 GMT, Robbin Ehn wrote: > Hi, please consider. > > [8327045](https://bugs.openjdk.org/browse/JDK-8327045) hide these symbols. > Tested with gcc and clang, and llvm and binutils backend. > > I didn't find any use of the "DLL_ENTRY", so I removed it. > > Thanks, Robbi

Re: RFR: 8327476: Upgrade JLine to 3.25.1 [v4]

2024-03-20 Thread Jan Lahoda
> This is a patch that: > a) upgrades the JLine inside the JDK to 3.25.1 > b) since the new version of JLine has a FFM backend, our custom native > backends are removed, and replaced with the FFM backend > > Some changes had to be made to the original JLine in order to fit into the > JDK. Most o

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v23]

2024-03-20 Thread Mandy Chung
On Wed, 20 Mar 2024 10:24:23 GMT, Severin Gehwolf wrote: > What we really want is some form of API to extend/patch an existing jimage > preserving everything else. Perhaps I should look into that. Would that be > worth doing? I think avoiding the plugin pipeline in creating a linkable image is

Re: RFR: 8328628: JDK-8328157 incorrectly sets -MT on all compilers in jdk.jpackage

2024-03-20 Thread Julian Waters
On Wed, 20 Mar 2024 16:20:36 GMT, Magnus Ihse Bursie wrote: > In [JDK-8328157](https://bugs.openjdk.org/browse/JDK-8328157), I rewrote the > logic to replace -MD with -MT for compiling on Windows. Unfortunately, I > mistakenly set -MT for all compilers, not just for visual studio. Looks good.

Re: RFR: 8328628: JDK-8328157 incorrectly sets -MT on all compilers in jdk.jpackage

2024-03-20 Thread Erik Joelsson
On Wed, 20 Mar 2024 16:20:36 GMT, Magnus Ihse Bursie wrote: > In [JDK-8328157](https://bugs.openjdk.org/browse/JDK-8328157), I rewrote the > logic to replace -MD with -MT for compiling on Windows. Unfortunately, I > mistakenly set -MT for all compilers, not just for visual studio. Marked as re

RFR: 8328628: JDK-8328157 incorrectly sets -MT on all compilers in jdk.jpackage

2024-03-20 Thread Magnus Ihse Bursie
In [JDK-8328157](https://bugs.openjdk.org/browse/JDK-8328157), I rewrote the logic to replace -MD with -MT for compiling on Windows. Unfortunately, I mistakenly set -MT for all compilers, not just for visual studio. - Commit messages: - 8328628: JDK-8328157 incorrectly sets -MT on

RFR: 8328614: hsdis: dlsym can't find decode symbol

2024-03-20 Thread Robbin Ehn
Hi, please consider. [8327045](https://bugs.openjdk.org/browse/JDK-8327045) hide these symbols. Tested with gcc and clang, and llvm and binutils backend. I didn't find any use of the "DLL_ENTRY", so I removed it. Thanks, Robbin - Commit messages: - export symbols Changes: https:/

Re: RFR: JDK-8324774: Add DejaVu web fonts [v2]

2024-03-20 Thread Hannes Wallnöfer
> This change adds the DejaVu web fonts that were previously maintained > externally to the open repository so they are available both in JDK API > documentation and any API documentation generated with the `javadoc` tool. > All files added in this PR are the same as the ones previously maintain

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v4]

2024-03-20 Thread Ludovic Henry
On Fri, 15 Mar 2024 13:58:05 GMT, Hamlin Li wrote: >> Hi, >> Can you help to review this patch? >> Thanks >> >> This is a continuation of work based on [1] by @XiaohongGong, most work was >> done in that pr. In this new pr, just rebased the code in [1], then added >> some minor changes (renami

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v2]

2024-03-20 Thread Hamlin Li
On Fri, 15 Mar 2024 11:25:37 GMT, Hamlin Li wrote: > > * There is no way to stop the VM from trying to load vmath ? > > No official way, but deleting libvmath.so will have a same effect. I'm not > sure if avoiding loading vmath is necessary for typical users, if it turns > out to be true, we c

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v23]

2024-03-20 Thread Severin Gehwolf
On Tue, 19 Mar 2024 18:05:31 GMT, Mandy Chung wrote: > Thanks for the details. I feel the pain in extending jlink for this work as > the current jlink implementation is not easily understandable and has been > yearning for rewrite in my perspective (looking forward to Project Leyden's > conden